From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227ItcmzT2M/WFggtWnBNR0J2+/IeuT9PS81S3AAn7tQg42OvJVEayucitCWwjqg8eqQFArp ARC-Seal: i=1; a=rsa-sha256; t=1518148838; cv=none; d=google.com; s=arc-20160816; b=X3Kot8dziR0Wkf7wN/DpE9E0GhfMY1D58gx4VBaLAS8pi5aMsSXBwpRnlQUGnKnP5h zFlp4jnwxKRXRuPPr94wW6UlMQWxnRci2iGV/2vjcDYrU4eBfpxXoXrBnI/EHMjoLBiN 7txd5si6IgD0Ssq9pFEPNFOMM8gmCWfN+HgvaE+F34Xb+tAPKmm+ZAKRvxR8Yfg4AuhP I00AbzoqU/dcvC9DrpwIsJPiRbmgmebYwQHpIAERCjWvYwbxoWMisHKPIdVKOxHGt8cm 1fKUojchXgLEFmIkhgGrOa0/+dJ1SWBgk/F8/XEQvPSSbP5SJ+flGdRwmzvO793nFCd+ Kq2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:subject:cc:from:to:in-reply-to :arc-authentication-results; bh=N1Vpr0wKfeyiD5PSRrA95fr3NrynWfQOkWIOCvcOo4w=; b=k48QhEGbIh6+wtgo4mRvfv6ojiTHQ1EfAgLfBQ+aMx2RUfjnD0i382fLweqp51a21V Rmw5cLay0QybHCvHo5UC0lZNo5SANBbFbjmL0zgTkMLNkstMpR4mXmpifkXX3MLT74S5 4Ynv3PHFcQa6qn1bPd+e/jqwm9Q69MqlbTt2WOEaVT2XkT3Bak3SVV3hHUacdWTH1EDo bhq6cjHtK4N6Lusq47UKivwXAmYi3pqvl52VW8DWpuZoDJV3lJhDiuuKNkcPE1+Nlhvj GxLt+7o1ZHQyEU5NOMZg7v0gIvNLKzJc24ZVA82SPS3uokFoubtzvC1XZYIZtEXhqhKb W4Ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of michael@ozlabs.org designates 2401:3900:2:1::2 as permitted sender) smtp.mailfrom=michael@ozlabs.org Authentication-Results: mx.google.com; spf=pass (google.com: domain of michael@ozlabs.org designates 2401:3900:2:1::2 as permitted sender) smtp.mailfrom=michael@ozlabs.org X-powerpc-patch-notification: thanks X-powerpc-patch-commit: dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5 In-Reply-To: <20180130151144.32544-1-colin.king@canonical.com> To: Colin King , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ocxl: fix signed comparison with less than zero Message-Id: <3zd1Ys6HkGz9sRm@ozlabs.org> Date: Fri, 9 Feb 2018 15:00:33 +1100 (AEDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591030691319252976?= X-GMAIL-MSGID: =?utf-8?q?1591894435941479188?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, 2018-01-30 at 15:11:44 UTC, Colin King wrote: > From: Colin Ian King > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King > Acked-by: Andrew Donnellan > Acked-by: Frederic Barrat Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/dedab7f0d3137441a97fe7cf9b9ca5 cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Fri, 09 Feb 2018 04:00:33 +0000 Subject: Re: ocxl: fix signed comparison with less than zero Message-Id: <3zd1Ys6HkGz9sRm@ozlabs.org> List-Id: In-Reply-To: <20180130151144.32544-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 2018-01-30 at 15:11:44 UTC, Colin King wrote: > From: Colin Ian King > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King > Acked-by: Andrew Donnellan > Acked-by: Frederic Barrat Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/dedab7f0d3137441a97fe7cf9b9ca5 cheers