From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85180C433F5 for ; Wed, 23 Mar 2022 21:16:38 +0000 (UTC) Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nX8L2-0007uF-Pm; Wed, 23 Mar 2022 17:16:16 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1nX8L0-0007u5-Gz for kernelnewbies@kernelnewbies.org; Wed, 23 Mar 2022 17:16:14 -0400 Received: by mail-lf1-x12b.google.com with SMTP id w27so4816110lfa.5 for ; Wed, 23 Mar 2022 14:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=1kyb35Xyyf/bXzX32T86rFLCcM7bgoq8lw6YhtpzITI=; b=DKNg3U0CXJGbWQRSO6GDGR7BOTOfsMFeboRK+X1bMTXg19gXMpB4TjlPWnA5Z12RB1 uTCvZJBBHpYe2C0FqHSJGpG/UWM/1JVXgSeoQldkPK2mHkyRk1vZ+Eo3SqGF59WTKtZK ZlRVb4p71M6D77Rxze7n2KUWofffma/m8kP+IvnRaT8PSZSA/20Kpo7p/DLq6bYMV1RM TBJPOn2Qm/103YF7dmaSw8OslzTMU9wvlLjbzDXDeNhaFoRGQjz+ZkCijeKxg6WyoZbp 3Isa5XpafE5aACJZ7mca8DTbpDBTkWTAhV01I+xvcLhA8aFvHzdBDu9+qFnDl9amH/PL kDuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=1kyb35Xyyf/bXzX32T86rFLCcM7bgoq8lw6YhtpzITI=; b=yICeRDdC1r5dZsaEu9xcfj2oUU6lkcP52lxx42d2rDVqnPwZA1arQONFozpLBjiWI+ Eeb5IyOrEV4FdXfb6untlj8TqN8YUPR7JppxYQgFOnB0gDtW+FsXT+4wx88DNjN6ekXB DCq86MzF/N9sYflp0pXoAf04aSM1T4tnIZaAYQf6wglyxyo330iuA34Udbwp3KL9jTiq jPlEP3hipwcIx7VYT6vRwn+FHqvAeAOkks/23mYAdCSK1/7/qd/pAQOaJn/F/RBslBKm +LNVRoMXKk4k3aGEAPcK2QM/1UhKOiZ2dHyAX+bWsGqqy0nYC5mKyE2ECtaL7rkEh6Rf P9Pg== X-Gm-Message-State: AOAM530YiIz3ngZa6rpHgBFGtcRRQS3hvqWN6Zg1xJ7GTTbZLx1eHlQU rdDVXXGFCxReudlY9UezDaeTrH7k//s= X-Google-Smtp-Source: ABdhPJznhBkzxYhYcPX2l/H6GHwWtyFjVnBnk6raXXRGm0meoKzjP+bJ8vsdo9PvYTB+1rpQLfKQqg== X-Received: by 2002:a05:6512:3a83:b0:44a:b79:6988 with SMTP id q3-20020a0565123a8300b0044a0b796988mr1285106lfu.595.1648070170663; Wed, 23 Mar 2022 14:16:10 -0700 (PDT) Received: from [192.168.1.11] ([46.235.67.145]) by smtp.gmail.com with ESMTPSA id o3-20020a198c03000000b00448b7b1780csm97081lfd.63.2022.03.23.14.16.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 14:16:10 -0700 (PDT) Message-ID: <40036dda-d059-3248-347f-3055ce1a0cd4@gmail.com> Date: Thu, 24 Mar 2022 00:16:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: arm64 code looking for variable rodata_enabled when STRICT_KERNEL_RWX = n Content-Language: en-US To: Chan Kim , kernelnewbies@kernelnewbies.org References: <0b3f01d83a8d$ee6b5180$cb41f480$@etri.re.kr> From: Pavel Skripkin In-Reply-To: <0b3f01d83a8d$ee6b5180$cb41f480$@etri.re.kr> X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kernelnewbies-bounces@kernelnewbies.org Hi Chan, On 3/18/22 09:03, Chan Kim wrote: > Hello all, > [...] > > But now since CONFIG_STRICT_KERNEL_RWX=n, it is not defined > here(CONFIG_STRICT_MODULE_RWX=n too). > > and arch/arm64/mm/mmu.c code is still using `rodata_enabled`. Is this a bug > of the code? Or am I missing something? > > If arch specifies something in its Kconfig then arch code is not prepared to be built with modified configuration. Arch Kconfig is persistent, that means if you change it you should also change the code. > I can modify init/main.c and include/linux/init.h so that this > rodata_enabled and related functions be defined regardless of these CONFIG > values and make the errors go away, but I'm curious if this a kind of kernel > bug raising compiler error. > It's not a kernel bug. You have misconfigured the kernel and faced compile error. Common case With regards, Pavel Skripkin _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies