Re: [RFC v2] xen/arm: Suspend to RAM Support in Xen for ARM

[Julien Grall <julien.grall@linaro.org>]

Hi Edgar,

On 25/01/18 14:15, Edgar E. Iglesias wrote:
> On Wed, Jan 24, 2018 at 07:04:35PM +0100, Mirela Simonovic wrote:
>> Hi Oleksandr, Edgar,
>>
>>
>> Thanks, you're right.
>>
>>
>> On 01/23/2018 12:58 PM, Edgar E. Iglesias wrote:
>>> On Tue, Jan 23, 2018 at 01:52:50PM +0200, Oleksandr Tyshchenko wrote:
>>>> Hi Mirela,
>>>>
>>>> Just some remarks regarding the scope of work:
>>>>
>>>> +In addition, the following have to be implemented:
>>>> +* Suspend/resume vCPU (triggered by vSYSTEM_SUSPEND call)
>>>> +* Suspend/resume Xen (triggered by vSYSTEM_SUSPEND called by Dom0), including:
>>>> +       * Disable wathdog on suspend, enable it on resume
>>>> +       * Pause domains on suspend, unpause them on resume
>>>> +       * Disable non-boot pCPUs on suspend, enable them on resume
>>>> +       * Save/restore of GIC configuration
>>>> +       * Suspend/resume timer
>>>> +       * Save/restore of EL2 context
>>>> +       * Implement resume entry point in Xen, including MMU configuration
>>>>
>>>> I think that saving/restoring IOMMU registers/context should be
>>>> implemented as well.
>>> Yes, good point.
>>> Mirela, I think that in the ZU+ case the IOMMU actually gets powered down
>>> with the FPD.
>>
>> Yes, it is in FPD.
> 
> Having said that it may still be useful from a patch review perspective
> to incrementally add things. Perhaps the IOMMU suspending support could
> come in follow-up patch series if others agree.

+1 :). I suspect the suspend/resume patch set will be quite big. So 
anything that can help the review (e.g splitting patch series, moving 
out some parts of the initial work...) would be greatly appreciated.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel