From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC29C43603 for ; Sun, 15 Dec 2019 03:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FC972073D for ; Sun, 15 Dec 2019 03:18:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vTcdmZlK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbfLODRU (ORCPT ); Sat, 14 Dec 2019 22:17:20 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:40976 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfLODRT (ORCPT ); Sat, 14 Dec 2019 22:17:19 -0500 Received: by mail-qv1-f68.google.com with SMTP id x1so18045qvr.8 for ; Sat, 14 Dec 2019 19:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=/dXw9e16vwl8LpxK98yuq5eDs/kqmpne1VxegZwo9tU=; b=vTcdmZlKxf6Ut2mCo3MRUIykmRVOIPR2SVz/XMIIfmlf/CcR506FaZII7DWsRM3CHr 75t2eanICwi/fUz5NNcTcLldWv0vqC/gj/g40ABeMzqbMJ/FmaHIIUFdlVfthXI2Sw1v Hh1U26lmbHakoyOqgN8XPmHJDBaGLmyqvia0gvl5LRV74J/Nff/hsv1lzqO+80XT4wKW 1hCHVfvRXrh9jcpQ6c1k3mb1scR3m8Z3IjsivBU208msc8JVqlo+3kqOgjbFerQSJCW7 T59YDUW02RVo6sAw/GlY15kwdIlEpUXY2GaKej0Ra0+h4nR2FBUSEGlQQ5Q0CjlpKLOk BQQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=/dXw9e16vwl8LpxK98yuq5eDs/kqmpne1VxegZwo9tU=; b=UF94Twmr2UtwqogQEeBG3gzbDWCvwLFpoJcD+P6dckoBl5j5gYkD5taI97L9Zjidl9 fvkE2TjXrCzdMEvghDW8bgYYp6B8ScZ0LVP6BbQbjGvbMPTl7AxzPWQFll7ftiuMsfa5 ebpqtCkuRXWvm0pxojMW4slFj4INF/+S/2FmHOiVX6JKRLrvs3cPmEzpzpjs5IL7KisT H+kFrYGy2f8Kne4e4cUFn/fXEwnRAxl28FN8nNrblO/Hdsqk5+dFek0GD/5j5wMsVjJ1 c9fItuCVk2gczFYfCeQT3QpwH3L+9Jajp+tqHPD+Zhs3a2LpyvGPIxwdYX/lJymwYN6B i7vA== X-Gm-Message-State: APjAAAVI21lVmrZb4JcUZK0RYTEWLav6KCeUpKGQKxk4Hk3eTxQ/HNqj O9/l52BBECqcHD73faLpXQ== X-Google-Smtp-Source: APXvYqzBXdaiKTf32Px9Udixmb+daFEYrWp8FC6bTC09CpUnoxtDzvVcUtp18RU54sNJ609QMeCjIA== X-Received: by 2002:a05:6214:7cc:: with SMTP id bb12mr5862753qvb.207.1576379838584; Sat, 14 Dec 2019 19:17:18 -0800 (PST) Received: from [120.7.1.38] ([184.175.21.212]) by smtp.gmail.com with ESMTPSA id c84sm4567540qkg.78.2019.12.14.19.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2019 19:17:17 -0800 (PST) To: hch@lst.de, DRI mailing list , LKML Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Deucher, Alexander" , Pavel Machek From: Woody Suwalski Subject: Regression in 5.4 kernel on 32-bit Radeon IBM T40 Message-ID: <400f6ce9-e360-0860-ca2a-fb8bccdcdc9b@gmail.com> Date: Sat, 14 Dec 2019 22:17:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Regression in 5.4 kernel on 32-bit Radeon IBM T40 triggered by commit 33b3ad3788aba846fc8b9a065fe2685a0b64f713 Author: Christoph Hellwig Date:   Thu Aug 15 09:27:00 2019 +0200 Howdy, The above patch has triggered a display problem on IBM Thinkpad T40, where the screen is covered with a lots of random short black horizontal lines, or distorted letters in X terms. The culprit seems to be that the dma_get_required_mask() is returning a value 0x3fffffff which is smaller than dma_get_mask()0xffffffff.That results in dma_addressing_limited()==0 in ttm_bo_device(), and using 40-bits dma instead of 32-bits. If I hardcode "1" as the last parameter to ttm_bo_device_init() in place of a call to dma_addressing_limited(),the problem goes away. I have added the debug lines starting with "wms:" to the start of radeon_ttm_init() and of radeon_device_init()printing the interesting variables. /.... [    2.091692] Linux agpgart interface v0.103 [    2.092380] agpgart-intel 0000:00:00.0: Intel 855PM Chipset [    2.107706] agpgart-intel 0000:00:00.0: AGP aperture is 256M @ 0xd0000000 [    2.108111] [drm] radeon kernel modesetting enabled. [    2.108200] radeon 0000:01:00.0: vgaarb: deactivate vga console [    2.109365] Console: switching to colour dummy device 80x25 ******* radeon_device_init() [    2.110712] wms: radeon_init flags = 0x90003 [    2.110718] [drm] initializing kernel modesetting (RV200 0x1002:0x4C57 0x1014:0x0530 0x00). [    2.111220] agpgart-intel 0000:00:00.0: AGP 2.0 bridge [    2.111233] agpgart-intel 0000:00:00.0: putting AGP V2 device into 1x mode [    2.111265] radeon 0000:01:00.0: putting AGP V2 device into 1x mode [    2.111286] radeon 0000:01:00.0: GTT: 256M 0xD0000000 - 0xDFFFFFFF [    2.111295] radeon 0000:01:00.0: VRAM: 128M 0x00000000E0000000 - 0x00000000E7FFFFFF (32M used) [    2.111701] [drm] Detected VRAM RAM=128M, BAR=128M [    2.111704] [drm] RAM width 64bits DDR ******* radeon_ttm_init() [    2.111706] wms: dma_addressing_limited=0x0 [    2.111709] wms: dma_get_mask=0xffffffff, bus_dma_limit=0x0, dma_get_required_mask=0x3fffffff [    2.115971] [TTM] Zone  kernel: Available graphics memory: 437028 KiB [    2.115973] [TTM] Zone highmem: Available graphics memory: 510440 KiB What should be the proper value of these dma variables on the 32-bit system? How to fix that issue correctly (patches welcomed :-) )Or is the platform fubar? Thanks, Woody From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC9AC43603 for ; Mon, 16 Dec 2019 08:30:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B98DB20733 for ; Mon, 16 Dec 2019 08:30:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vTcdmZlK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B98DB20733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC22C6E191; Mon, 16 Dec 2019 08:30:48 +0000 (UTC) Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95ED76E212 for ; Sun, 15 Dec 2019 03:17:19 +0000 (UTC) Received: by mail-qv1-xf42.google.com with SMTP id k10so1337177qve.7 for ; Sat, 14 Dec 2019 19:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=/dXw9e16vwl8LpxK98yuq5eDs/kqmpne1VxegZwo9tU=; b=vTcdmZlKxf6Ut2mCo3MRUIykmRVOIPR2SVz/XMIIfmlf/CcR506FaZII7DWsRM3CHr 75t2eanICwi/fUz5NNcTcLldWv0vqC/gj/g40ABeMzqbMJ/FmaHIIUFdlVfthXI2Sw1v Hh1U26lmbHakoyOqgN8XPmHJDBaGLmyqvia0gvl5LRV74J/Nff/hsv1lzqO+80XT4wKW 1hCHVfvRXrh9jcpQ6c1k3mb1scR3m8Z3IjsivBU208msc8JVqlo+3kqOgjbFerQSJCW7 T59YDUW02RVo6sAw/GlY15kwdIlEpUXY2GaKej0Ra0+h4nR2FBUSEGlQQ5Q0CjlpKLOk BQQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=/dXw9e16vwl8LpxK98yuq5eDs/kqmpne1VxegZwo9tU=; b=hU3OBvH18daVg2EJC/aCAD9MtGe5NiGQhxuWevqZhsmxBwfbUzIKO/vn04jFPFpyEQ sCIHVxtB2ReT/J4RRq3D+LyswF9AS88xYOG5eOvxg9HPZcwK5d1i7Ntl9q1bkASI6RA5 DgIBrMxrJBSpMc9Y8Jc65Yf17ChHt6cDGOvJUKpyEYZFNcZDqwpUg84nHGugHeRJAOZF n1bcdjZPWIWzfdUFrOMOlPz/NH0S0+lZgCl48284ECAOi69bRZCNf0ODV1qO7hmFqVE5 2eRNMMk7zgZbtCvTnoPVH8Sugzqhhxza3m0nMUY4LXIiiqJDmR83qGgBc7lZgxeOGPYS 3Nyw== X-Gm-Message-State: APjAAAVaGB8MK/acw2bDINnzLTtsQnp9NmHc5ruHCNo5mNfZ1L8p6Iub UUgPZU+sS23TM1U/z+Gyug== X-Google-Smtp-Source: APXvYqzBXdaiKTf32Px9Udixmb+daFEYrWp8FC6bTC09CpUnoxtDzvVcUtp18RU54sNJ609QMeCjIA== X-Received: by 2002:a05:6214:7cc:: with SMTP id bb12mr5862753qvb.207.1576379838584; Sat, 14 Dec 2019 19:17:18 -0800 (PST) Received: from [120.7.1.38] ([184.175.21.212]) by smtp.gmail.com with ESMTPSA id c84sm4567540qkg.78.2019.12.14.19.17.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2019 19:17:17 -0800 (PST) To: hch@lst.de, DRI mailing list , LKML From: Woody Suwalski Subject: Regression in 5.4 kernel on 32-bit Radeon IBM T40 Message-ID: <400f6ce9-e360-0860-ca2a-fb8bccdcdc9b@gmail.com> Date: Sat, 14 Dec 2019 22:17:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.5 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 16 Dec 2019 08:30:48 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Deucher, Alexander" , =?UTF-8?Q?Christian_K=c3=b6nig?= , Pavel Machek Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" UmVncmVzc2lvbiBpbiA1LjQga2VybmVsIG9uIDMyLWJpdCBSYWRlb24gSUJNIFQ0MAp0cmlnZ2Vy ZWQgYnkKY29tbWl0IDMzYjNhZDM3ODhhYmE4NDZmYzhiOWEwNjVmZTI2ODVhMGI2NGY3MTMKQXV0 aG9yOiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KRGF0ZTrCoMKgIFRodSBBdWcgMTUg MDk6Mjc6MDAgMjAxOSArMDIwMAoKSG93ZHksClRoZSBhYm92ZSBwYXRjaCBoYXMgdHJpZ2dlcmVk IGEgZGlzcGxheSBwcm9ibGVtIG9uIElCTSBUaGlua3BhZCBUNDAsIAp3aGVyZSB0aGUgc2NyZWVu IGlzIGNvdmVyZWQgd2l0aCBhIGxvdHMgb2YgcmFuZG9tIHNob3J0IGJsYWNrIGhvcml6b250YWwg CmxpbmVzLCBvciBkaXN0b3J0ZWQgbGV0dGVycyBpbiBYIHRlcm1zLgoKVGhlIGN1bHByaXQgc2Vl bXMgdG8gYmUgdGhhdCB0aGUgZG1hX2dldF9yZXF1aXJlZF9tYXNrKCkgaXMgcmV0dXJuaW5nIGEg CnZhbHVlIDB4M2ZmZmZmZmYKd2hpY2ggaXMgc21hbGxlciB0aGFuIGRtYV9nZXRfbWFzaygpMHhm ZmZmZmZmZi5UaGF0IHJlc3VsdHMgaW4gCmRtYV9hZGRyZXNzaW5nX2xpbWl0ZWQoKT09MCBpbiB0 dG1fYm9fZGV2aWNlKCksIGFuZCB1c2luZyA0MC1iaXRzIGRtYSAKaW5zdGVhZCBvZiAzMi1iaXRz LgoKSWYgSSBoYXJkY29kZSAiMSIgYXMgdGhlIGxhc3QgcGFyYW1ldGVyIHRvIHR0bV9ib19kZXZp Y2VfaW5pdCgpIGluIHBsYWNlIApvZiBhIGNhbGwgdG8gZG1hX2FkZHJlc3NpbmdfbGltaXRlZCgp LHRoZSBwcm9ibGVtIGdvZXMgYXdheS4KCkkgaGF2ZSBhZGRlZCB0aGUgZGVidWcgbGluZXMgc3Rh cnRpbmcgd2l0aCAid21zOiIgdG8gdGhlIHN0YXJ0IG9mIApyYWRlb25fdHRtX2luaXQoKSBhbmQg b2YgcmFkZW9uX2RldmljZV9pbml0KClwcmludGluZyB0aGUgaW50ZXJlc3RpbmcgCnZhcmlhYmxl cy4KLy4uLi4KW8KgwqDCoCAyLjA5MTY5Ml0gTGludXggYWdwZ2FydCBpbnRlcmZhY2UgdjAuMTAz ClvCoMKgwqAgMi4wOTIzODBdIGFncGdhcnQtaW50ZWwgMDAwMDowMDowMC4wOiBJbnRlbCA4NTVQ TSBDaGlwc2V0ClvCoMKgwqAgMi4xMDc3MDZdIGFncGdhcnQtaW50ZWwgMDAwMDowMDowMC4wOiBB R1AgYXBlcnR1cmUgaXMgMjU2TSBAIDB4ZDAwMDAwMDAKW8KgwqDCoCAyLjEwODExMV0gW2RybV0g cmFkZW9uIGtlcm5lbCBtb2Rlc2V0dGluZyBlbmFibGVkLgpbwqDCoMKgIDIuMTA4MjAwXSByYWRl b24gMDAwMDowMTowMC4wOiB2Z2FhcmI6IGRlYWN0aXZhdGUgdmdhIGNvbnNvbGUKW8KgwqDCoCAy LjEwOTM2NV0gQ29uc29sZTogc3dpdGNoaW5nIHRvIGNvbG91ciBkdW1teSBkZXZpY2UgODB4MjUK KioqKioqKiByYWRlb25fZGV2aWNlX2luaXQoKQpbwqDCoMKgIDIuMTEwNzEyXSB3bXM6IHJhZGVv bl9pbml0IGZsYWdzID0gMHg5MDAwMwpbwqDCoMKgIDIuMTEwNzE4XSBbZHJtXSBpbml0aWFsaXpp bmcga2VybmVsIG1vZGVzZXR0aW5nIChSVjIwMCAKMHgxMDAyOjB4NEM1NyAweDEwMTQ6MHgwNTMw IDB4MDApLgpbwqDCoMKgIDIuMTExMjIwXSBhZ3BnYXJ0LWludGVsIDAwMDA6MDA6MDAuMDogQUdQ IDIuMCBicmlkZ2UKW8KgwqDCoCAyLjExMTIzM10gYWdwZ2FydC1pbnRlbCAwMDAwOjAwOjAwLjA6 IHB1dHRpbmcgQUdQIFYyIGRldmljZSBpbnRvIDF4IAptb2RlClvCoMKgwqAgMi4xMTEyNjVdIHJh ZGVvbiAwMDAwOjAxOjAwLjA6IHB1dHRpbmcgQUdQIFYyIGRldmljZSBpbnRvIDF4IG1vZGUKW8Kg wqDCoCAyLjExMTI4Nl0gcmFkZW9uIDAwMDA6MDE6MDAuMDogR1RUOiAyNTZNIDB4RDAwMDAwMDAg LSAweERGRkZGRkZGClvCoMKgwqAgMi4xMTEyOTVdIHJhZGVvbiAwMDAwOjAxOjAwLjA6IFZSQU06 IDEyOE0gMHgwMDAwMDAwMEUwMDAwMDAwIC0gCjB4MDAwMDAwMDBFN0ZGRkZGRiAoMzJNIHVzZWQp ClvCoMKgwqAgMi4xMTE3MDFdIFtkcm1dIERldGVjdGVkIFZSQU0gUkFNPTEyOE0sIEJBUj0xMjhN ClvCoMKgwqAgMi4xMTE3MDRdIFtkcm1dIFJBTSB3aWR0aCA2NGJpdHMgRERSCioqKioqKiogcmFk ZW9uX3R0bV9pbml0KCkKW8KgwqDCoCAyLjExMTcwNl0gd21zOiBkbWFfYWRkcmVzc2luZ19saW1p dGVkPTB4MApbwqDCoMKgIDIuMTExNzA5XSB3bXM6IGRtYV9nZXRfbWFzaz0weGZmZmZmZmZmLCBi dXNfZG1hX2xpbWl0PTB4MCwgCmRtYV9nZXRfcmVxdWlyZWRfbWFzaz0weDNmZmZmZmZmClvCoMKg wqAgMi4xMTU5NzFdIFtUVE1dIFpvbmXCoCBrZXJuZWw6IEF2YWlsYWJsZSBncmFwaGljcyBtZW1v cnk6IDQzNzAyOCBLaUIKW8KgwqDCoCAyLjExNTk3M10gW1RUTV0gWm9uZSBoaWdobWVtOiBBdmFp bGFibGUgZ3JhcGhpY3MgbWVtb3J5OiA1MTA0NDAgS2lCCgpXaGF0IHNob3VsZCBiZSB0aGUgcHJv cGVyIHZhbHVlIG9mIHRoZXNlIGRtYSB2YXJpYWJsZXMgb24gdGhlIDMyLWJpdCBzeXN0ZW0/Ckhv dyB0byBmaXggdGhhdCBpc3N1ZSBjb3JyZWN0bHkgKHBhdGNoZXMgd2VsY29tZWQgOi0pIClPciBp cyB0aGUgCnBsYXRmb3JtIGZ1YmFyPwoKVGhhbmtzLCBXb29keQoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=