Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	Yonggang Luo <luoyonggang@gmail.com>,
	qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Ed Maste" <emaste@FreeBSD.org>,
	qemu-block@nongnu.org, "Stefan Weil" <sw@weilnetz.de>,
	"Xie Changlong" <xiechanglong.d@gmail.com>,
	"Peter Lieven" <pl@kamp.de>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Wen Congyang" <wencongyang2@huawei.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Li-Wen Hsu" <lwhsu@freebsd.org>
Subject: Re: [PATCH v8 16/27] cirrus: Building freebsd in a single short
Date: Mon, 14 Sep 2020 10:50:28 +0200	[thread overview]
Message-ID: <401c7ac1-6575-1d77-40ef-a4ee4178711b@redhat.com> (raw)
In-Reply-To: <78c65c60-9598-97a2-0dc7-116c3c0f94a9@redhat.com>

On 9/14/20 9:27 AM, Thomas Huth wrote:
> On 13/09/2020 00.44, Yonggang Luo wrote:
>> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba
>> ("cirrus.yml: Split FreeBSD job into two parts").
>>
>> freebsd 1 hour limit not hit anymore
>>
>> I think we going to a wrong direction, I think there is some tests a stall the test runner,
>> please look at
>> https://cirrus-ci.com/task/5110577531977728
>> When its running properly, the consumed time are little, but when tests running too long,
>> look at the cpu usage, the cpu usage are nearly zero. doesn't consuming time.
>>
>> And look at
>> https://cirrus-ci.com/task/6119341601062912
>>
>> If the tests running properly, the time consuming are little
>> We should not hide the error by split them
>>
>> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> Reviewed-by: Ed Maste <emaste@FreeBSD.org>
>> ---
>>  .cirrus.yml | 35 ++++++++---------------------------
>>  1 file changed, 8 insertions(+), 27 deletions(-)
> 
> I tried this a couple of times now, and currently the problem seems to
> be gone, indeed. I'd still prefer to understand first why we have seen
> the slowdown a couple of weeks ago, but if people agree that we should
> revert the patch now, that's ok for me now, too.

Not sure if related (probably not as failure and not timeout),
I hit this during the night:

  TEST    iotest-qcow2: 030 [fail]
QEMU          --
"/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-system-alpha"
-nodefaults -display none -accel qtest
QEMU_IMG      --
"/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img"
QEMU_IO       --
"/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io"  --cache
writeback --aio threads -f qcow2
QEMU_NBD      --
"/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT        -- qcow2 (compat=1.1)
IMGPROTO      -- file
PLATFORM      -- FreeBSD/amd64 cirrus-task-6204750985166848 12.1-RELEASE
TEST_DIR      -- /tmp/cirrus-ci-build/build/tests/qemu-iotests/scratch
SOCK_DIR      -- /tmp/tmp.VuwmKXUW
SOCKET_SCM_HELPER --

--- /tmp/cirrus-ci-build/tests/qemu-iotests/030.out	2020-09-13
21:08:32.261276000 +0000
+++ /tmp/cirrus-ci-build/build/tests/qemu-iotests/030.out.bad	2020-09-13
21:30:59.736699000 +0000
@@ -1,5 +1,17 @@
-...........................
+.............F.............
+======================================================================
+FAIL: test_stream_parallel (__main__.TestParallelOps)
 ----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "030", line 251, in test_stream_parallel
+    self.assert_qmp(result, 'return', {})
+  File "/tmp/cirrus-ci-build/tests/qemu-iotests/iotests.py", line 888,
in assert_qmp
+    result = self.dictpath(d, path)
+  File "/tmp/cirrus-ci-build/tests/qemu-iotests/iotests.py", line 862,
in dictpath
+    self.fail(f'failed path traversal for "{path}" in "{d}"')
+AssertionError: failed path traversal for "return" in "{'error':
{'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not found"}}"
+
+----------------------------------------------------------------------
Failures: 030
Failed 1 of 74 iotests
gmake[1]: *** [/tmp/cirrus-ci-build/tests/Makefile.include:144:
check-block] Error 1
gmake[1]: Leaving directory '/tmp/cirrus-ci-build/build'

https://cirrus-ci.com/task/6204750985166848


