From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EC9C4320E for ; Tue, 31 Aug 2021 01:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D657561004 for ; Tue, 31 Aug 2021 01:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239209AbhHaBOc (ORCPT ); Mon, 30 Aug 2021 21:14:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbhHaBOc (ORCPT ); Mon, 30 Aug 2021 21:14:32 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 829C6C061575 for ; Mon, 30 Aug 2021 18:13:37 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id i3so9963714wmq.3 for ; Mon, 30 Aug 2021 18:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gwwwp57SwTctaxgmYl1l1IkxPrnIEbuUNvTFbHbB9zc=; b=vMd0I0p2hOKKFZxYUoERF54PuuNoTJUde3qs+Pa3YDYFNp6k5M2NnQDvqLn0KcHOjs o+8KMezp6dCJWTFlx3VPrLlpVpNOq3d/9jcDXIC1B7B3TTMczZBYwVqpPY826FozQ4eH bqVK9eFMoDWQDtoeFU12wCApsE34Hk98JedRcaCRq3j2gECbkAea9T3MK1BvrrOd1q7e zNBTwAETKHs5yzuEvpSOcbw1NqT72KNpuRWcdd2gO+tyqeSJvegNp2w7UO5sd0yHXp4o if3YzkvKngaC4C1iUZUH4/DjDaK+wQQUUoIzXQTpU8iCmL2U2Zv9ayvxzsQP15wCC1Jb +wmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gwwwp57SwTctaxgmYl1l1IkxPrnIEbuUNvTFbHbB9zc=; b=OvnxkOZ9Fq8cuXAaRolGe4sH7Xh0EyMHUA6qHd9zUR67qrTNMOwYBFcLM60KWd+Tnq LGLIZtFl60qHKOw85XCit90W1UErBV/gnbizUZ0dhU8ZbC0fbihZdPjuWfDafRjxKONV Z3Rhk7JhPXhOXxgb9/00zOmTnhk513YDn8BcsJBIQDMpgnLXNqeiYMTTT1w8EKnKljKs xPq7btoMLSXjiHUfnBKfewlrvSHe8dd9MSUMQlVbtPNclGMeKLs6tPCaTfMOwYj5saoy w8Oo5GBWCoes+boIGgVUpViG/e4wHqWzCIu2GeouNUXplfhmtt5RIPlRAB4MQ2v4s1kZ O/+Q== X-Gm-Message-State: AOAM533qcH/8Cc1g62iwgSxfw+fF3Tv2XATu9XJmJZoBNXuaMKtyIw7u UvpC2fDqaWscrJJRqz2/MG45uw== X-Google-Smtp-Source: ABdhPJxXav9cQB1UonIcAAQZNeVtr+uDjJsNuLpeUs+J0NLE0isqWdOGNYRrnoaj4TmwxJ0e2uKdMQ== X-Received: by 2002:a05:600c:2210:: with SMTP id z16mr1495166wml.70.1630372416053; Mon, 30 Aug 2021 18:13:36 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id c14sm976066wme.6.2021.08.30.18.13.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Aug 2021 18:13:34 -0700 (PDT) Subject: Re: [PATCH] Revert "wcn36xx: Enable firmware link monitoring" To: Loic Poulain , kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, stable@vger.kernel.org References: <1630343360-5942-1-git-send-email-loic.poulain@linaro.org> From: Bryan O'Donoghue Message-ID: <401fd67a-4965-d4ae-8b6c-8c81a179a8c7@linaro.org> Date: Tue, 31 Aug 2021 02:15:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1630343360-5942-1-git-send-email-loic.poulain@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 30/08/2021 18:09, Loic Poulain wrote: > This reverts commit 8def9ec46a5fafc0abcf34489a9e8a787bca984d. > > The firmware keep-alive does not cause any event in case of error > such as non acked. It's just a basic keep alive to prevent the AP > to kick-off the station due to inactivity. So let mac80211 submit > its own monitoring packet (probe/null) and disconnect on timeout. > > Note: We want to keep firmware keep alive to prevent kick-off > when host is in suspend-to-mem (no mac80211 monitor packet). > Ideally fw keep alive should be enabled in suspend path and disabled > in resume path to prevent having both firmware and mac80211 submitting > periodic null packets. > > This fixes non detected AP leaving issues in active mode (nothing > monitors beacon or connection). > > Cc: stable@vger.kernel.org > Fixes: 8def9ec46a5f ("wcn36xx: Enable firmware link monitoring") > Signed-off-by: Loic Poulain > --- > drivers/net/wireless/ath/wcn36xx/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c > index 216bc34..128d25d 100644 > --- a/drivers/net/wireless/ath/wcn36xx/main.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -1362,7 +1362,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) > ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL); > ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS); > ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS); > - ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR); > > wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | > BIT(NL80211_IFTYPE_AP) | > But why is BSS heartbeat offload not running, it should be. I agree we should switch this bit off for now since its obviously not working as intended. But we need to root cause _why_ In suspend absent a working heartbeat monitor - if the AP goes away we stay in suspend indefinitely. Given we don't have roam offload enabled either, in this reference, it also means we won't roam to a new AP until Linux resumes, which is certainly not the way we want this to work. In any case, for now until we solve this bug Acked-by: Bryan O'Donoghue