From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45189C04FF3 for ; Mon, 24 May 2021 14:02:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20D0161370 for ; Mon, 24 May 2021 14:02:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232935AbhEXOD5 (ORCPT ); Mon, 24 May 2021 10:03:57 -0400 Received: from mga02.intel.com ([134.134.136.20]:57733 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232685AbhEXODw (ORCPT ); Mon, 24 May 2021 10:03:52 -0400 IronPort-SDR: iPdetV0H2PEBbh00KjiG2xYeGimYoxkODx+Njp+NNPX1iEPwDTiHFmjPX/Ug9BAk6+sK6cHi3j BFLnM1xsijiw== X-IronPort-AV: E=McAfee;i="6200,9189,9993"; a="189062136" X-IronPort-AV: E=Sophos;i="5.82,325,1613462400"; d="scan'208";a="189062136" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 07:02:24 -0700 IronPort-SDR: jI7ZS3h/4UbJECht2U+futzaJOpalxKkYo6SM5/TK/275LD5dMWDY1DkD4i7hq/YQRmff+FP6u B6ht9E1LEp+A== X-IronPort-AV: E=Sophos;i="5.82,325,1613462400"; d="scan'208";a="442836126" Received: from imadu-mobl.amr.corp.intel.com (HELO [10.212.195.214]) ([10.212.195.214]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2021 07:02:22 -0700 Subject: Re: [RFC v2-fix 1/1] x86/traps: Add #VE support for TDX guest To: Dan Williams Cc: Dave Hansen , Kuppuswamy Sathyanarayanan , Peter Zijlstra , Andy Lutomirski , Tony Luck , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , Sean Christopherson , Linux Kernel Mailing List , Sean Christopherson References: <20210518000957.257869-1-sathyanarayanan.kuppuswamy@linux.intel.com> <4fc32900-412d-fa10-520e-afa6caade33e@intel.com> <81c0f447-44b8-c2b6-ce41-a39ec0a1832b@linux.intel.com> From: Andi Kleen Message-ID: <4031ffc2-a442-5da7-e793-ac1053533bb3@linux.intel.com> Date: Mon, 24 May 2021 07:02:21 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Only drivers that are not supported in TDX anyways could do it (mainly >> watchdog drivers) > What about apei_{read,write}() for ACPI error handling? Those are > called in NMI to do MMIO accesses. It's not just watchdog drivers. We expect the APEI stuff to be filtered in the normal case to reduce the attack surface. There's no use case for APEI error reporting in a normally operating TDX guest. But yes that's why I wrote mainly. It should work in any case, we fully support #VE nesting after TDVEREPORT. -Andi