From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C931C433F5 for ; Thu, 11 Nov 2021 09:41:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD32D60F45 for ; Thu, 11 Nov 2021 09:41:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD32D60F45 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 006D28375B; Thu, 11 Nov 2021 10:41:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 3C9F7839B4; Thu, 11 Nov 2021 10:41:52 +0100 (CET) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CA72783735 for ; Thu, 11 Nov 2021 10:41:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=heiko@sntech.de Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml6aZ-0000du-5J; Thu, 11 Nov 2021 10:41:47 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: u-boot@lists.denx.de, bmeng.cn@gmail.com, rick@andestech.com, anup.patel@wdc.com, atish.patra@wdc.com, hs@denx.de Cc: cyril.jean@microchip.com, lewis.hanly@microchip.com, conor.dooley@microchip.com, daire.mcnamara@microchip.com, ivan.griffin@microchip.com, valentina.fernandezalanis@microchip.com, Padmarao Begari , Padmarao Begari Subject: macb clock handling (Was: [PATCH v1 4/5] net: macb: Compatible as per device tree) Date: Thu, 11 Nov 2021 10:41:46 +0100 Message-ID: <4033485.bJdaIYV4bU@diego> In-Reply-To: <20211022085648.134655-5-padmarao.begari@microchip.com> References: <20211022085648.134655-1-padmarao.begari@microchip.com> <20211022085648.134655-5-padmarao.begari@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, not wanting to hijack this too much, but does the mac driver also need some sort of clock handling? Because on the Icicle I have here, I'm running into "TX timeout" errors: RISC-V # dhcp ethernet@20112000: PHY present at 9 ethernet@20112000: Starting autonegotiation... ethernet@20112000: Autonegotiation complete ethernet@20112000: link up, 1000Mbps full-duplex (lpa: 0x3800) BOOTP broadcast 1 ethernet@20112000: TX timeout BOOTP broadcast 2 ethernet@20112000: TX timeout BOOTP broadcast 3 ethernet@20112000: TX timeout BOOTP broadcast 4 ethernet@20112000: TX timeout The sifive variant of the macb distinguishes between speeds in its cllk_init callback, so I guess the Icicle might need that as well? Thanks Heiko Am Freitag, 22. Oktober 2021, 10:56:47 CET schrieb Padmarao Begari: > Update compatible as per Microchip PolarFire SoC ethernet > device node. > > Signed-off-by: Padmarao Begari > --- > drivers/net/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > index 8c6461e717..1b867bd5c2 100644 > --- a/drivers/net/macb.c > +++ b/drivers/net/macb.c > @@ -1502,7 +1502,7 @@ static const struct udevice_id macb_eth_ids[] = { > { .compatible = "cdns,zynq-gem" }, > { .compatible = "sifive,fu540-c000-gem", > .data = (ulong)&sifive_config }, > - { .compatible = "microchip,mpfs-mss-gem", > + { .compatible = "microchip,mpfs-gem", > .data = (ulong)µchip_config }, > { } > }; >