From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH] drm: rcar-du: Fix build failure Date: Wed, 16 May 2018 10:32:10 +0100 Message-ID: <4035b2dc-4b72-a4cb-d0aa-e917ad6c99dd@ideasonboard.com> References: <20180515174752.28954-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0668542972==" Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id D744F6E3A9 for ; Wed, 16 May 2018 09:32:15 +0000 (UTC) In-Reply-To: <20180515174752.28954-1-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0668542972== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rlbT1aSREwbqDqhAdwyAWgvZ9vpojDAhE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rlbT1aSREwbqDqhAdwyAWgvZ9vpojDAhE Content-Type: multipart/mixed; boundary="BgUiQCBVwImTrQDe4PlENYx1Po8Wuuyfw"; protected-headers="v1" From: Kieran Bingham To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: <4035b2dc-4b72-a4cb-d0aa-e917ad6c99dd@ideasonboard.com> Subject: Re: [PATCH] drm: rcar-du: Fix build failure References: <20180515174752.28954-1-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20180515174752.28954-1-laurent.pinchart+renesas@ideasonboard.com> --BgUiQCBVwImTrQDe4PlENYx1Po8Wuuyfw Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable Hi Laurent, Thanks for the fix. On 15/05/18 18:47, Laurent Pinchart wrote: > Commit 75a07f399cd4 ("drm: rcar-du: Zero-out sg_tables when duplicating= > plane state") introduced a reference to the alpha field of struct > rcar_du_vsp_plane_state that got removed in commit 301a9b8d5456 > ("drm/rcar-du: Convert to the new generic alpha property"). The issue > stems from the merge of the two commits through separate branches and > breaks compilation of the driver. Fix it. >=20 > Fixes: 75a07f399cd4 ("drm: rcar-du: Zero-out sg_tables when duplicating= plane state") > Signed-off-by: Laurent Pinchart The kms-tests work fine on this commit. Reviewed-by: Kieran Bingham Tested-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rc= ar-du/rcar_du_vsp.c > index 27a440886b17..c59f0cfabd33 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -314,7 +314,6 @@ rcar_du_vsp_plane_atomic_duplicate_state(struct drm= _plane *plane) > return NULL; > =20 > __drm_atomic_helper_plane_duplicate_state(plane, ©->state); > - copy->alpha =3D to_rcar_vsp_plane_state(plane->state)->alpha; > =20 > return ©->state; > } >=20 --BgUiQCBVwImTrQDe4PlENYx1Po8Wuuyfw-- --rlbT1aSREwbqDqhAdwyAWgvZ9vpojDAhE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkC3XmD+9KP3jctR6oR5GchCkYf0FAlr7+psACgkQoR5GchCk Yf0xdhAAoQnHNQ1dZeecpdfvh56A5DPyCEoR/0CWuRanCX5Lb5zCoPtUU9rDIgsD aUdPAkn21nqtC9U4eG19R8jzUPsRXSPVMhyW9etyxU4kXrpdRqqcMDfXwGDsk/ZA VN2nUPmw8sI1/8b245l5z7KseXRgPosRuMD8oYZIFs3C6wVRKyTljM21hr6ftrsm rujdUbqLQo0u/MPoOHmmcXEPdyzqvh+ZqlLeE336lgG0TE+kg93lZLDhT/H+ktO0 Fr4KXoONEfeKW9QKNg06/F7Aqk0/beILGKFXuRrH+PrWgGGCM9Xg7RQYI9sKNwVy HjjFlZrOB2WIvOWOdFvGOrjgw2gTdIpSPh7IryVeFgGXare6RX0wOc4WF4mGzzcf Ez3m4lHuW8RsInoWzSZIVrU7mIflWl4BD7+9g3Gqim2xMpUo+tHKGh77bwIS9ypx xrYJk2brpGRyHG7YP/HxNA9IINm9yTsI+WajXaq12y3j4GiqSSfpOK4FxG9QTeXi INS/SAi3oVvjsEGco1daXFsUVwzkCyREQXY3ZdemqHr3hX9hwkggMN6nP4ifawB4 MX5vGgOpLtJ/XetWiU+P8UPizaceIcYnrZal6vADnds6VIvoOpWlVoJtHimiPxnU xDREXsjLRH0/ryqajc+nCY1R5VBrdKYHap/lBFFFIgwWiH3Pcvo= =QZen -----END PGP SIGNATURE----- --rlbT1aSREwbqDqhAdwyAWgvZ9vpojDAhE-- --===============0668542972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0668542972==--