From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hauke Mehrtens Subject: Re: [PATCH v10 03/16] spi: spi-falcon: drop check of boot select Date: Mon, 28 Aug 2017 13:29:33 +0200 Message-ID: <40428f8d-f781-7952-30c6-41f65ec1096b@hauke-m.de> References: <20170819221823.13850-1-hauke@hauke-m.de> <20170819221823.13850-4-hauke@hauke-m.de> <20170828112327.GA15640@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170828112327.GA15640-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ralf Baechle , Mark Brown Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hauke.mehrtens-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, kishon-l0cyMroinI0@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On 08/28/2017 01:23 PM, Ralf Baechle wrote: > On Sun, Aug 20, 2017 at 12:18:10AM +0200, Hauke Mehrtens wrote: > >> Do not check which flash type the SoC was booted from before >> using this driver. Assume that the device tree is correct and use this >> driver when it was added to device tree. This also removes a build >> dependency to the SoC code. >> >> All device trees I am aware of only have one correct flash device entry >> in it. The device tree is anyway bundled with the kernel in all systems >> using device tree I know of. >> >> The boot mode can be specified with some pin straps and will select the >> flash type the rom code will boot from. One SPI, NOR or NAND flash chip >> can be connect to the EBU and used to load the first stage boot loader >> from. > > I think other than this patch we finally have all the acks necessary so > I merged the series except this patch which shouldn't be strictly necessary. > > Ralf > Hi Ralf and Mark, this driver will not build any more without this patch, because ltq_boot_select() gets removed in "[PATCH v10 09/16] MIPS: lantiq: remove ltq_reset_cause() and ltq_boot_select()" Mark could you please have a look at the commit message if it is better now. Hauke -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.mailbox.org ([80.241.60.215]:34268 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbdH1L3l (ORCPT ); Mon, 28 Aug 2017 07:29:41 -0400 Subject: Re: [PATCH v10 03/16] spi: spi-falcon: drop check of boot select To: Ralf Baechle , Mark Brown Cc: linux-mips@linux-mips.org, linux-mtd@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, martin.blumenstingl@googlemail.com, john@phrozen.org, linux-spi@vger.kernel.org, hauke.mehrtens@intel.com, robh@kernel.org, andy.shevchenko@gmail.com, p.zabel@pengutronix.de, kishon@ti.com, mark.rutland@arm.com References: <20170819221823.13850-1-hauke@hauke-m.de> <20170819221823.13850-4-hauke@hauke-m.de> <20170828112327.GA15640@linux-mips.org> From: Hauke Mehrtens Message-ID: <40428f8d-f781-7952-30c6-41f65ec1096b@hauke-m.de> Date: Mon, 28 Aug 2017 13:29:33 +0200 MIME-Version: 1.0 In-Reply-To: <20170828112327.GA15640@linux-mips.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 08/28/2017 01:23 PM, Ralf Baechle wrote: > On Sun, Aug 20, 2017 at 12:18:10AM +0200, Hauke Mehrtens wrote: > >> Do not check which flash type the SoC was booted from before >> using this driver. Assume that the device tree is correct and use this >> driver when it was added to device tree. This also removes a build >> dependency to the SoC code. >> >> All device trees I am aware of only have one correct flash device entry >> in it. The device tree is anyway bundled with the kernel in all systems >> using device tree I know of. >> >> The boot mode can be specified with some pin straps and will select the >> flash type the rom code will boot from. One SPI, NOR or NAND flash chip >> can be connect to the EBU and used to load the first stage boot loader >> from. > > I think other than this patch we finally have all the acks necessary so > I merged the series except this patch which shouldn't be strictly necessary. > > Ralf > Hi Ralf and Mark, this driver will not build any more without this patch, because ltq_boot_select() gets removed in "[PATCH v10 09/16] MIPS: lantiq: remove ltq_reset_cause() and ltq_boot_select()" Mark could you please have a look at the commit message if it is better now. Hauke