From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7012DC432BE for ; Thu, 5 Aug 2021 22:25:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99CF961102 for ; Thu, 5 Aug 2021 22:25:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 99CF961102 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EAEE982E15; Fri, 6 Aug 2021 00:25:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628202324; bh=a4QdnPI/lw7zbixORQwExaDuDTLgTHThK+5NQPYTOEw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=seh04YTnQpkcCiQ/hEcBtLCdfKwodE6vs6WBe9gMbAfCvcU7eUNPIuqoJSa8PTRnW 1AiqBqkSb/6z1/oNQ9faKfQREVgkpp+qCrZTqWiwNjev3ougQz56JLKKyU1wlfHLWr xUFIBy14MUxcVH0Cfr88u4YuVQySR0hhHj+SBF3fr7jrm5ltbq1QN83HVwNB9Y1reh mtEce5u/ZhEWAq8dJGC4LdoSQ9ZDBzhA1H1qLdvpGxQ52JrBc9d71oE+s6hyoVQkCV QBxH0feuIV422sIhINvDjknzUAEu738xk0XtovNfk+ut3BK0YegNy2eC/asbOn2KeY Egx0HDc0zFJeQ== Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D281082C2D; Fri, 6 Aug 2021 00:25:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628202307; bh=a4QdnPI/lw7zbixORQwExaDuDTLgTHThK+5NQPYTOEw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=W4QokxjyKmjdaQnih3DzTc14ArDzZvXvI7l1OQHRB8OBafaFMdEY5rYutKQmPIFt7 kC5yxHI4tjp+g6PURwrmgaTQhf2If9m5h+KErW2igWH9N/ZsLU+4f3PjUtJxyJCF6A 83ZJ+3HyucY/LXBn8T0hg8zNb5wrwWrnzSLNLgFQ24J2gpzDfkOnLFbO6YlLru3pmr aKZePrKN2G4rv9dMYDiatgNDPMhE4rOrblFBXonU3wMU4k07QHsI1Fsxx2CR9ytVb1 +y4njvkVLzVvQniOoT7eWlqeTAZVXJk1571ZbTjl0l0U7SoHO4bSVmoVsuIa1d+9wf OXlsl6bmnt8bw== Subject: Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64" To: Tom Rini Cc: Jan Kiszka , U-Boot Mailing List , Hai Pham , Simon Goldschmidt , Stephen Warren , Lokesh Vutla References: <1971775f-28de-83d0-9459-a4e68c744a18@siemens.com> <20210729152307.GP9379@bill-the-cat> <20210729165802.GA9379@bill-the-cat> <446b4861-6987-092a-43ce-5d3aa322f8f3@denx.de> <20210802130008.GR9379@bill-the-cat> From: Marek Vasut Message-ID: <4046119c-c61c-ed49-92e6-dee5f8c67b3c@denx.de> Date: Thu, 5 Aug 2021 23:53:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210802130008.GR9379@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 8/2/21 3:00 PM, Tom Rini wrote: > On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: >> On 7/29/21 6:58 PM, Tom Rini wrote: >> >> [...] >> >>>>> so when did rcar3 introduce something there that shouldn't be >>>>> reserved? And you had phrased this to me on IRC as about reserving spot >>>>> for ATAGS, and that not being needed of course on arm64. But that's not >>>>> what's going on. Perhaps the answer is that rcar3 needs to introduce a >>>>> board_lmb_reserve to free the normal arch one and provide whatever more >>>>> narrow scope it needs. >>>> >>>> Based on the commit message 2359fa7a878 ("arm: bootm: Disable LMB >>>> reservation for command line and board info on arm64") , this is about ATAGS >>>> and we really don't need to reserve those on arm64. >>> >>> Commit 2359fa7a878 disables the entire arch_lmb_reserve function on >>> aarch64, yes. I assumed when we had talked that it was a small area >>> being set aside and perhaps mis-recalled that ATAGS tended to live at >>> DDR_BASE + 0x800 or so. >> >> That arch_lmb_reserve() is responsible for reserving architecture specific >> memory. On arm32 it is ATAGS, on arm64 it is nothing as far as I can tell >> (and see below regarding the TLB). > > I don't think that LMB ever covered ATAGS. ATAGS, I could have sworn, > were at start of memory + 0x800 or so. This LMB is for the top of > memory where U-Boot is. What is there to protect which Linux does not set up again ?