From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50921C433B4 for ; Thu, 22 Apr 2021 07:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CF9461403 for ; Thu, 22 Apr 2021 07:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234952AbhDVHBc (ORCPT ); Thu, 22 Apr 2021 03:01:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26913 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbhDVHBa (ORCPT ); Thu, 22 Apr 2021 03:01:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619074856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9HfKt+tj+kVv8EGTHRuWgwnmy43mLVyvrcb4OZJTQGQ=; b=DRBuMDVo0jsxd6n8QJ8pPg2oUtOzUdgAY09jONA6xGY8+AhrHUux9svtbXXpW8bWGp6oty 13Xun8rQKjdMNcJnRLXhPbNvWGf2J7R6q9gHi/DxM5LyUGP+O3F/Jaa/3AOwsjCRRHY5ku R+hNKeVoG0fyQDxnly7jFFQncD/8EGM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-f5AWQ4P9PhqxQUEa_8zcZA-1; Thu, 22 Apr 2021 02:59:54 -0400 X-MC-Unique: f5AWQ4P9PhqxQUEa_8zcZA-1 Received: by mail-ej1-f71.google.com with SMTP id x21-20020a1709064bd5b029037c44cb861cso6830793ejv.4 for ; Wed, 21 Apr 2021 23:59:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9HfKt+tj+kVv8EGTHRuWgwnmy43mLVyvrcb4OZJTQGQ=; b=lPuqwi/Gl6vL/5TZUlejcYx7NRwIxLDFzCnA8VNOi7ChcvYA8xLHA3BjD38uOilubb 5VbmXPfbXqk//7T1atpuZ83MVtb7IAB68fZ4opEbV/kb91mBZ1xiuW82djZnu0d3+vnM uKNx38FSx5eVpIwl4G7+XW/OFSyoKsIdk5h5cJp4t3aR4ZKHQ2n4xsfAD0nVGjvZEU3e oYX3XMKS2/lVCVErbwq9F66OfyoepkoT3CRJJlMBcI47wZxHmocgvtOwFAm0EhOfS1ZA HFFOyW3C/DEP8Llp0vpLeqb9NOCjhjtWVS2JjYgwVAZnzOkSNHbUB8zJ+lp5yOfhrbYf RCEA== X-Gm-Message-State: AOAM533vEliQ9dfELacq5s/YccgP/0VM5QDH5RpNZGZFEkUzqbvZm4fu QbOxIymG8l/AJ2m/2FvL8yZq1nxBgK1cfYApAY8QFmBR5BHyES+V0sEuMuQk+SgdaVbW9iwVOEW kBr6fPlt0Giskcyo5DkU+63Yy X-Received: by 2002:a17:907:294f:: with SMTP id et15mr1825495ejc.14.1619074793047; Wed, 21 Apr 2021 23:59:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy18vOTKev4XwdTSbfQNMYcG3hVv8wE66nlBQZcJc05HPittFlEmKn/E7GPIdzP1VdI5S9Hug== X-Received: by 2002:a17:907:294f:: with SMTP id et15mr1825473ejc.14.1619074792912; Wed, 21 Apr 2021 23:59:52 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j9sm1236249eds.71.2021.04.21.23.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 23:59:51 -0700 (PDT) Subject: Re: [PATCH 3/5] tools headers x86: Copy cpuid helpers from the kernel To: Ricardo Koller Cc: kvm@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com References: <20210422005626.564163-1-ricarkol@google.com> <20210422005626.564163-4-ricarkol@google.com> From: Paolo Bonzini Message-ID: <404e903a-5752-6ab2-9b46-aa40f7fb0fba@redhat.com> Date: Thu, 22 Apr 2021 08:59:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210422005626.564163-4-ricarkol@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/04/21 02:56, Ricardo Koller wrote: > Copy arch/x86/include/asm/acpufeature.h and arch/x86/kvm/reverse_cpuid.h > from the kernel so that KVM selftests can use them in the next commits. > Also update the tools copy of arch/x86/include/asm/acpufeatures.h. Typo. > These should be kept in sync, ideally with the help of some script like > check-headers.sh used by tools/perf/. Please provide such a script. Also, without an automated way to keep them in sync I think it's better to copy all of them to tools/testing/selftests/kvm, so that we can be sure that a maintainer (me) runs the script and keeps them up to date. I am fairly sure that the x86 maintainers don't want to have anything to do with all of this business! Paolo