From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9410FC10F14 for ; Thu, 11 Apr 2019 19:27:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69C5C20663 for ; Thu, 11 Apr 2019 19:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbfDKT1S (ORCPT ); Thu, 11 Apr 2019 15:27:18 -0400 Received: from gloria.sntech.de ([185.11.138.130]:32924 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbfDKT1S (ORCPT ); Thu, 11 Apr 2019 15:27:18 -0400 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEfLu-0001JR-Kb; Thu, 11 Apr 2019 21:27:14 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Douglas Anderson Cc: Michael Turquette , Stephen Boyd , Caesar Wang , linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Elaine Zhang , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] clk: rockchip: Make rkpwm a critical clock on rk3288 Date: Thu, 11 Apr 2019 21:27:13 +0200 Message-ID: <4051007.xZozYk3gQ9@diego> In-Reply-To: <20190409204707.150347-3-dianders@chromium.org> References: <20190409204707.150347-1-dianders@chromium.org> <20190409204707.150347-3-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 9. April 2019, 22:47:06 CEST schrieb Douglas Anderson: > Most rk3288-based boards are derived from the EVB and thus use a PWM > regulator for the logic rail. However, most rk3288-based boards don't > specify the PWM regulator in their device tree. We'll deal with that > by making it critical. > > NOTE: it's important to make it critical and not just IGNORE_UNUSED > because all PWMs in the system share the same clock. We don't want > another PWM user to turn the clock on and off and kill the logic rail. > > This change is in preparation for actually having the PWMs in the > rk3288 device tree actually point to the proper PWM clock. Up until > now they've all pointed to the clock for the old IP block and they've > all worked due to the fact that rkpwm was IGNORE_UNUSED and that the > clock rates for both clocks were the same. > > Signed-off-by: Douglas Anderson applied for 5.2 I've added a comment line describing the pwm-reg reason. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDA0C10F13 for ; Thu, 11 Apr 2019 19:27:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6E3620663 for ; Thu, 11 Apr 2019 19:27:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VtVHXnWp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6E3620663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z5E4aMzrtQSawkSA01BQSf/fmRkI5UwYXb30rXHsn08=; b=VtVHXnWpky+XLV OYObUXKk9dRLcO+N8N3HO3JEF8zOj3Gu8J4Adnu8IskVVb9/76axj6fcmGavsOBeZgtx+x9qn9Oc7 nEVrSUSuI3fUpIEpb4kW9iM3x/nIxdh9NB69RH0JdqE/28XdXkgx+M4+4nZXDU4dd5v2v/9iq41Yt oAPDqV94aQlsc84ly7KfdOnPa6aRjmcIRs3php157f/tpOeupfEVEw2P/vUeMgMi8W/eEhqFFoyA/ JatZxlSIxSQTYOjaqH27bQgPxvxqiLGPw+gJm84OSJ87TevYtN1SwblU5eNjp16m/sPpFnAMdHgXA KhMDWMeKjI3Tz427YIMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEfM2-0003SC-Om; Thu, 11 Apr 2019 19:27:22 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEfLz-0003RL-6N; Thu, 11 Apr 2019 19:27:20 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hEfLu-0001JR-Kb; Thu, 11 Apr 2019 21:27:14 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Douglas Anderson Subject: Re: [PATCH 2/3] clk: rockchip: Make rkpwm a critical clock on rk3288 Date: Thu, 11 Apr 2019 21:27:13 +0200 Message-ID: <4051007.xZozYk3gQ9@diego> In-Reply-To: <20190409204707.150347-3-dianders@chromium.org> References: <20190409204707.150347-1-dianders@chromium.org> <20190409204707.150347-3-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_122719_381739_473341B2 X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , Elaine Zhang , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Caesar Wang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 9. April 2019, 22:47:06 CEST schrieb Douglas Anderson: > Most rk3288-based boards are derived from the EVB and thus use a PWM > regulator for the logic rail. However, most rk3288-based boards don't > specify the PWM regulator in their device tree. We'll deal with that > by making it critical. > > NOTE: it's important to make it critical and not just IGNORE_UNUSED > because all PWMs in the system share the same clock. We don't want > another PWM user to turn the clock on and off and kill the logic rail. > > This change is in preparation for actually having the PWMs in the > rk3288 device tree actually point to the proper PWM clock. Up until > now they've all pointed to the clock for the old IP block and they've > all worked due to the fact that rkpwm was IGNORE_UNUSED and that the > clock rates for both clocks were the same. > > Signed-off-by: Douglas Anderson applied for 5.2 I've added a comment line describing the pwm-reg reason. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel