From: Florian Fainelli <f.fainelli@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Cc: Taehee Yoo <ap420073@gmail.com>, Netdev <netdev@vger.kernel.org>,
syzbot <syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com>,
Dmitry Vyukov <dvyukov@google.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [Patch net-next v2 1/2] net: partially revert dynamic lockdep key changes
Date: Sun, 17 May 2020 12:35:52 -0700 [thread overview]
Message-ID: <405579c2-24da-d7e6-863f-f8ed58df878f@gmail.com> (raw)
In-Reply-To: <CAM_iQpV-LGNp=jBvFKhz50FtcYUpU5eCY8L853oWRFVoSqUPjA@mail.gmail.com>
On 5/17/2020 11:42 AM, Cong Wang wrote:
> On Sat, May 16, 2020 at 9:53 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>> Thanks a lot for presenting the options. In general, xmit in DSA is
>> relatively simple and most of the time stateless. My stacked DSA setup
>> appears to work just fine with NETIF_F_LLTX, including the updating of
>> percpu counters. I'm not really sure if there's something in
>> particular to test?
>> Anyway, will you send a patch with NETIF_F_LLTX or should I do it? I
>> can do further testing if necessary.
>
> If DSA is software based, there is a large chance it can be just
> using NETIF_F_LLTX, like you said.
>
> Please do send a patch for this NETIF_F_LLTX. Note my patch
> simply reverts to the old code, this issue probably exists before it.
It transmits frames by calling dev_queue_xmit() after having assigned
skb->dev to be pointing to the master network device, very much like
what VLAN devices do for instance, so I believe setting NETIF_F_LLTX is
fine here.
--
Florian
next prev parent reply other threads:[~2020-05-17 19:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 5:22 [Patch net-next v2 0/2] net: reduce dynamic lockdep keys Cong Wang
2020-05-03 5:22 ` [Patch net-next v2 1/2] net: partially revert dynamic lockdep key changes Cong Wang
2020-05-04 17:11 ` Taehee Yoo
2020-05-13 15:56 ` Vladimir Oltean
2020-05-16 15:22 ` Taehee Yoo
2020-05-16 16:53 ` Vladimir Oltean
2020-05-17 12:53 ` Taehee Yoo
2020-05-17 18:42 ` Cong Wang
2020-05-17 19:35 ` Florian Fainelli [this message]
2020-05-03 5:22 ` [Patch net-next v2 2/2] bonding: remove useless stats_lock_key Cong Wang
2020-05-04 19:06 ` [Patch net-next v2 0/2] net: reduce dynamic lockdep keys David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405579c2-24da-d7e6-863f-f8ed58df878f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=dvyukov@google.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com \
--cc=vivien.didelot@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.