From: Fabio M. De Francesco <fmdefrancesco@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v3] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
Date: Sat, 16 Apr 2022 23:43:03 +0200 [thread overview]
Message-ID: <4058066.1IzOArtZ34@leap> (raw)
In-Reply-To: <1897617.PYKUYFuaPT@leap>
On sabato 16 aprile 2022 17:52:20 CEST Fabio M. De Francesco wrote:
> On sabato 16 aprile 2022 16:09:58 CEST Julia Lawall wrote:
> >
> > If all calls should be changed then you can also say that.
>
> If all calls should be changed with no regards to the surrounding
contexts
> and special situations, we can just make an automated s/kmap()/
> kmap_local_page()/ or something else similar :)
Hi Julia,
Of course I was just kidding when talking of massively automated
substitutions. They are not feasible and we cannot blindly replace all
kmap() calls with kmap_local_page().
Although these code changes look good, your objections are appropriate and
legitimate.
Not all kmap() calls can be changed to kmap_local_page() and, if someone
wants to make such replacements, they should also "prove" somehow that they
are doing the right changes in that specific context.
For example, the following is one of those cases where such a replacement
is not allowed and a different solution has yet to be found:
https://lore.kernel.org/lkml/2a7030f5-d55f-94c7-90ba-5a57235159f6 at amd.com/
Furthermore, if people cannot "prove" that this change is feasible, their
patches will probably be ignored / rejected just because many maintainers
still don't know if those changes are correct and safe.
Whoever wants to do these changes should understand the specific context in
which they are working.
For example, there have also been cases where alloc_page() + kmap() was
simply replaced by kmalloc(). Sure!
If you are interested to see how and why, please take a look at the commit
633b0616cfe0 ("x86/sgx: Remove unnecessary kmap() from
sgx_ioc_enclave_init()") from Ira Weiny.
Regards,
Fabio
> >
> > I thought that a previous commit on the outreachy list made some
> arguments
> > about how the affacted value was just allocated and thus could not yet
be
> > shared.
> >
> > julia
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20220416/daee33e4/attachment-0001.html>
next prev parent reply other threads:[~2022-04-16 21:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 11:14 [PATCH v3] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page() Alaa Mohamed
2022-04-16 11:14 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 11:31 ` Julia Lawall
2022-04-16 11:31 ` [Intel-wired-lan] " Julia Lawall
2022-04-16 13:14 ` Alaa Mohamed
2022-04-18 22:19 ` Ira Weiny
2022-04-18 22:19 ` [Intel-wired-lan] " Ira Weiny
2022-04-19 13:37 ` Alaa Mohamed
2022-04-19 13:37 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 13:18 ` Alaa Mohamed
2022-04-16 13:18 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 14:09 ` Julia Lawall
2022-04-16 14:09 ` [Intel-wired-lan] " Julia Lawall
2022-04-16 15:52 ` Fabio M. De Francesco
2022-04-16 15:52 ` [Intel-wired-lan] " Fabio M. De Francesco
2022-04-16 16:28 ` Fabio M. De Francesco
2022-04-16 21:43 ` Fabio M. De Francesco [this message]
2022-04-16 22:21 ` Fabio M. De Francesco
2022-04-17 7:07 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4058066.1IzOArtZ34@leap \
--to=fmdefrancesco@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.