Re: [PATCH 2/7] ARM: dts: Update FIMD DT node for Exynos5 SoCs

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Vikas,

Please see my comment inline.

On Monday 29 of July 2013 19:19:26 Vikas Sajjan wrote:
> Moves the properties of FIMD DT node which are common across Exynos5 based
> SoCs like Exynos5250 and Exxynos5420 to exynos5.dtsi
> 
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
>  arch/arm/boot/dts/exynos5.dtsi    |   10 ++++++++++
>  arch/arm/boot/dts/exynos5250.dtsi |    6 +-----
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index f65e124..80a4630 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -108,4 +108,14 @@
>  		interrupts = <0 42 0>;
>  		status = "disabled";
>  	};
> +
> +	fimd {

I don't know why this node was named incorrectly in original file (probably the 
patch adding it did not have enough review), but if you are modifying it 
anyway, could you fix it to be conformant to DT conventions?

Whenever there is a reg property inside a node, the node should be named 
whatever@addr, where addr is comma separated list of addresses specified in reg 
property, in hex, without "0x" prefix.

So in this case this should be at least

	fimd@14400000

but ideally

	display-controller@14400000

as nodes should have generic names (see ePAPR, paragraph 2.2.2).

Best regards,
Tomasz