From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [ADV7393] DRM Encoder Slave or DRM Bridge Date: Thu, 15 Sep 2016 12:53:57 +0300 Message-ID: <406769ce-bbd0-c517-3006-c5f1ab6ff511@ti.com> References: <52026ed7-fbfc-48a0-b2ea-07577d49231d@ti.com> <3958e459-2127-4450-9749-913365949996@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0627869209==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [198.47.19.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED55A6E00E for ; Thu, 15 Sep 2016 09:54:03 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vikas Patil Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org --===============0627869209== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="36bXb6vEx1Cr2X1bgUU5i2KNfsNpHgdE5" --36bXb6vEx1Cr2X1bgUU5i2KNfsNpHgdE5 Content-Type: multipart/mixed; boundary="xGAPrwuX6JdU7vBWut5H2f6FrPK5OaW44"; protected-headers="v1" From: Tomi Valkeinen To: Vikas Patil Cc: "dri-devel@lists.freedesktop.org" , Rob Clark , architt@codeaurora.org Message-ID: <406769ce-bbd0-c517-3006-c5f1ab6ff511@ti.com> Subject: Re: [ADV7393] DRM Encoder Slave or DRM Bridge References: <52026ed7-fbfc-48a0-b2ea-07577d49231d@ti.com> <3958e459-2127-4450-9749-913365949996@ti.com> In-Reply-To: --xGAPrwuX6JdU7vBWut5H2f6FrPK5OaW44 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15/09/16 12:44, Vikas Patil wrote: > On Wed, Sep 14, 2016 at 3:04 PM, Tomi Valkeinen = wrote: >> >> >> On 13/09/16 16:13, Vikas Patil wrote: >>> Thanks Tomi for quick comment. >>> >>> I am thinking to base adv7393 driver on >>> "drivers\gpu\drm\omapdrm\displays\encoder-tc358768.c" as I don't thin= k >>> any similar to adv7393 chip driver available. Could you please commen= t >>> if this will help to get adv chip running? >> >> I presume you're not using mainline kernel, as that driver is not ther= e. >> I'm not familiar with adv7393, but yes, I think you can use that as an= >> example. >> >=20 > Thanks a lot for your comments. I am using latest (i.e. 3.00.00.03 ) > Processor SDK Linux Automotive which is based on linux 4.4.14. >=20 > As my display panel is connected as follows. I am little confused over > the values I need to set for following properties in probe function. >=20 > DPI1/VOUT1 -----16bit DRGB---> ADV7393 (Digital to Analog video > encoder) ------> CVBS Out ------> Display Panel >=20 >=20 > dssdev->ops.dpi =3D &adv7393_dpi_ops; (atv?) > dssdev->type =3D OMAP_DISPLAY_TYPE_DPI; > dssdev->output_type =3D OMAP_DISPLAY_TYPE_DPI; (Do I need to use > OMAP_DISPLAY_TYPE_VENC, but DRA74x do not have VENC Encoder I think) > dssdev->phy.dpi.data_lines =3D ddata->dpi_ndl; > dssdev->port_num =3D 1; >=20 >=20 > As adv7393 takes 16-bit DRGB as input and gives composite as output, > does above configuration looks correct? or Do I need to change to > something else (e.g. dpi,sdi,dvi, hdmi, atv, dsi)? The API is quite messy (full of legacy)... But the "ops" there are for the "downstream" direction, i.e. towards the connector. So here you should have atv ops. You should then have connector-analog-tv as a device after adv7393, and that connector driver will be calling those atv ops. adv7393 itself will be calling dpi ops, offered by the DSS. You should set dssdev->type to DPI (that's the input). dssdev->output_type to OMAP_DISPLAY_TYPE_VENC (output, although "venc" is not quite correct here, but closest match we have). DRA74x doesn't have VENC, but this is what the adv7393 outputs. Tomi --xGAPrwuX6JdU7vBWut5H2f6FrPK5OaW44-- --36bXb6vEx1Cr2X1bgUU5i2KNfsNpHgdE5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX2m+1AAoJEPo9qoy8lh71eIEQAJ8LjKHDLcGqXiSmj2xYdWpT 7HUbz59yQqlE0PlW2s2W2VwEWpXXRanz6Fj79XaS1tzOiqjCZSxwCn7HzuHSuCb5 6y6p6AxXq4lfaobYlaPxUHSs5Iw+4pJGFNfhy9EM1sb+XO6LawoQ7vPsmxaQdtO6 t9T6RHo+eUCdh2HnaymQFqYiNFW5ryd7ird3MXYkVzIbMDlcUHYKWJRQNibrGn83 P2D/+QA3fOUHTngzT0J0nnQ4WPq1RzyjyqS2LTDryGzCFOC/76XlCVrJlXJeOdxR WrdHIOYZ8/Ux914tmt6Wbu+mlqQc1qdWLLZODxvN1uDOg8H45iudynUiEPXYm43T 9stJJ3gf82qpm9lq3dg6JxMyhl+v2qpYxJ2Svg048WYfAHN+hCbAzTTYeTo3PRca nBGcWgkzN/bs4JkRgQFeoVP2MjMQfVngG6fE6vYzgs/x5Rjjh1LronidfZfVkY87 n1o+47XewuRzps4C7emj8RtIoP2Xczo/noQcYyuiLn9Be85nmqFrEyVCUUnzPWTE I9e6OoCJTfaZQia2fkmwSI+d7fvz6CFpbtBbB498rrZGCA/suw5HcRTwOuhc/Tfb RDqJQIcQWKDNd5xZNacO/gYqpSAS75uJ+AtcnMSUbRRfG8kjh/sSCSTfYzd71mx9 MQ2bkCPcxF5B9r7aoYiz =//K/ -----END PGP SIGNATURE----- --36bXb6vEx1Cr2X1bgUU5i2KNfsNpHgdE5-- --===============0627869209== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0627869209==--