All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xu, Dongxiao" <dongxiao.xu@intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] qt4: move functions from python to shell style
Date: Tue, 8 May 2012 05:34:53 +0000	[thread overview]
Message-ID: <40776A41FC278F40B59438AD47D147A90FD70356@SHSMSX102.ccr.corp.intel.com> (raw)
In-Reply-To: <2956480.HfgXetH5nE@helios>

> -----Original Message-----
> From: Paul Eggleton [mailto:paul.eggleton@linux.intel.com]
> Sent: Tuesday, April 24, 2012 6:51 PM
> To: Xu, Dongxiao
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/1] qt4: move functions from python to shell
> style
> 
> Hi Dongxiao,
> 
> On Monday 23 April 2012 16:53:02 Dongxiao Xu wrote:
> > In qt4's do_configure operation, it will refer to some variables that
> > are derived from 'd', however these variable values may be not correct
> > in multilib case since the extraction of these variables happens
> > before the multilib handler.
> >
> > The fix is to move these python style functions back to shell style.
> 
> This patch removes qt4_arch.inc without explaining why. Can the fix be made
> without removing it?

Hi Paul,

In my new pull request, I keep the qt4_arch.inc file and put common functions there.
Thanks for your comments.

Thanks,
Dongxiao

> 
> Cheers,
> Paul
> 
> --
> 
> Paul Eggleton
> Intel Open Source Technology Centre



  reply	other threads:[~2012-05-08  5:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  8:53 [PATCH 0/1 v2][PULL] Fix bug 2355 Dongxiao Xu
2012-04-23  8:53 ` [PATCH 1/1] qt4: move functions from python to shell style Dongxiao Xu
2012-04-24 10:50   ` Paul Eggleton
2012-05-08  5:34     ` Xu, Dongxiao [this message]
2012-04-23  9:45 ` [PATCH 0/1 v2][PULL] Fix bug 2355 Xu, Dongxiao
2012-04-23 10:34   ` Xu, Dongxiao
  -- strict thread matches above, loose matches on Subject: below --
2012-05-08  5:28 [PATCH 0/1 v3][PULL] " Dongxiao Xu
2012-05-08  5:28 ` [PATCH 1/1] qt4: move functions from python to shell style Dongxiao Xu
2012-05-08 13:05   ` Richard Purdie
2012-04-21 15:05 [PATCH 0/1][PULL] Fix bug 2355 Dongxiao Xu
2012-04-21 15:05 ` [PATCH 1/1] qt4: move functions from python to shell style Dongxiao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40776A41FC278F40B59438AD47D147A90FD70356@SHSMSX102.ccr.corp.intel.com \
    --to=dongxiao.xu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.