From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 1/2] gro: code cleanup
Date: Wed, 10 Jan 2018 01:09:07 +0100
Message-ID: <4091994.Mte9QLjkTW@xps>
References: <1513927544-97241-1-git-send-email-jiayu.hu@intel.com>
 <1515132769-52572-1-git-send-email-jiayu.hu@intel.com>
 <1515132769-52572-2-git-send-email-jiayu.hu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, junjie.j.chen@intel.com,
 jianfeng.tan@intel.com, stephen@networkplumber.org, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, lei.a.yao@intel.com
To: Jiayu Hu <jiayu.hu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3AE752BC8
 for <dev@dpdk.org>; Wed, 10 Jan 2018 01:09:33 +0100 (CET)
In-Reply-To: <1515132769-52572-2-git-send-email-jiayu.hu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

05/01/2018 07:12, Jiayu Hu:
> - Remove needless check and variants
> - For better understanding, update the programmer guide and rename
>   internal functions and variants
> - For supporting tunneled gro, move common internal functions from
>   gro_tcp4.c to gro_tcp4.h
> - Comply RFC 6864 to process the IPv4 ID field

I think you could split this patch in several ones.
Please remind that the git history can be used later to understand
why the changes were done.

Thanks