From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2] eal/linuxapp: improve segment list preallocation Date: Mon, 22 Oct 2018 12:32:20 +0200 Message-ID: <4093296.dHmcqor6Pu@xps> References: <5e545d6548f62a8fddfca18f8cc0901654e1e403.1538728009.git.anatoly.burakov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, dev@dpdk.org, Ravi1.Kumar@amd.com To: Anatoly Burakov Return-path: In-Reply-To: <5e545d6548f62a8fddfca18f8cc0901654e1e403.1538728009.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/10/2018 10:29, Anatoly Burakov: > Current code to preallocate segment lists is trying to do > everything in one go, and thus ends up being convoluted, > hard to understand, and, most importantly, does not scale beyond > initial assumptions about number of NUMA nodes and number of > page sizes, and therefore has issues on some configurations. > > Instead of fixing these issues in the existing code, simply > rewrite it to be slightly less clever but much more logical, and > provide ample comments to explain exactly what is going on. > > We cannot use the same approach for 32-bit code because the > limitations of the target dictate current socket-centric > approach rather than type-centric approach we use on 64-bit > target, so 32-bit code is left unmodified. FreeBSD doesn't > support NUMA so there's no complexity involved there, and thus > its code is much more readable and not worth changing. > > Fixes: 1d406458db47 ("mem: make segment preallocation OS-specific") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks