From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40B8xK1ywfzF2MD for ; Thu, 29 Mar 2018 01:13:25 +1100 (AEDT) In-Reply-To: <1521067243-19520-2-git-send-email-mauricfo@linux.vnet.ibm.com> To: Mauricio Faria de Oliveira , linuxppc-dev@lists.ozlabs.org, msuchanek@suse.de From: Michael Ellerman Subject: Re: [v3, 1/5] rfi-flush: Move the logic to avoid a redo into the debugfs code Message-Id: <40B8xJ44w2z9s19@ozlabs.org> Date: Thu, 29 Mar 2018 01:13:24 +1100 (AEDT) List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2018-03-14 at 22:40:38 UTC, Mauricio Faria de Oliveira wrote: > From: Michael Ellerman > > rfi_flush_enable() includes a check to see if we're already > enabled (or disabled), and in that case does nothing. > > But that means calling setup_rfi_flush() a 2nd time doesn't actually > work, which is a bit confusing. > > Move that check into the debugfs code, where it really belongs. > > Signed-off-by: Michael Ellerman > Signed-off-by: Mauricio Faria de Oliveira Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1e2a9fc7496955faacbbed49461d61 cheers