From: "René Rebe" <rene@exactcode.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Kernel unaligned access at ... btrfs_real_readdir+0x51c/0x718 [btrfs]
Date: Tue, 17 Apr 2018 12:18:45 +0200 [thread overview]
Message-ID: <40C44E95-3281-4E2C-83F6-CF6139FC4D19@exactcode.com> (raw)
In-Reply-To: <20180416191533.GZ21272@twin.jikos.cz>
Hi,
On 16 Apr 2018, at 21:15, David Sterba <dsterba@suse.cz> wrote:
> On Mon, Apr 16, 2018 at 09:55:45PM +0200, René Rebe wrote:
>> Hi,
>>
>> On 04/16/2018 06:48 PM, David Sterba wrote:
>>> The warnings are valid, there's unaligned access introduced by patch
>>>
>>> 23b5ec74943f44378b68c0edd8e210a86318ea5e
>>> btrfs: fix readdir deadlock with pagefault
>>>
>>> The directory entries (struct dir_entry) are copied to a temporary
>>> buffer as they fit, ie. no alignment, and the members accessed in
>>> several places.
>>>
>>> The following patch adds the proper unaligned access, only compile-tested.
>>> Please test and let me know, thanks!
>> Would have loved to immediately give it a try, however, sorry,
>> I forgot to mention I'm on the latest stable release -4.16.2-
>> on a first glance this does not look like it does just apply.
>>
>> I would re-base myself if I would not also have a glibc initialization
>> bug to hunt and debug, too :-/
>>
>> If you happen to also rebase it for current -stable, ... ;-)
>
> Sure, attached a 4.16.2 version.
> <0001-test-readdir-unaligned-access.patch>
Cool, thanks, built and so far it works, the warnings are gone.
https://www.youtube.com/watch?v=XYsKct4T2xk
Greetings form Berlin,
René
--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de
next prev parent reply other threads:[~2018-04-17 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 14:52 Kernel unaligned access at ... btrfs_real_readdir+0x51c/0x718 [btrfs] René Rebe
2018-04-16 16:48 ` David Sterba
2018-04-16 19:55 ` René Rebe
2018-04-16 19:15 ` David Sterba
2018-04-17 10:18 ` René Rebe [this message]
2018-04-18 13:03 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40C44E95-3281-4E2C-83F6-CF6139FC4D19@exactcode.com \
--to=rene@exactcode.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.