Re: [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

[Ayaka <ayaka@soulik.info>]

從我的 iPad 傳送

> Romain Perier <romain.perier@collabora.com> 於 2017年5月17日 下午2:48 寫道：
> 
> Hello,
> 
> 
>> Le 16/05/2017 à 20:44, Trevor Woerner a écrit :
>> Randy,
>> 
>> Neither of the issues that were identified in your v2 of this patch were
>> addressed in this v3. Namely:
>> 
>> 1) please use your real name (first, last) in your signed-off-by line
>> 2) please don't create a package from this recipe whose name doesn't include
>>   the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
>>   "rockchip-mpp"), suggestions were provided
It is a isolated library. I would suggest a new library named rockchip-mpp-vpu.
>> 
>> Aside from the email headers and the version of git used, this patch is
>> identical to the v2 you submitted.
>> 
>> Best regards,
>>    Trevor
> +1
> 
> And please, include a changelog in your new version, at least in the
> cover letter, something like:
> 
> Changes in v3:
> - Item1 fixed
> - Item2 fixed
> 
> Changes in v2:
> - Item1 fixed
> - Item2 fixed
> 
> 
> Thanks,
> Romain