From: "Dan Lüdtke" <mail@danrl.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: openwrt route_allowed_ips is inprecise
Date: Tue, 20 Dec 2016 09:52:04 +0100 [thread overview]
Message-ID: <40FCA8CB-1FAA-42AF-B229-8692568F8226@danrl.com> (raw)
In-Reply-To: <CAHmME9popkFYu-am43TMCc6NcPtUA5dYRWPuTDJS-B69L73_cQ@mail.gmail.com>
Regarding the initial preciseness issue, have you tested that on LEDE? I =
can't manage to get duplicate routes. However, outdated testing =
environment. Will rebuild and test again. I can't quite understand what =
the initial issue was. Wouldn't you get a "rtnetlink: file exists" when =
you try to add an route that already exists?
This also can only occur if someone uses static routes AND decides to =
use route_allowed_ips, right?
>> This is pretty straightforward with netlink
>=20
> No, it's much less straight-forward with raw netlink. Raw netlink
> involves hundreds of lines of code to do anything at all. A real mess.
> Fortunately there are wrapper libraries you can use from various
> languages to make it easier.
True. I was referring to the auto-route option I read on LKML a while =
ago. Of course, when done from userspace, netlink is not the ideal way.=20=
>=20
>> Regarding LEDE, netifd should track the routes being added and the =
extra routes do not really do harm.
>=20
> Alright then...
>=20
> Speaking of netifd, did you ever fix that netifd issue with the IP =
dependency?
I am on it. First version did add dependency for both protocols if the =
endpoint name had A and AAAA records. However, I find it cleaner to =
check which endpoint wg chose to use and only add that IP address as an =
depedency. Patch/PR comes when I am satisfied with stability.=
next prev parent reply other threads:[~2016-12-20 8:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 20:14 openwrt route_allowed_ips is inprecise Jason A. Donenfeld
2016-12-19 8:00 ` Jörg Thalheim
2016-12-19 12:32 ` Jason A. Donenfeld
2016-12-19 13:06 ` Baptiste Jonglez
2016-12-19 13:09 ` Jason A. Donenfeld
2016-12-19 13:19 ` Baptiste Jonglez
2016-12-19 13:21 ` Jason A. Donenfeld
2016-12-20 1:13 ` Baptiste Jonglez
2016-12-20 3:14 ` Jason A. Donenfeld
2016-12-20 3:38 ` Dan Luedtke
2016-12-20 4:33 ` Jason A. Donenfeld
2016-12-20 8:52 ` Dan Lüdtke [this message]
2016-12-20 10:15 ` Dan Lüdtke
2016-12-20 13:33 ` Jason A. Donenfeld
2016-12-20 14:51 ` Dan Lüdtke
2016-12-20 18:27 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40FCA8CB-1FAA-42AF-B229-8692568F8226@danrl.com \
--to=mail@danrl.com \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.