From: Hans Verkuil <hverkuil@xs4all.nl>
To: Deepak R Varma <drv@mailo.com>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/9] staging: media: atomisp: reformat code comment blocks
Date: Fri, 30 Apr 2021 14:29:34 +0200 [thread overview]
Message-ID: <40bd5f58-9561-89bb-ada5-1cdf56d62ef8@xs4all.nl> (raw)
In-Reply-To: <YIv3lEAC8d8LsCb+@dU2104>
On 30/04/2021 14:27, Deepak R Varma wrote:
> On Fri, Apr 30, 2021 at 04:45:56PM +0530, Deepak R Varma wrote:
>> On Fri, Apr 30, 2021 at 12:04:33PM +0200, Hans Verkuil wrote:
>>> On 29/04/2021 13:49, Deepak R Varma wrote:
>>>> On Thu, Apr 29, 2021 at 09:06:12AM +0200, Fabio Aiuto wrote:
>>>>> Hi Deepak,
>>>>>> {MISENSOR_16BIT, 0xC868, 0x0280}, /* cam_output_width = 952 */
>>>>>> {MISENSOR_16BIT, 0xC86A, 0x01E0}, /* cam_output_height = 538 */
>>>>>> /* LOAD = Step3-Recommended
>>>>>> - * Patch,Errata and Sensor optimization Setting */
>>>>>> + * Patch,Errata and Sensor optimization Setting
>>>>>> + */
>>>>>
>>>>> /*
>>>>> * LOAD = Step3-Recommended
>>>>>
>>>>> :(
>>>>
>>>> oops... sorry for the oversight. Not sure how I missed it.
>>>> I will wait for any other feedback on other patches and send
>>>> in a corrected version shortly.
>>>
>>> I've fixed this up myself.
>>>
>>> I'm taking this series and make a PR for this, wrapping up these
>>> atomisp cleanups.
>>>
>>> If you plan any more cleanups, then please do this on top of this
>>> branch: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v5.14-out1
>>>
>>> That contains all pending cleanups for staging/media.
>>
>> Thank you Hans and everyone. Appreciate your time, comments and patience. I
>> understand this entire patch series is acceptable for your consideration and
>> that I can now move on to other changes.
>>
>> I will be sending additional clean up patches and I will base those on top of the
>> mentioned branch.
>
> Hello Hans,
> I have cloned media_tree repository and checked out branch for-v5.14-out1
>
> Is it okay for me to start my next patch in this branch? I do not need for
> you the last patch set to be applied to the git tree, correct?
>
Correct.
Hans
> Thank you,
> deepak.
>
>>
>> Have a good one.
>> deepak.
>>
>>>
>>> Regards,
>>>
>>> Hans
>>>
>
>
next prev parent reply other threads:[~2021-04-30 12:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1619630709.git.drv@mailo.com>
2021-04-28 18:06 ` [PATCH v4 3/9] staging: media: atomisp: remove unnecessary braces Deepak R Varma
2021-04-28 18:07 ` [PATCH v4 4/9] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-05-17 13:44 ` Mauro Carvalho Chehab
2021-05-19 16:08 ` Deepak R Varma
2021-04-28 18:08 ` [PATCH v4 5/9] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-29 7:06 ` Fabio Aiuto
2021-04-29 11:49 ` Deepak R Varma
2021-04-30 10:04 ` Hans Verkuil
2021-04-30 11:15 ` Deepak R Varma
2021-04-30 12:27 ` Deepak R Varma
2021-04-30 12:29 ` Hans Verkuil [this message]
2021-04-28 18:09 ` [PATCH v4 6/9] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-28 18:09 ` [PATCH v4 7/9] staging: media: atomisp: replace raw pr_*() by dev_dbg() Deepak R Varma
2021-04-28 18:10 ` [PATCH v4 8/9] staging: media: atomisp: remove unnecessary pr_info calls Deepak R Varma
2021-04-28 18:10 ` [PATCH v4 9/9] staging: media: atomisp: remove unwanted dev_*() calls Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40bd5f58-9561-89bb-ada5-1cdf56d62ef8@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=drv@mailo.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.