All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Salam Noureddine <noureddine@arista.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Question on comment in dev_queue_xmit_nit
Date: Tue, 8 Feb 2022 15:51:17 -0800	[thread overview]
Message-ID: <40bf4696-2c58-f5ba-e81f-46a2a5e7887a@candelatech.com> (raw)

Hello Salam,

After an 8 day torture test on a hacked 5.15.7+ kernel doing wifi testing, our system crashed
in the dev_queue_xmit_nit method, evidently 'skb' is NULL.

gdb claims it is the 'skb2 = skb_clone ...' line below.  Now, this crash could
be fault of my local patches or other random things, but the comment caught
my attention.  It is cloning once per loop as far as I can see, so why the comment
about 'done only once' ?

		/* need to clone skb, done only once */
		skb2 = skb_clone(skb, GFP_ATOMIC);
		if (!skb2)
			goto out_unlock;

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


             reply	other threads:[~2022-02-08 23:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 23:51 Ben Greear [this message]
2022-02-09  0:13 ` Question on comment in dev_queue_xmit_nit Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40bf4696-2c58-f5ba-e81f-46a2a5e7887a@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    --cc=noureddine@arista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.