From: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
To: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Joseph Chuang <joseph.chuang@cypress.com>
Subject: Re: [PATCH V2 6/6] brcmfmac: initialize the requested dwell time
Date: Mon, 22 Jun 2020 23:04:07 +0800 [thread overview]
Message-ID: <40d2e018-d358-d126-b103-6eea553c5d9f@cypress.com> (raw)
In-Reply-To: <20200610152106.175257-7-chi-hsien.lin@cypress.com>
On 06/10/2020 11:21, Chi-Hsien Lin wrote:
> From: Joseph Chuang <joseph.chuang@cypress.com>
>
> Commit 9c29da3f4e7e
> ("brcmfmac: Fix P2P Group Formation failure via Go-neg method") did not
> initialize requested_dwell properly, resulting in an always-false dwell
> time overflow check. Fix it by setting the correct requested_dwell
> value.
>
> Fixes: 4905432b28b7 ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")
> Signed-off-by: Joseph Chuang <joseph.chuang@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Kalle,
This issue is reported by kernel test robot. Please kindly add below tag
during commit.
Reported-by: kernel test robot <lkp@intel.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 5 ++---
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index a757abd7a599..bddd23240609 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5129,7 +5129,7 @@ brcmf_cfg80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
> &freq);
> chan_nr = ieee80211_frequency_to_channel(freq);
> af_params->channel = cpu_to_le32(chan_nr);
> -
> + af_params->dwell_time = cpu_to_le32(params->wait);
> memcpy(action_frame->data, &buf[DOT11_MGMT_HDR_LEN],
> le16_to_cpu(action_frame->len));
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> index d2795dc17c46..debd887e159e 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
> @@ -1700,7 +1700,7 @@ static s32 brcmf_p2p_pub_af_tx(struct brcmf_cfg80211_info *cfg,
> return err;
> }
>
> -static bool brcmf_p2p_check_dwell_overflow(s32 requested_dwell,
> +static bool brcmf_p2p_check_dwell_overflow(u32 requested_dwell,
> unsigned long dwell_jiffies)
> {
> if ((requested_dwell & CUSTOM_RETRY_MASK) &&
> @@ -1738,8 +1738,7 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg,
> unsigned long dwell_jiffies = 0;
> bool dwell_overflow = false;
>
> - s32 requested_dwell = af_params->dwell_time;
> -
> + u32 requested_dwell = le32_to_cpu(af_params->dwell_time);
> action_frame = &af_params->action_frame;
> action_frame_len = le16_to_cpu(action_frame->len);
>
>
next prev parent reply other threads:[~2020-06-22 15:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 15:21 [PATCH V2 0/6] brcmfmac: flow control and p2p fix series Chi-Hsien Lin
2020-06-10 15:21 ` [PATCH V2 1/6] brcmfmac: allow credit borrowing for all access categories Chi-Hsien Lin
2020-07-14 9:47 ` Kalle Valo
2020-06-10 15:21 ` [PATCH V2 2/6] brcmfmac: increase message buffer size for control packets Chi-Hsien Lin
2020-06-10 15:21 ` [PATCH V2 3/6] brcmfmac: reserve 2 credits for host tx control path Chi-Hsien Lin
2020-08-03 16:27 ` Dmitry Osipenko
2020-08-04 11:08 ` Kalle Valo
2020-08-04 15:53 ` Dmitry Osipenko
2020-08-04 17:22 ` Kalle Valo
2020-08-05 8:24 ` Chi-Hsien Lin
2020-08-05 14:01 ` Dmitry Osipenko
2020-08-11 8:35 ` Wright Feng
2020-08-11 14:54 ` Dmitry Osipenko
2020-08-12 4:03 ` Wright Feng
2020-08-12 14:22 ` Dmitry Osipenko
2020-08-13 3:03 ` Wright Feng
2020-08-13 21:30 ` Dmitry Osipenko
2020-06-10 15:21 ` [PATCH V2 4/6] brcmfmac: update tx status flags to sync with firmware Chi-Hsien Lin
2020-06-10 15:21 ` [PATCH V2 5/6] brcmfmac: fix throughput zero stalls on PM 1 mode due to credit map Chi-Hsien Lin
2020-06-10 15:21 ` [PATCH V2 6/6] brcmfmac: initialize the requested dwell time Chi-Hsien Lin
2020-06-22 15:04 ` Chi-Hsien Lin [this message]
2020-07-14 9:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40d2e018-d358-d126-b103-6eea553c5d9f@cypress.com \
--to=chi-hsien.lin@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=joseph.chuang@cypress.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.