All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] security_flags.inc: libidn fails to build w/ -Wformat-security
Date: Mon, 27 Jun 2016 12:42:28 +0300	[thread overview]
Message-ID: <40d4fd66-6794-03bd-ee48-20f376483f6a@linux.intel.com> (raw)
In-Reply-To: <CAJTo0La+NmXWrJW4hp9e2JtqB2DTeREfOYhhLi4MJWqkZygc3g@mail.gmail.com>

On 06/27/2016 12:10 PM, Burton, Ross wrote:
>     ../../libidn-1.32/src/idn.c: In function 'main':
>     ../../libidn-1.32/src/idn.c:172:7: error: format not a string
>     literal and no format arguments [-Werror=format-security]
>            error (0, 0, _("only one of -s, -e, -d, -a, -u or -n can be
>     specified"));
>
>
> As libidn will be dealing with data from the network it seems like the
> sort of package that should be built with format-security enabled.
> Wouldn't it be better to fix up the calls to error() instead?

Also, in general the point of adding this check was that we try to fix 
the problems in the code. Adding packages to the list of exceptions is 
missing the point :)

Please write a patch - I'd say we should accept new exceptions only if 
fixing the code is shown to be too difficult.


Alex



  reply	other threads:[~2016-06-27  9:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 10:59 [PATCH] security_flags.inc: libidn fails to build w/ -Wformat-security André Draszik
2016-06-27  9:10 ` Burton, Ross
2016-06-27  9:42   ` Alexander Kanavin [this message]
2016-06-28 11:55     ` André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40d4fd66-6794-03bd-ee48-20f376483f6a@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.