From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BE6C433E2 for ; Fri, 10 Jul 2020 21:13:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77A182075D for ; Fri, 10 Jul 2020 21:13:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Onb4YcaM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgGJVNs (ORCPT ); Fri, 10 Jul 2020 17:13:48 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:45755 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726251AbgGJVNs (ORCPT ); Fri, 10 Jul 2020 17:13:48 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594415627; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=Y1rBBSjHn58KkYWcfa8FN19qXT4mpd6FmEsIOBn/G4I=; b=Onb4YcaMgtkqlxl+6rprGtZkKp+YRup3s8fzF7WYXeP0o0mh6iwJFGJBOZsg8FEv5UdSC6nN +/lhN2hloR97988GVBpzGqtgr2MJmdwXGvqPcNm3Y3IJGw1l/KmSmAZSP1GYiDn2+PKVEpxc I/olgANzN5WsyrjfefiNM9Ok0LI= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n17.prod.us-east-1.postgun.com with SMTP id 5f08d9e57c8ca473a82dccfb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 10 Jul 2020 21:13:09 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2269EC433CB; Fri, 10 Jul 2020 21:13:09 +0000 (UTC) Received: from [192.168.1.9] (unknown [117.210.185.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akhilpo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 66CF0C433C8; Fri, 10 Jul 2020 21:13:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 66CF0C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akhilpo@codeaurora.org Subject: Re: [PATCH v4 3/7] drm: msm: a6xx: set gpu freq through hfi To: Jonathan Marek , freedreno@lists.freedesktop.org Cc: devicetree@vger.kernel.org, saravanak@google.com, linux-arm-msm@vger.kernel.org, smasetty@codeaurora.org, linux-kernel@vger.kernel.org, mka@chromium.org, dri-devel@freedesktop.org, viresh.kumar@linaro.org, sibis@codeaurora.org References: <1594324828-9571-1-git-send-email-akhilpo@codeaurora.org> <1594324828-9571-4-git-send-email-akhilpo@codeaurora.org> <322c921f-7c8f-7052-b191-44f0dade742e@marek.ca> From: Akhil P Oommen Message-ID: <40f6df1d-f524-c612-9215-591fd7f16e3b@codeaurora.org> Date: Sat, 11 Jul 2020 02:43:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <322c921f-7c8f-7052-b191-44f0dade742e@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 7/10/2020 1:34 AM, Jonathan Marek wrote: > On 7/9/20 4:00 PM, Akhil P Oommen wrote: >> Newer targets support changing gpu frequency through HFI. So >> use that wherever supported instead of the legacy method. >> > > It was already using HFI on newer targets. Don't break it in one > commit then fix it in the next. Oops. I somehow got confused. Will fix and resend. -Akhil > >> Signed-off-by: Akhil P Oommen >> --- >>   drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 +++++++---- >>   1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> index 233afea..b547339 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> @@ -121,6 +121,12 @@ void a6xx_gmu_set_freq(struct msm_gpu *gpu, >> struct dev_pm_opp *opp) >>           if (gpu_freq == gmu->gpu_freqs[perf_index]) >>               break; >>   +    if (!gmu->legacy) { >> +        a6xx_hfi_set_freq(gmu, gmu->current_perf_index); >> +        icc_set_bw(gpu->icc_path, 0, MBps_to_icc(7216)); >> +        return; >> +    } >> + >>       gmu->current_perf_index = perf_index; >>       gmu->freq = gmu->gpu_freqs[perf_index]; >>   @@ -893,10 +899,7 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu) >>       enable_irq(gmu->hfi_irq); >>         /* Set the GPU to the current freq */ >> -    if (gmu->legacy) >> -        a6xx_gmu_set_initial_freq(gpu, gmu); >> -    else >> -        a6xx_hfi_set_freq(gmu, gmu->current_perf_index); >> +    a6xx_gmu_set_initial_freq(gpu, gmu); >>         /* >>        * "enable" the GX power domain which won't actually do >> anything but it >> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B244C433E3 for ; Fri, 10 Jul 2020 21:13:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E6ED2068F for ; Fri, 10 Jul 2020 21:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="VRcKmf5T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E6ED2068F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F390E6ED13; Fri, 10 Jul 2020 21:13:20 +0000 (UTC) Received: from mail29.static.mailgun.info (mail29.static.mailgun.info [104.130.122.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A7AA6ED14 for ; Fri, 10 Jul 2020 21:13:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594415599; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=Y1rBBSjHn58KkYWcfa8FN19qXT4mpd6FmEsIOBn/G4I=; b=VRcKmf5TfhYkM1wz+ukiKIceuSmWYAJEDIBdYg+olZgpL+Z+8Vog1chCT7Jw3T+EaqnY2aaN 9O151L3WiemBROWZx5+S3Wby9mJ6ST4VRgvpvknrsI1HknpACsYNie6N6rJ3p7Tk/N2YPTvL 4LfHJVs1txVrU6hyPpW0Y/RYjQQ= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyIxOTRiMSIsICJkcmktZGV2ZWxAZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n15.prod.us-east-1.postgun.com with SMTP id 5f08d9e57c8ca473a82dcd14 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 10 Jul 2020 21:13:09 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 31D94C433CA; Fri, 10 Jul 2020 21:13:09 +0000 (UTC) Received: from [192.168.1.9] (unknown [117.210.185.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akhilpo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 66CF0C433C8; Fri, 10 Jul 2020 21:13:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 66CF0C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akhilpo@codeaurora.org Subject: Re: [PATCH v4 3/7] drm: msm: a6xx: set gpu freq through hfi To: Jonathan Marek , freedreno@lists.freedesktop.org References: <1594324828-9571-1-git-send-email-akhilpo@codeaurora.org> <1594324828-9571-4-git-send-email-akhilpo@codeaurora.org> <322c921f-7c8f-7052-b191-44f0dade742e@marek.ca> From: Akhil P Oommen Message-ID: <40f6df1d-f524-c612-9215-591fd7f16e3b@codeaurora.org> Date: Sat, 11 Jul 2020 02:43:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <322c921f-7c8f-7052-b191-44f0dade742e@marek.ca> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, saravanak@google.com, linux-arm-msm@vger.kernel.org, smasetty@codeaurora.org, linux-kernel@vger.kernel.org, mka@chromium.org, dri-devel@freedesktop.org, viresh.kumar@linaro.org, sibis@codeaurora.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Ck9uIDcvMTAvMjAyMCAxOjM0IEFNLCBKb25hdGhhbiBNYXJlayB3cm90ZToKPiBPbiA3LzkvMjAg NDowMCBQTSwgQWtoaWwgUCBPb21tZW4gd3JvdGU6Cj4+IE5ld2VyIHRhcmdldHMgc3VwcG9ydCBj aGFuZ2luZyBncHUgZnJlcXVlbmN5IHRocm91Z2ggSEZJLiBTbwo+PiB1c2UgdGhhdCB3aGVyZXZl ciBzdXBwb3J0ZWQgaW5zdGVhZCBvZiB0aGUgbGVnYWN5IG1ldGhvZC4KPj4KPgo+IEl0IHdhcyBh bHJlYWR5IHVzaW5nIEhGSSBvbiBuZXdlciB0YXJnZXRzLiBEb24ndCBicmVhayBpdCBpbiBvbmUg Cj4gY29tbWl0IHRoZW4gZml4IGl0IGluIHRoZSBuZXh0LgoKT29wcy4gSSBzb21laG93IGdvdCBj b25mdXNlZC4gV2lsbCBmaXggYW5kIHJlc2VuZC4KCi1Ba2hpbAoKPgo+PiBTaWduZWQtb2ZmLWJ5 OiBBa2hpbCBQIE9vbW1lbiA8YWtoaWxwb0Bjb2RlYXVyb3JhLm9yZz4KPj4gLS0tCj4+IMKgIGRy aXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E2eHhfZ211LmMgfCAxMSArKysrKysrLS0tLQo+PiDC oCAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTZ4eF9nbXUuYyAKPj4gYi9k cml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNnh4X2dtdS5jCj4+IGluZGV4IDIzM2FmZWEuLmI1 NDczMzkgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E2eHhfZ211 LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTZ4eF9nbXUuYwo+PiBAQCAt MTIxLDYgKzEyMSwxMiBAQCB2b2lkIGE2eHhfZ211X3NldF9mcmVxKHN0cnVjdCBtc21fZ3B1ICpn cHUsIAo+PiBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwKQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaWYg KGdwdV9mcmVxID09IGdtdS0+Z3B1X2ZyZXFzW3BlcmZfaW5kZXhdKQo+PiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBicmVhazsKPj4gwqAgK8KgwqDCoCBpZiAoIWdtdS0+bGVnYWN5KSB7Cj4+ ICvCoMKgwqDCoMKgwqDCoCBhNnh4X2hmaV9zZXRfZnJlcShnbXUsIGdtdS0+Y3VycmVudF9wZXJm X2luZGV4KTsKPj4gK8KgwqDCoMKgwqDCoMKgIGljY19zZXRfYncoZ3B1LT5pY2NfcGF0aCwgMCwg TUJwc190b19pY2MoNzIxNikpOwo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuOwo+PiArwqDCoMKg IH0KPj4gKwo+PiDCoMKgwqDCoMKgIGdtdS0+Y3VycmVudF9wZXJmX2luZGV4ID0gcGVyZl9pbmRl eDsKPj4gwqDCoMKgwqDCoCBnbXUtPmZyZXEgPSBnbXUtPmdwdV9mcmVxc1twZXJmX2luZGV4XTsK Pj4gwqAgQEAgLTg5MywxMCArODk5LDcgQEAgaW50IGE2eHhfZ211X3Jlc3VtZShzdHJ1Y3QgYTZ4 eF9ncHUgKmE2eHhfZ3B1KQo+PiDCoMKgwqDCoMKgIGVuYWJsZV9pcnEoZ211LT5oZmlfaXJxKTsK Pj4gwqAgwqDCoMKgwqDCoCAvKiBTZXQgdGhlIEdQVSB0byB0aGUgY3VycmVudCBmcmVxICovCj4+ IC3CoMKgwqAgaWYgKGdtdS0+bGVnYWN5KQo+PiAtwqDCoMKgwqDCoMKgwqAgYTZ4eF9nbXVfc2V0 X2luaXRpYWxfZnJlcShncHUsIGdtdSk7Cj4+IC3CoMKgwqAgZWxzZQo+PiAtwqDCoMKgwqDCoMKg wqAgYTZ4eF9oZmlfc2V0X2ZyZXEoZ211LCBnbXUtPmN1cnJlbnRfcGVyZl9pbmRleCk7Cj4+ICvC oMKgwqAgYTZ4eF9nbXVfc2V0X2luaXRpYWxfZnJlcShncHUsIGdtdSk7Cj4+IMKgIMKgwqDCoMKg wqAgLyoKPj4gwqDCoMKgwqDCoMKgICogImVuYWJsZSIgdGhlIEdYIHBvd2VyIGRvbWFpbiB3aGlj aCB3b24ndCBhY3R1YWxseSBkbyAKPj4gYW55dGhpbmcgYnV0IGl0Cj4+Cj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBs aXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=