All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström (Intel)" <thomas_os@shipmail.org>
To: Michael Cheng <michael.cheng@intel.com>, intel-gfx@lists.freedesktop.org
Cc: lucas.demarchi@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus
Date: Tue, 22 Feb 2022 20:24:31 +0100	[thread overview]
Message-ID: <40f820e6-6b28-fd8a-b058-13f0bbbf71fc@shipmail.org> (raw)
In-Reply-To: <20220222172649.331661-3-michael.cheng@intel.com>

Hi, Michael,

On 2/22/22 18:26, Michael Cheng wrote:
> This patch removes logic for wbinvd_on_all_cpus and brings in
> drm_cache.h. This header has the logic that outputs a warning
> when wbinvd_on_all_cpus when its being used on a non-x86 platform.
>
> Signed-off-by: Michael Cheng <michael.cheng@intel.com>

Linus has been pretty clear that he won't accept patches that add macros 
that works on one arch and warns on others anymore in i915 and I figure 
even less so in drm code.

So we shouldn't try to move this out to drm. Instead we should restrict 
the wbinvd() inside our driver to integrated and X86 only. For discrete 
on all architectures we should be coherent and hence not be needing 
wbinvd().

Thanks,

/Thomas



  reply	other threads:[~2022-02-22 19:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 17:26 [PATCH v3 0/3] Move #define wbvind_on_all_cpus Michael Cheng
2022-02-22 17:26 ` [Intel-gfx] " Michael Cheng
2022-02-22 17:26 ` [PATCH v3 1/3] drm_cache: Add logic for wbvind_on_all_cpus Michael Cheng
2022-02-22 17:26   ` [Intel-gfx] " Michael Cheng
2022-02-22 21:07   ` kernel test robot
2022-02-22 21:07     ` [Intel-gfx] " kernel test robot
2022-02-22 23:31   ` kernel test robot
2022-02-22 23:31     ` kernel test robot
2022-02-22 23:31     ` [Intel-gfx] " kernel test robot
2022-02-22 23:31   ` kernel test robot
2022-02-22 23:31     ` [Intel-gfx] " kernel test robot
2022-02-22 17:26 ` [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus Michael Cheng
2022-02-22 17:26   ` [Intel-gfx] " Michael Cheng
2022-02-22 19:24   ` Thomas Hellström (Intel) [this message]
2022-02-23  1:13     ` Michael Cheng
2022-03-08 17:58     ` Lucas De Marchi
2022-03-14 23:06       ` Michael Cheng
2022-03-15 16:59         ` Michael Cheng
2022-03-16  8:48           ` Thomas Hellström (Intel)
2022-02-22 17:26 ` [PATCH v3 3/3] drm/i915/: Add drm_cache.h Michael Cheng
2022-02-22 17:26   ` [Intel-gfx] " Michael Cheng
2022-02-23  2:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Move #define wbvind_on_all_cpus (rev4) Patchwork
2022-02-23  2:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-23  3:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-02-24  1:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Move #define wbvind_on_all_cpus (rev5) Patchwork
2022-02-24  1:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-24  2:00 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f820e6-6b28-fd8a-b058-13f0bbbf71fc@shipmail.org \
    --to=thomas_os@shipmail.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=michael.cheng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.