All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [v2, 1/2] powerpc/watchdog: don't update the watchdog timestamp if a lockup is detected
Date: Fri, 11 May 2018 00:06:37 +1000 (AEST)	[thread overview]
Message-ID: <40hZlf3p8pz9s0W@ozlabs.org> (raw)
In-Reply-To: <20180505072600.13270-2-npiggin@gmail.com>

On Sat, 2018-05-05 at 07:25:59 UTC, Nicholas Piggin wrote:
> The watchdog heartbeat timestamp is updated when the local heartbeat
> timer fires (or touch_nmi_watchdog() is called).
> 
> This is an interesting data point, so don't overwrite it when the
> soft-NMI interrupt detects a hard lockup. That code came from a pre-
> merge version to prevent hard lockup messages flood, but that's taken
> care of with the stuck CPU logic now, so there is no reason to
> update the heartbeat timestamp here.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Series applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/5a951c4e7e8df5d6df52bace1b4ff3

cheers

  reply	other threads:[~2018-05-10 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-05  7:25 [PATCH v2 0/2] powerpc/watchdog: provide more data in watchdog messages Nicholas Piggin
2018-05-05  7:25 ` [PATCH v2 1/2] powerpc/watchdog: don't update the watchdog timestamp if a lockup is detected Nicholas Piggin
2018-05-10 14:06   ` Michael Ellerman [this message]
2018-05-05  7:26 ` [PATCH v2 2/2] powerpc/watchdog: provide more data in watchdog messages Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40hZlf3p8pz9s0W@ozlabs.org \
    --to=patch-notifications@ellerman.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.