All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: malat@debian.org
Subject: Re: [1/2] powerpc/xmon: Specify the full format in DUMP() macro
Date: Fri, 25 May 2018 21:41:51 +1000 (AEST)	[thread overview]
Message-ID: <40skqg5BJkz9s6t@ozlabs.org> (raw)
In-Reply-To: <20180523114837.6980-1-mpe@ellerman.id.au>

On Wed, 2018-05-23 at 11:48:36 UTC, Michael Ellerman wrote:
> In dump_one_paca() the DUMP macro unconditionally prepends '#' to the
> printf format specifier. In most cases we're using either 'x' or 'lx'
> etc. and that is OK. But for 'p' and other formats using '#' is
> actually undefined, and once we enable printf() checking for
> xmon_printf() we will get warnings from the compiler.
> 
> So just have each usage specify the full format, that way we can omit
> '#' when it's inappropriate.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Mathieu Malaterre <malat@debian.org>

Applied to powerpc next.

https://git.kernel.org/powerpc/c/6671683db8540e5766f44a1089549c

cheers

      parent reply	other threads:[~2018-05-25 11:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 11:48 [PATCH 1/2] powerpc/xmon: Specify the full format in DUMP() macro Michael Ellerman
2018-05-23 11:48 ` [PATCH 2/2] powerpc/xmon: Realign paca dump fields Michael Ellerman
2018-05-25 11:41   ` [2/2] " Michael Ellerman
2018-05-23 18:55 ` [PATCH 1/2] powerpc/xmon: Specify the full format in DUMP() macro Mathieu Malaterre
2018-05-25 11:41 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40skqg5BJkz9s6t@ozlabs.org \
    --to=patch-notifications@ellerman.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=malat@debian.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.