From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbdJQIlV convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 04:41:21 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:48565 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbdJQIlS (ORCPT ); Tue, 17 Oct 2017 04:41:18 -0400 From: Minas Harutyunyan To: John Stultz , Minas Harutyunyan CC: John Youn , lkml , Wei Xu , Guodong Xu , "Amit Pundir" , YongQin Liu , Douglas Anderson , Chen Yu , Felipe Balbi , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" Subject: Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey Thread-Topic: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey Thread-Index: AQHTMkq1fSiD2TKttEaGjxxQhxASTg== Date: Tue, 17 Oct 2017 08:41:08 +0000 Message-ID: <410670D7E743164D87FA6160E7907A560113A2ECC2@am04wembxa.internal.synopsys.com> References: <1505937448-13475-1-git-send-email-john.stultz@linaro.org> <2B3535C5ECE8B5419E3ECBE3007729090269FF70AC@US01WEMBX2.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560113A21CDB@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560113A2C8E9@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A560113A2E38F@am04wembxa.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.92] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/2017 1:34 AM, John Stultz wrote: > On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan > wrote: >> On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt. >> According previously sent by you register dump (GHWCFG2 = 0x23affc70) >> your core OTG_MODE=0. >> Bellow fragment from programming guide on Device disconnect: >> >> "7.3Device Disconnection >> The device session ends when the USB cable is disconnected or if the >> VBUS is switched off by the Host. The >> device disconnect flow varies depending on the value of the OTG_MODE >> configuration parameter. >> >> When OTG_MODE = 0,1, or 3 >> When OTG_MODE is set to 0,1, or 3, the device disconnect flow is as follows: >> 1. When the USB cable is unplugged or when the VBUS is switched off by >> the Host, the Device core >> trigger GINTSTS.OTGInt [bit 2] interrupt bit. >> 2. When the device application detects GINTSTS.OTGInt interrupt, it >> checks that the >> GOTGINT.SesEndDet (Session End Detected) bit is set to 1’b1." >> >> So, you should receive and handle "Session End Detected". In function >> dwc2_handle_otg_intr() on this interrupt (in device mode) calling >> dwc2_hsotg_disconnect() function. By adding your patch "[PATCH 3/3] usb: >> dwc2: Fix UDC state tracking" state changed to not attached as required. > > > So, on the HiKey board (using 4.14-rc5 + Vardan's patch), I'm not > seeing the GOTGINT_SES_END_DET in dwc2_handle_otg_intr() when I remove > the USB OTG cable. > > In fact, I'm not seeing any calls to dwc2_handle_otg_intr()... which > seems... odd maybe? Any clues as to what might be going wrong then? > > thanks > -john > Hi John Stultz, So, on Hikey board on unplug B connector GOTGINT.SesEndDet interrupt not asserted, instead asserted GINTSTS_CONIDSTSCHNG. Please, confirm. In this case without your patch "[PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling" but by applying your patch "[PATCH 3/3] usb: dwc2: Fix UDC state tracking": 1. On B plug connect UDC state will be set to "configured" 2. On B plug disconnect - "not attached". Is it Ok for you? Meantime, I'll check with HW team why GOTGINT.SesEndDet interrupt not asserted on unplug B connector. Thanks, Minas