From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2627688-1526999110-2-16126083297330498556 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.248, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='UNK' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1526999110; b=eSEidhDwvpt8loaYfOdyQXzNWgcyZSDlyRzcNs5Ju5cMxmhul0 8LrUwCzT1NoKW3yN2SRA79FaJTgzRfT6TsugWVJU6Fuy4aEvhU2ClOgKe2NCdEeI 62ZduTOHDxqVlbOcdaamtp0ZdVL29HG2IH+0dZxoSZ8HJqZqy3to5w6NDbBcCVyG 7BrSDDhHFWxoiKwwslxEyeQ5gq3YNmAa8oQdVC6PXcmN0a8f1sSjXbgdAJWsKr5q uRJLBN2CwAHqVjbKW+3jxBlCGmIMZcIFCkSr+V9CWOTlsPqmom4VG+Cg+hUhyHWx FgbJzSDUHgWFQ1GTEX38uZOAsbaUBID1FUiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:content-type:content-transfer-encoding:mime-version :sender:list-id; s=fm2; t=1526999110; bh=H5P2LNR4JT2EXA0gTLqv4Tz sxT7tIxvlcTYggn2Vjxk=; b=hyPRsC0Rat6qJZib4WlFQaL3wTIF2IQnmreevu8 Fjsj89OAThgmUdjI01timuMkrp6l5QQKpa2IauvlOcx4jt7Xbia85kuiFa2QoXIS SDIEetvt+PBRqe8oWuV9spQip3MOFLDpzl9sAYtwiU3Ap5a06OStrprcQTf6OPwQ FFqWCgK6zD7rwFNxjCEyP2uqmbVDWt7sHdx0Uq243XEkEAc0Fn289IttX7ZQOdHZ hUBtcCG+5IurqV7NLCbHcIO8nyCa8cHubKqE37Oe5pGUwLm7iKe0vNoOmYz9Jjgl hZ6EYrpL+w8BO2vGftB00lCiG0fh42MFJhjuJIDtj6uqq+A== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered, 2048-bit rsa key sha256) header.d=synopsys.com header.i=@synopsys.com header.b=NASOVZRX x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=mail; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=synopsys.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=synopsys.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered, 2048-bit rsa key sha256) header.d=synopsys.com header.i=@synopsys.com header.b=NASOVZRX x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=mail; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=synopsys.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=synopsys.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfAw3ZsQ40SgENcRP22s2hPNcNAuS0YzfgONU10E9xr9VhXp/DMYfDpKyp9OSwiGtax0QXzxz/wSEnuMSulWdxKjyCFBxmvs6dFyCpqeUiQ1QDT3tT0a1 97536u2VRLXr7uoMhrsL8LqVOK2Go95bq7yWWSegEChUfsobyZZM9uSgNez8nMIsithGPE7S4zSb/CS66X7PmNaerdeqdjznMYNp4Pu2b1MUaAs6luGdjui6 X-CM-Analysis: v=2.3 cv=WaUilXpX c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=2AxsI-llnUoA:10 a=kj9zAlcOel0A:10 a=xqWC_Br6kY4A:10 a=VUJBJC2UJ8kA:10 a=jIQo8A4GAAAA:8 a=VwQbUJbxAAAA:8 a=4fsD5RWkkhMDKuSQGLYA:9 a=CjuIK1q_8ugA:10 a=x8gzFH9gYPwA:10 a=Lf5xNeLK5dgiOs8hzIjU:22 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbeEVOY4 (ORCPT ); Tue, 22 May 2018 10:24:56 -0400 Received: from smtprelay.synopsys.com ([198.182.37.59]:49522 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbeEVOYz (ORCPT ); Tue, 22 May 2018 10:24:55 -0400 From: Minas Harutyunyan To: John Stultz , Minas Harutyunyan CC: lkml , John Youn , Vardan Mikayelyan , Artur Petrosyan , Grigor Tovmasyan , Felipe Balbi , "linux-usb@vger.kernel.org" Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature Thread-Index: AQHT7ws4+xyvQUj0rEqQiAqvmDphzw== Date: Tue, 22 May 2018 14:24:47 +0000 Message-ID: <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com> References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org> <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.67] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi John,=0A= =0A= Please provide log with debug enabled configuration.=0A= =0A= On 5/21/2018 11:41 PM, John Stultz wrote:=0A= > On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan=0A= > wrote:=0A= >> Hi John,=0A= >>=0A= >> On 5/19/2018 4:49 AM, John Stultz wrote:=0A= >>> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")=0A= >>> caused the HiKey board to not correctly handle switching between=0A= >>> usb-gadget and usb-host mode.=0A= >>>=0A= >>> Unplugging the OTG port would result in:=0A= OTG port you mean MicroAB, Correct?=0A= dwc2 driver loaded when some device connected to OTG port?=0A= And below message printed after disconnect the device from OTG port?=0A= =0A= >>> [ 42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host = registers to restore=0A= >>> [ 42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to= restore host registers=0A= >>>=0A= >>> And the USB-host ports would not function.=0A= USB-host ports - you mean 2 USB A-ports, connected to TS3USB221 HUB?=0A= Switching ports between OTG and Host ports via TS3USB221 Switch =0A= performing automatically or by some SW tool?=0A= =0A= >>>=0A= >>> And plugging in the OTG port, we would see:=0A= >>> [ 46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 = dwc2_hsotg_init_fifo+0x194/0x1a0=0A= >>> [ 46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5= -00030-ge67da8c #231=0A= >>> [ 46.055767] Hardware name: HiKey Development Board (DT)=0A= >>> [ 46.055784] Workqueue: dwc2 dwc2_conn_id_status_change=0A= >>> ...=0A= >>>=0A= >> Could you please send full log to debug.=0A= > =0A= > Full dmesg log attached.=0A= > =0A= > I unplugged the usb-otg port at 136=0A= > and replugged it back in at 141=0A= > =0A= > =0A= >>> p->uframe_sched =3D false;=0A= >>> p->change_speed_quirk =3D true;=0A= >>> + p->power_down =3D false;=0A= >>=0A= >> power_down declared as int, suggested to update as follow:=0A= >> p->power_down =3D DWC2_POWER_DOWN_PARAM_NONE;=0A= >>=0A= >> This can be accepted as temporary solution until we will fully debug=0A= >> hibernation feature for HiKey platform.=0A= > =0A= > Ok, will re-send with the suggested change above.=0A= > =0A= > thanks=0A= > -john=0A= > =0A= =0A= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc2: Fix HiKey regression caused by power_down feature From: Minas Harutyunyan Message-Id: <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com> Date: Tue, 22 May 2018 14:24:47 +0000 To: John Stultz , Minas Harutyunyan Cc: lkml , John Youn , Vardan Mikayelyan , Artur Petrosyan , Grigor Tovmasyan , Felipe Balbi , "linux-usb@vger.kernel.org" List-ID: SGkgSm9obiwKClBsZWFzZSBwcm92aWRlIGxvZyB3aXRoIGRlYnVnIGVuYWJsZWQgY29uZmlndXJh dGlvbi4KCk9uIDUvMjEvMjAxOCAxMTo0MSBQTSwgSm9obiBTdHVsdHogd3JvdGU6Cj4gT24gTW9u LCBNYXkgMjEsIDIwMTggYXQgMTo0NSBBTSwgTWluYXMgSGFydXR5dW55YW4KPiA8TWluYXMuSGFy dXR5dW55YW5Ac3lub3BzeXMuY29tPiB3cm90ZToKPj4gSGkgSm9obiwKPj4KPj4gT24gNS8xOS8y MDE4IDQ6NDkgQU0sIEpvaG4gU3R1bHR6IHdyb3RlOgo+Pj4gSW4gNC4xNy1yYywgY29tbWl0IDAz ZWE2ZDZlOWUxZiAoInVzYjogZHdjMjogRW5hYmxlIHBvd2VyIGRvd24iKQo+Pj4gY2F1c2VkIHRo ZSBIaUtleSBib2FyZCB0byBub3QgY29ycmVjdGx5IGhhbmRsZSBzd2l0Y2hpbmcgYmV0d2Vlbgo+ Pj4gdXNiLWdhZGdldCBhbmQgdXNiLWhvc3QgbW9kZS4KPj4+Cj4+PiBVbnBsdWdnaW5nIHRoZSBP VEcgcG9ydCB3b3VsZCByZXN1bHQgaW46Ck9URyBwb3J0IHlvdSBtZWFuIE1pY3JvQUIsIENvcnJl Y3Q/CmR3YzIgZHJpdmVyIGxvYWRlZCB3aGVuIHNvbWUgZGV2aWNlIGNvbm5lY3RlZCB0byBPVEcg cG9ydD8KQW5kIGJlbG93IG1lc3NhZ2UgcHJpbnRlZCBhZnRlciBkaXNjb25uZWN0IHRoZSBkZXZp Y2UgZnJvbSBPVEcgcG9ydD8KCj4+PiBbICAgNDIuMjQwOTczXSBkd2MyIGY3MmMwMDAwLnVzYjog ZHdjMl9yZXN0b3JlX2hvc3RfcmVnaXN0ZXJzOiBubyBob3N0IHJlZ2lzdGVycyB0byByZXN0b3Jl Cj4+PiBbICAgNDIuMjQ5MDY2XSBkd2MyIGY3MmMwMDAwLnVzYjogZHdjMl9ob3N0X2V4aXRfaGli ZXJuYXRpb246IGZhaWxlZCB0byByZXN0b3JlIGhvc3QgcmVnaXN0ZXJzCj4+Pgo+Pj4gQW5kIHRo ZSBVU0ItaG9zdCBwb3J0cyB3b3VsZCBub3QgZnVuY3Rpb24uClVTQi1ob3N0IHBvcnRzIC0geW91 IG1lYW4gMiBVU0IgQS1wb3J0cywgY29ubmVjdGVkIHRvIFRTM1VTQjIyMSBIVUI/ClN3aXRjaGlu ZyBwb3J0cyBiZXR3ZWVuIE9URyBhbmQgSG9zdCBwb3J0cyB2aWEgVFMzVVNCMjIxIFN3aXRjaCAK cGVyZm9ybWluZyBhdXRvbWF0aWNhbGx5IG9yIGJ5IHNvbWUgU1cgdG9vbD8KCj4+Pgo+Pj4gQW5k IHBsdWdnaW5nIGluIHRoZSBPVEcgcG9ydCwgd2Ugd291bGQgc2VlOgo+Pj4gWyAgIDQ2LjA0NjU1 N10gV0FSTklORzogQ1BVOiAzIFBJRDogNiBhdCBkcml2ZXJzL3VzYi9kd2MyL2dhZGdldC5jOjI2 MCBkd2MyX2hzb3RnX2luaXRfZmlmbysweDE5NC8weDFhMAo+Pj4gWyAgIDQ2LjA1NTc2MV0gQ1BV OiAzIFBJRDogNiBDb21tOiBrd29ya2VyL3UxNjowIE5vdCB0YWludGVkIDQuMTcuMC1yYzUtMDAw MzAtZ2U2N2RhOGMgIzIzMQo+Pj4gWyAgIDQ2LjA1NTc2N10gSGFyZHdhcmUgbmFtZTogSGlLZXkg RGV2ZWxvcG1lbnQgQm9hcmQgKERUKQo+Pj4gWyAgIDQ2LjA1NTc4NF0gV29ya3F1ZXVlOiBkd2My IGR3YzJfY29ubl9pZF9zdGF0dXNfY2hhbmdlCj4+PiAuLi4KPj4+Cj4+IENvdWxkIHlvdSBwbGVh c2Ugc2VuZCBmdWxsIGxvZyB0byBkZWJ1Zy4KPiAKPiBGdWxsIGRtZXNnIGxvZyBhdHRhY2hlZC4K PiAKPiBJIHVucGx1Z2dlZCB0aGUgdXNiLW90ZyBwb3J0IGF0IDEzNgo+IGFuZCByZXBsdWdnZWQg aXQgYmFjayBpbiBhdCAxNDEKPiAKPiAKPj4+ICAgICAgICBwLT51ZnJhbWVfc2NoZWQgPSBmYWxz ZTsKPj4+ICAgICAgICBwLT5jaGFuZ2Vfc3BlZWRfcXVpcmsgPSB0cnVlOwo+Pj4gKyAgICAgcC0+ cG93ZXJfZG93biA9IGZhbHNlOwo+Pgo+PiBwb3dlcl9kb3duIGRlY2xhcmVkIGFzIGludCwgc3Vn Z2VzdGVkIHRvIHVwZGF0ZSBhcyBmb2xsb3c6Cj4+ICAgICAgICAgIHAtPnBvd2VyX2Rvd24gPSBE V0MyX1BPV0VSX0RPV05fUEFSQU1fTk9ORTsKPj4KPj4gVGhpcyBjYW4gYmUgYWNjZXB0ZWQgYXMg dGVtcG9yYXJ5IHNvbHV0aW9uIHVudGlsIHdlIHdpbGwgZnVsbHkgZGVidWcKPj4gaGliZXJuYXRp b24gZmVhdHVyZSBmb3IgSGlLZXkgcGxhdGZvcm0uCj4gCj4gT2ssIHdpbGwgcmUtc2VuZCB3aXRo IHRoZSBzdWdnZXN0ZWQgY2hhbmdlIGFib3ZlLgo+IAo+IHRoYW5rcwo+IC1qb2huCj4KLS0tClRv IHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBs aW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJu ZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFq b3Jkb21vLWluZm8uaHRtbAo=