All of lore.kernel.org
 help / color / mirror / Atom feed
* [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere
@ 2018-07-26 20:07 Douglas Anderson
  2018-07-26 20:07   ` [REPOST,1/4] " Doug Anderson
                   ` (5 more replies)
  0 siblings, 6 replies; 19+ messages in thread
From: Douglas Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

While looking at a dwc2 recently, I noticed that some platforms still
have the uframe scheduler off.  As far as I know, nothing good can
come out of having the uframe scheduler off.  Let's turn it on
everywhere.  Assuming this all works out then some time in the future
we can gut all the old code that handles the old non-uframe scheduler
and make everything simpler.

This is a repost of the original "RFT" (request for testing) series I
posted a few weeks ago but without the "RFT" prefix.  Two of the
patches in the series now have "Tested-by:" tags.  Since there should
be nothing platform specific about the uFrame scheduler presumably
this should mean we're good to go?  Specificaly note that in at least
one of the "Tested-by" reports this patch caused a notable
improvement.

In response to the original RFT, some notes about testing this:
- In general, try to have lots of things plugged in.
- Plug many different keyboards / mice in.  See if keys are
  dropped / mouse is jerky.
- Try USB audio (ideally full speed, not high speed).  How is
  the audio?
- If you're brave, try a USB webcam.  How is the video?
  ...maybe try including patches from crbug.com/820961 too.


Douglas Anderson (4):
  usb: dwc2: Turn on uframe_sched on "bcm" platforms
  usb: dwc2: Turn on uframe_sched on "his" platforms
  usb: dwc2: Turn on uframe_sched on "amlogic" platforms
  usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms

 drivers/usb/dwc2/params.c | 4 ----
 1 file changed, 4 deletions(-)

-- 
2.18.0.345.g5c9ce644c3-goog


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Douglas Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on Broadcom since commit
58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
Since then there have been many many improvements, notably the commit
9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
scheduler")

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index af075d4da895..14b8742e62fa 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
 	p->max_transfer_size = 65535;
 	p->max_packet_count = 511;
 	p->ahbcfg = 0x10;
-	p->uframe_sched = false;
 }
 
 static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
-- 
2.18.0.345.g5c9ce644c3-goog


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Doug Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on Broadcom since commit
58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
Since then there have been many many improvements, notably the commit
9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
scheduler")

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index af075d4da895..14b8742e62fa 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
 	p->max_transfer_size = 65535;
 	p->max_packet_count = 511;
 	p->ahbcfg = 0x10;
-	p->uframe_sched = false;
 }
 
 static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Douglas Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on HiSilicon since commit
37dd9d65cc41 ("usb: dwc2: add support of hi6220").  Since then there
have been many many improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler")

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Tested-by: John Stultz <john.stultz@linaro.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 14b8742e62fa..db97bb16ecc4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
 	p->reload_ctl = false;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
 		GAHBCFG_HBSTLEN_SHIFT;
-	p->uframe_sched = false;
 	p->change_speed_quirk = true;
 	p->power_down = false;
 }
-- 
2.18.0.345.g5c9ce644c3-goog


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,2/4] usb: dwc2: Turn on uframe_sched on "his" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Doug Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on HiSilicon since commit
37dd9d65cc41 ("usb: dwc2: add support of hi6220").  Since then there
have been many many improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler")

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Tested-by: John Stultz <john.stultz@linaro.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 14b8742e62fa..db97bb16ecc4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
 	p->reload_ctl = false;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
 		GAHBCFG_HBSTLEN_SHIFT;
-	p->uframe_sched = false;
 	p->change_speed_quirk = true;
 	p->power_down = false;
 }

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Douglas Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on Amlogic since commit f94310ac076e
("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
after most of the recent improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
the parameters were copied from another platform and the uframe
scheduler wasn't tried.

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index db97bb16ecc4..93380f7c32b4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
 	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
 		GAHBCFG_HBSTLEN_SHIFT;
-	p->uframe_sched = false;
 }
 
 static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
-- 
2.18.0.345.g5c9ce644c3-goog


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Doug Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on Amlogic since commit f94310ac076e
("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
after most of the recent improvements, notably the commit 9f9f09b048f5
("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
the parameters were copied from another platform and the uframe
scheduler wasn't tried.

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index db97bb16ecc4..93380f7c32b4 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
 	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
 	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
 		GAHBCFG_HBSTLEN_SHIFT;
-	p->uframe_sched = false;
 }
 
 static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Douglas Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on stm32f4x9_fsotg since commit
e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG
HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so
it's unclear to me why the uframe scheduler was left off.  Hopefully
it's because someone copied it from other parameters and didn't think
to try it?

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 93380f7c32b4..7be35bcde713 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
 	p->max_packet_count = 256;
 	p->phy_type = DWC2_PHY_TYPE_PARAM_FS;
 	p->i2c_enable = false;
-	p->uframe_sched = false;
 	p->activate_stm_fs_transceiver = true;
 }
 
-- 
2.18.0.345.g5c9ce644c3-goog


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
@ 2018-07-26 20:07   ` Doug Anderson
  0 siblings, 0 replies; 19+ messages in thread
From: Doug Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
  To: balbi, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

There's no reason to have the uframe scheduler off on dwc2.  Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".

The uframe scheduler has been off on stm32f4x9_fsotg since commit
e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG
HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so
it's unclear to me why the uframe scheduler was left off.  Hopefully
it's because someone copied it from other parameters and didn't think
to try it?

Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/usb/dwc2/params.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 93380f7c32b4..7be35bcde713 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
 	p->max_packet_count = 256;
 	p->phy_type = DWC2_PHY_TYPE_PARAM_FS;
 	p->i2c_enable = false;
-	p->uframe_sched = false;
 	p->activate_stm_fs_transceiver = true;
 }
 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere
  2018-07-26 20:07 [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson
                   ` (3 preceding siblings ...)
  2018-07-26 20:07   ` [REPOST,4/4] " Doug Anderson
@ 2018-07-27 10:01 ` Felipe Balbi
  2018-07-27 11:00 ` Minas Harutyunyan
  5 siblings, 0 replies; 19+ messages in thread
From: Felipe Balbi @ 2018-07-27 10:01 UTC (permalink / raw)
  To: Douglas Anderson, hminas, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
	linux-usb, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

Douglas Anderson <dianders@chromium.org> writes:

> While looking at a dwc2 recently, I noticed that some platforms still
> have the uframe scheduler off.  As far as I know, nothing good can
> come out of having the uframe scheduler off.  Let's turn it on
> everywhere.  Assuming this all works out then some time in the future
> we can gut all the old code that handles the old non-uframe scheduler
> and make everything simpler.
>
> This is a repost of the original "RFT" (request for testing) series I
> posted a few weeks ago but without the "RFT" prefix.  Two of the
> patches in the series now have "Tested-by:" tags.  Since there should
> be nothing platform specific about the uFrame scheduler presumably
> this should mean we're good to go?  Specificaly note that in at least
> one of the "Tested-by" reports this patch caused a notable
> improvement.
>
> In response to the original RFT, some notes about testing this:
> - In general, try to have lots of things plugged in.
> - Plug many different keyboards / mice in.  See if keys are
>   dropped / mouse is jerky.
> - Try USB audio (ideally full speed, not high speed).  How is
>   the audio?
> - If you're brave, try a USB webcam.  How is the video?
>   ...maybe try including patches from crbug.com/820961 too.

Minas??

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere
  2018-07-26 20:07 [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson
                   ` (4 preceding siblings ...)
  2018-07-27 10:01 ` [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Felipe Balbi
@ 2018-07-27 11:00 ` Minas Harutyunyan
  5 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:00 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> While looking at a dwc2 recently, I noticed that some platforms still
> have the uframe scheduler off.  As far as I know, nothing good can
> come out of having the uframe scheduler off.  Let's turn it on
> everywhere.  Assuming this all works out then some time in the future
> we can gut all the old code that handles the old non-uframe scheduler
> and make everything simpler.
> 
> This is a repost of the original "RFT" (request for testing) series I
> posted a few weeks ago but without the "RFT" prefix.  Two of the
> patches in the series now have "Tested-by:" tags.  Since there should
> be nothing platform specific about the uFrame scheduler presumably
> this should mean we're good to go?  Specificaly note that in at least
> one of the "Tested-by" reports this patch caused a notable
> improvement.
> 
> In response to the original RFT, some notes about testing this:
> - In general, try to have lots of things plugged in.
> - Plug many different keyboards / mice in.  See if keys are
>    dropped / mouse is jerky.
> - Try USB audio (ideally full speed, not high speed).  How is
>    the audio?
> - If you're brave, try a USB webcam.  How is the video?
>    ...maybe try including patches from crbug.com/820961 too.
> 
> 
> Douglas Anderson (4):
>    usb: dwc2: Turn on uframe_sched on "bcm" platforms
>    usb: dwc2: Turn on uframe_sched on "his" platforms
>    usb: dwc2: Turn on uframe_sched on "amlogic" platforms
>    usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
> 
>   drivers/usb/dwc2/params.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>


^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms
@ 2018-07-27 11:00     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:00 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on HiSilicon since commit
> 37dd9d65cc41 ("usb: dwc2: add support of hi6220").  Since then there
> have been many many improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler")
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 14b8742e62fa..db97bb16ecc4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
>   	p->reload_ctl = false;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> -	p->uframe_sched = false;
>   	p->change_speed_quirk = true;
>   	p->power_down = false;
>   }
> 


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,2/4] usb: dwc2: Turn on uframe_sched on "his" platforms
@ 2018-07-27 11:00     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:00 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on HiSilicon since commit
> 37dd9d65cc41 ("usb: dwc2: add support of hi6220").  Since then there
> have been many many improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler")
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 14b8742e62fa..db97bb16ecc4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -67,7 +67,6 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
>   	p->reload_ctl = false;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR16 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> -	p->uframe_sched = false;
>   	p->change_speed_quirk = true;
>   	p->power_down = false;
>   }
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms
@ 2018-07-27 11:09     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:09 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on Broadcom since commit
> 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
> Since then there have been many many improvements, notably the commit
> 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
> scheduler")
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index af075d4da895..14b8742e62fa 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
>   	p->max_transfer_size = 65535;
>   	p->max_packet_count = 511;
>   	p->ahbcfg = 0x10;
> -	p->uframe_sched = false;
>   }
>   
>   static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
> 


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms
@ 2018-07-27 11:09     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:09 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on Broadcom since commit
> 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
> Since then there have been many many improvements, notably the commit
> 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
> scheduler")
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index af075d4da895..14b8742e62fa 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
>   	p->max_transfer_size = 65535;
>   	p->max_packet_count = 511;
>   	p->ahbcfg = 0x10;
> -	p->uframe_sched = false;
>   }
>   
>   static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms
@ 2018-07-27 11:11     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:11 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on Amlogic since commit f94310ac076e
> ("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
> after most of the recent improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
> the parameters were copied from another platform and the uframe
> scheduler wasn't tried.
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index db97bb16ecc4..93380f7c32b4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> -	p->uframe_sched = false;
>   }
>   
>   static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
> 


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms
@ 2018-07-27 11:11     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:11 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on Amlogic since commit f94310ac076e
> ("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
> after most of the recent improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
> the parameters were copied from another platform and the uframe
> scheduler wasn't tried.
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index db97bb16ecc4..93380f7c32b4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> -	p->uframe_sched = false;
>   }
>   
>   static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
@ 2018-07-27 11:11     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:11 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on stm32f4x9_fsotg since commit
> e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG
> HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so
> it's unclear to me why the uframe scheduler was left off.  Hopefully
> it's because someone copied it from other parameters and didn't think
> to try it?
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 93380f7c32b4..7be35bcde713 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->max_packet_count = 256;
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_FS;
>   	p->i2c_enable = false;
> -	p->uframe_sched = false;
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
> 


^ permalink raw reply	[flat|nested] 19+ messages in thread

* [REPOST,4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms
@ 2018-07-27 11:11     ` Minas Harutyunyan
  0 siblings, 0 replies; 19+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:11 UTC (permalink / raw)
  To: Douglas Anderson, balbi, Minas.Harutyunyan, gregkh
  Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
	john.stultz, Stephen Warren, Jerome Brunet, linux-usb,
	linux-kernel

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on stm32f4x9_fsotg since commit
> e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG
> HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so
> it's unclear to me why the uframe scheduler was left off.  Hopefully
> it's because someone copied it from other parameters and didn't think
> to try it?
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 93380f7c32b4..7be35bcde713 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->max_packet_count = 256;
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_FS;
>   	p->i2c_enable = false;
> -	p->uframe_sched = false;
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2018-07-27 11:11 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-26 20:07 [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Douglas Anderson
2018-07-26 20:07 ` [REPOST PATCH 1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,1/4] " Doug Anderson
2018-07-27 11:09   ` [REPOST PATCH 1/4] " Minas Harutyunyan
2018-07-27 11:09     ` [REPOST,1/4] " Minas Harutyunyan
2018-07-26 20:07 ` [REPOST PATCH 2/4] usb: dwc2: Turn on uframe_sched on "his" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,2/4] " Doug Anderson
2018-07-27 11:00   ` [REPOST PATCH 2/4] " Minas Harutyunyan
2018-07-27 11:00     ` [REPOST,2/4] " Minas Harutyunyan
2018-07-26 20:07 ` [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,3/4] " Doug Anderson
2018-07-27 11:11   ` [REPOST PATCH 3/4] " Minas Harutyunyan
2018-07-27 11:11     ` [REPOST,3/4] " Minas Harutyunyan
2018-07-26 20:07 ` [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms Douglas Anderson
2018-07-26 20:07   ` [REPOST,4/4] " Doug Anderson
2018-07-27 11:11   ` [REPOST PATCH 4/4] " Minas Harutyunyan
2018-07-27 11:11     ` [REPOST,4/4] " Minas Harutyunyan
2018-07-27 10:01 ` [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Felipe Balbi
2018-07-27 11:00 ` Minas Harutyunyan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.