5.7 sleep/wake regression

5.7 sleep/wake regression

[Chris Murphy]

Got an older Macbook Pro that does suspend to RAM and wake OK with
5.6, but starting with git 47acac8cae28, it will not wake up. Instead
it has a black screen, gets hot, fans go to high, and it turns into a
hair dryer. So it's a regression.

I started a bisect but, that's not going well.

$ git bisect good
Bisecting: 123 revisions left to test after this (roughly 7 steps)
[7af51678b6d367ee93dc3d21e72ecf15be50fcb1] docs: deprecated.rst: Add
BUG()-family
$ make -j8

...15 minutes later

  GZIP    arch/x86/boot/compressed/vmlinux.bin.gz
  MKPIGGY arch/x86/boot/compressed/piggy.S
  AS      arch/x86/boot/compressed/piggy.o
  LD      arch/x86/boot/compressed/vmlinux
ld: arch/x86/boot/compressed/pgtable_64.o:(.bss+0x0): multiple
definition of `__force_order';
arch/x86/boot/compressed/kaslr_64.o:(.bss+0x0): first defined here
make[2]: *** [arch/x86/boot/compressed/Makefile:119:
arch/x86/boot/compressed/vmlinux] Error 1
make[1]: *** [arch/x86/boot/Makefile:113:
arch/x86/boot/compressed/vmlinux] Error 2
make: *** [arch/x86/Makefile:283: bzImage] Error 2


I'll give 'git bisect skip' a try and see if it'll get close enough to
the first bad commit.

Anyway, all of 5.6.x sleep/wake fine, and all of 5.7 do not, i.e. it
hasn't been fixed in rc5. Thanks.


-- 
Chris Murphy

Re: 5.7 sleep/wake regression

[Rafael J. Wysocki]

On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
>
> Got an older Macbook Pro that does suspend to RAM and wake OK with
> 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> it has a black screen, gets hot, fans go to high, and it turns into a
> hair dryer. So it's a regression.

There is a known issue addressed by this patch:

https://patchwork.kernel.org/patch/11538065/

so can you please try it?

Re: 5.7 sleep/wake regression

[Chris Murphy]

On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> >
> > Got an older Macbook Pro that does suspend to RAM and wake OK with
> > 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> > it has a black screen, gets hot, fans go to high, and it turns into a
> > hair dryer. So it's a regression.
>
> There is a known issue addressed by this patch:
>
> https://patchwork.kernel.org/patch/11538065/
>
> so can you please try it?

Patch applied, but the problem remains.

CPU is i7-2820QM and dmesg for the working sleep+wake case:
https://paste.centos.org/view/ea5b913d

In the failed wake case, I note the following: the fade-in/out sleep
indicator light on the laptop is pulsing, suggests it did actually
enter sleep OK. When waking by spacebar press, this sleep indicator
light stops pulsing, the backlight does not come on, the laptop does
not respond to either ssh or ping. Following  a power reset and
reboot, the journal's last line is

[   61.678347] fmac.local kernel: PM: suspend entry (deep)

Let me know if I should resume bisect.


-- 
Chris Murphy

Re: 5.7 sleep/wake regression

[Rafael J. Wysocki]

On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
> On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> > >
> > > Got an older Macbook Pro that does suspend to RAM and wake OK with
> > > 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> > > it has a black screen, gets hot, fans go to high, and it turns into a
> > > hair dryer. So it's a regression.
> >
> > There is a known issue addressed by this patch:
> >
> > https://patchwork.kernel.org/patch/11538065/
> >
> > so can you please try it?
> 
> Patch applied, but the problem remains.
> 
> CPU is i7-2820QM and dmesg for the working sleep+wake case:
> https://paste.centos.org/view/ea5b913d
> 
> In the failed wake case, I note the following: the fade-in/out sleep
> indicator light on the laptop is pulsing, suggests it did actually
> enter sleep OK. When waking by spacebar press, this sleep indicator
> light stops pulsing, the backlight does not come on, the laptop does
> not respond to either ssh or ping. Following  a power reset and
> reboot, the journal's last line is
> 
> [   61.678347] fmac.local kernel: PM: suspend entry (deep)
> 
> Let me know if I should resume bisect.

Please first try to revert commit

6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
objects for ASL create_field() operator")

and see if that helps.

I have no other ideas ATM, so please continue bisecting if it doesn't help.

Cheers!

Re: 5.7 sleep/wake regression

[Chris Murphy]

On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
> > On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > >
> > > On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> > > >
> > > > Got an older Macbook Pro that does suspend to RAM and wake OK with
> > > > 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> > > > it has a black screen, gets hot, fans go to high, and it turns into a
> > > > hair dryer. So it's a regression.
> > >
> > > There is a known issue addressed by this patch:
> > >
> > > https://patchwork.kernel.org/patch/11538065/
> > >
> > > so can you please try it?
> >
> > Patch applied, but the problem remains.
> >
> > CPU is i7-2820QM and dmesg for the working sleep+wake case:
> > https://paste.centos.org/view/ea5b913d
> >
> > In the failed wake case, I note the following: the fade-in/out sleep
> > indicator light on the laptop is pulsing, suggests it did actually
> > enter sleep OK. When waking by spacebar press, this sleep indicator
> > light stops pulsing, the backlight does not come on, the laptop does
> > not respond to either ssh or ping. Following  a power reset and
> > reboot, the journal's last line is
> >
> > [   61.678347] fmac.local kernel: PM: suspend entry (deep)
> >
> > Let me know if I should resume bisect.
>
> Please first try to revert commit
>
> 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> objects for ASL create_field() operator")

Still fails. Bisect says

$ git bisect good
b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
commit b41e98524e424d104aa7851d54fd65820759875a
Author: Jens Axboe <axboe@kernel.dk>
Date:   Mon Feb 17 09:52:41 2020 -0700

    io_uring: add per-task callback handler

I'm not that great at git bisect so I'm not sure how to narrow it
down; offhand that doesn't seem a likely culprit.

$ git bisect log
git bisect start
# good: [7111951b8d4973bda27ff663f2cf18b663d15b48] Linux 5.6
git bisect good 7111951b8d4973bda27ff663f2cf18b663d15b48
# bad: [47acac8cae28b36668bf89400c56b7fdebca3e75] Merge tag
'hwmon-for-v5.7' of
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging
git bisect bad 47acac8cae28b36668bf89400c56b7fdebca3e75
# good: [1592614838cb52f4313ceff64894e2ca78591498] Merge tag
'for-5.7/drivers-2020-03-29' of git://git.kernel.dk/linux-block
git bisect good 1592614838cb52f4313ceff64894e2ca78591498
# good: [7af51678b6d367ee93dc3d21e72ecf15be50fcb1] docs:
deprecated.rst: Add BUG()-family
git bisect good 7af51678b6d367ee93dc3d21e72ecf15be50fcb1
# good: [7af51678b6d367ee93dc3d21e72ecf15be50fcb1] docs:
deprecated.rst: Add BUG()-family
git bisect good 7af51678b6d367ee93dc3d21e72ecf15be50fcb1
# bad: [377ad0c28c1df7b0634e697f34bdea8325f39a66] Merge tag
'erofs-for-5.7-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs
git bisect bad 377ad0c28c1df7b0634e697f34bdea8325f39a66
# bad: [bcda7baaa3f15c7a95db3c024bb046d6e298f76b] io_uring: support
buffer selection for OP_READ and OP_RECV
git bisect bad bcda7baaa3f15c7a95db3c024bb046d6e298f76b
# bad: [b41e98524e424d104aa7851d54fd65820759875a] io_uring: add
per-task callback handler
git bisect bad b41e98524e424d104aa7851d54fd65820759875a
# good: [7d67af2c013402537385dae343a2d0f6a4cb3bfd] io_uring: add
splice(2) support
git bisect good 7d67af2c013402537385dae343a2d0f6a4cb3bfd
# good: [5eae8619907a1389dbd1b4a1049caf52782c0916] io_uring: remove
IO_WQ_WORK_CB
git bisect good 5eae8619907a1389dbd1b4a1049caf52782c0916
# good: [6fb614920b38bbf3c1c7fcd944c6d9b5d746103d] task_work_run:
don't take ->pi_lock unconditionally
git bisect good 6fb614920b38bbf3c1c7fcd944c6d9b5d746103d
# good: [c2f2eb7d2c1cdc37fa9633bae96f381d33ee7a14] io_uring: store
io_kiocb in wait->private
git bisect good c2f2eb7d2c1cdc37fa9633bae96f381d33ee7a14
# first bad commit: [b41e98524e424d104aa7851d54fd65820759875a]
io_uring: add per-task callback handler
$



-- 
Chris Murphy

Re: 5.7 sleep/wake regression

[Rafael J. Wysocki]

On Wed, May 13, 2020 at 8:11 AM Chris Murphy <chris@colorremedies.com> wrote:
>
> On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
> > > On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > > >
> > > > On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> > > > >
> > > > > Got an older Macbook Pro that does suspend to RAM and wake OK with
> > > > > 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> > > > > it has a black screen, gets hot, fans go to high, and it turns into a
> > > > > hair dryer. So it's a regression.
> > > >
> > > > There is a known issue addressed by this patch:
> > > >
> > > > https://patchwork.kernel.org/patch/11538065/
> > > >
> > > > so can you please try it?
> > >
> > > Patch applied, but the problem remains.
> > >
> > > CPU is i7-2820QM and dmesg for the working sleep+wake case:
> > > https://paste.centos.org/view/ea5b913d
> > >
> > > In the failed wake case, I note the following: the fade-in/out sleep
> > > indicator light on the laptop is pulsing, suggests it did actually
> > > enter sleep OK. When waking by spacebar press, this sleep indicator
> > > light stops pulsing, the backlight does not come on, the laptop does
> > > not respond to either ssh or ping. Following  a power reset and
> > > reboot, the journal's last line is
> > >
> > > [   61.678347] fmac.local kernel: PM: suspend entry (deep)
> > >
> > > Let me know if I should resume bisect.
> >
> > Please first try to revert commit
> >
> > 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> > objects for ASL create_field() operator")
>
> Still fails. Bisect says
>
> $ git bisect good
> b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
> commit b41e98524e424d104aa7851d54fd65820759875a
> Author: Jens Axboe <axboe@kernel.dk>
> Date:   Mon Feb 17 09:52:41 2020 -0700
>
>     io_uring: add per-task callback handler
>
> I'm not that great at git bisect so I'm not sure how to narrow it
> down; offhand that doesn't seem a likely culprit.

I would try to revert it and see what happens. :-)

Re: 5.7 sleep/wake regression

[Jens Axboe]

On 5/13/20 12:11 AM, Chris Murphy wrote:
> On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>
>> On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
>>> On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>>>
>>>> On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
>>>>>
>>>>> Got an older Macbook Pro that does suspend to RAM and wake OK with
>>>>> 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
>>>>> it has a black screen, gets hot, fans go to high, and it turns into a
>>>>> hair dryer. So it's a regression.
>>>>
>>>> There is a known issue addressed by this patch:
>>>>
>>>> https://patchwork.kernel.org/patch/11538065/
>>>>
>>>> so can you please try it?
>>>
>>> Patch applied, but the problem remains.
>>>
>>> CPU is i7-2820QM and dmesg for the working sleep+wake case:
>>> https://paste.centos.org/view/ea5b913d
>>>
>>> In the failed wake case, I note the following: the fade-in/out sleep
>>> indicator light on the laptop is pulsing, suggests it did actually
>>> enter sleep OK. When waking by spacebar press, this sleep indicator
>>> light stops pulsing, the backlight does not come on, the laptop does
>>> not respond to either ssh or ping. Following  a power reset and
>>> reboot, the journal's last line is
>>>
>>> [   61.678347] fmac.local kernel: PM: suspend entry (deep)
>>>
>>> Let me know if I should resume bisect.
>>
>> Please first try to revert commit
>>
>> 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
>> objects for ASL create_field() operator")
> 
> Still fails. Bisect says
> 
> $ git bisect good
> b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
> commit b41e98524e424d104aa7851d54fd65820759875a
> Author: Jens Axboe <axboe@kernel.dk>
> Date:   Mon Feb 17 09:52:41 2020 -0700
> 
>     io_uring: add per-task callback handler

Yeah, it's definitely not that...

> I'm not that great at git bisect so I'm not sure how to narrow it
> down; offhand that doesn't seem a likely culprit.

How reliable is the test you use to deem a given commit good or
bad? It sucks in terms of time, but it may be useful to re-run
the bisection and ensure that you don't ever have false positives.

-- 
Jens Axboe

Re: 5.7 sleep/wake regression

[Chris Murphy]

On Wed, May 13, 2020 at 8:04 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, May 13, 2020 at 8:11 AM Chris Murphy <chris@colorremedies.com> wrote:
> >
> > On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > >
> > > On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
> > > > On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > > > >
> > > > > On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> > > > > >
> > > > > > Got an older Macbook Pro that does suspend to RAM and wake OK with
> > > > > > 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> > > > > > it has a black screen, gets hot, fans go to high, and it turns into a
> > > > > > hair dryer. So it's a regression.
> > > > >
> > > > > There is a known issue addressed by this patch:
> > > > >
> > > > > https://patchwork.kernel.org/patch/11538065/
> > > > >
> > > > > so can you please try it?
> > > >
> > > > Patch applied, but the problem remains.
> > > >
> > > > CPU is i7-2820QM and dmesg for the working sleep+wake case:
> > > > https://paste.centos.org/view/ea5b913d
> > > >
> > > > In the failed wake case, I note the following: the fade-in/out sleep
> > > > indicator light on the laptop is pulsing, suggests it did actually
> > > > enter sleep OK. When waking by spacebar press, this sleep indicator
> > > > light stops pulsing, the backlight does not come on, the laptop does
> > > > not respond to either ssh or ping. Following  a power reset and
> > > > reboot, the journal's last line is
> > > >
> > > > [   61.678347] fmac.local kernel: PM: suspend entry (deep)
> > > >
> > > > Let me know if I should resume bisect.
> > >
> > > Please first try to revert commit
> > >
> > > 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> > > objects for ASL create_field() operator")
> >
> > Still fails. Bisect says
> >
> > $ git bisect good
> > b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
> > commit b41e98524e424d104aa7851d54fd65820759875a
> > Author: Jens Axboe <axboe@kernel.dk>
> > Date:   Mon Feb 17 09:52:41 2020 -0700
> >
> >     io_uring: add per-task callback handler
> >
> > I'm not that great at git bisect so I'm not sure how to narrow it
> > down; offhand that doesn't seem a likely culprit.
>
> I would try to revert it and see what happens. :-)

It won't revert.

$ git revert b41e98524e4
Auto-merging fs/io_uring.c
CONFLICT (content): Merge conflict in fs/io_uring.c
error: could not revert b41e98524e42... io_uring: add per-task callback handler


-- 
Chris Murphy

Re: 5.7 sleep/wake regression

[Rafael J. Wysocki]

On Thursday, May 14, 2020 7:54:32 AM CEST Chris Murphy wrote:
> On Wed, May 13, 2020 at 8:04 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Wed, May 13, 2020 at 8:11 AM Chris Murphy <chris@colorremedies.com> wrote:
> > >
> > > On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > > >
> > > > On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
> > > > > On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > > > > >
> > > > > > On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> > > > > > >
> > > > > > > Got an older Macbook Pro that does suspend to RAM and wake OK with
> > > > > > > 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> > > > > > > it has a black screen, gets hot, fans go to high, and it turns into a
> > > > > > > hair dryer. So it's a regression.
> > > > > >
> > > > > > There is a known issue addressed by this patch:
> > > > > >
> > > > > > https://patchwork.kernel.org/patch/11538065/
> > > > > >
> > > > > > so can you please try it?
> > > > >
> > > > > Patch applied, but the problem remains.
> > > > >
> > > > > CPU is i7-2820QM and dmesg for the working sleep+wake case:
> > > > > https://paste.centos.org/view/ea5b913d
> > > > >
> > > > > In the failed wake case, I note the following: the fade-in/out sleep
> > > > > indicator light on the laptop is pulsing, suggests it did actually
> > > > > enter sleep OK. When waking by spacebar press, this sleep indicator
> > > > > light stops pulsing, the backlight does not come on, the laptop does
> > > > > not respond to either ssh or ping. Following  a power reset and
> > > > > reboot, the journal's last line is
> > > > >
> > > > > [   61.678347] fmac.local kernel: PM: suspend entry (deep)
> > > > >
> > > > > Let me know if I should resume bisect.
> > > >
> > > > Please first try to revert commit
> > > >
> > > > 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> > > > objects for ASL create_field() operator")
> > >
> > > Still fails. Bisect says
> > >
> > > $ git bisect good
> > > b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
> > > commit b41e98524e424d104aa7851d54fd65820759875a
> > > Author: Jens Axboe <axboe@kernel.dk>
> > > Date:   Mon Feb 17 09:52:41 2020 -0700
> > >
> > >     io_uring: add per-task callback handler
> > >
> > > I'm not that great at git bisect so I'm not sure how to narrow it
> > > down; offhand that doesn't seem a likely culprit.
> >
> > I would try to revert it and see what happens. :-)
> 
> It won't revert.
> 
> $ git revert b41e98524e4
> Auto-merging fs/io_uring.c
> CONFLICT (content): Merge conflict in fs/io_uring.c
> error: could not revert b41e98524e42... io_uring: add per-task callback handler

So there are commits on top of it that would need to be reverted as well.

Never mind.  As Jens said, it is unlikely that this particular commit
introduced the problem anyway.

Re: 5.7 sleep/wake regression

[Chris Murphy]

On Wed, May 13, 2020 at 8:09 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 5/13/20 12:11 AM, Chris Murphy wrote:
> > On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >>
> >> On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
> >>> On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >>>>
> >>>> On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
> >>>>>
> >>>>> Got an older Macbook Pro that does suspend to RAM and wake OK with
> >>>>> 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
> >>>>> it has a black screen, gets hot, fans go to high, and it turns into a
> >>>>> hair dryer. So it's a regression.
> >>>>
> >>>> There is a known issue addressed by this patch:
> >>>>
> >>>> https://patchwork.kernel.org/patch/11538065/
> >>>>
> >>>> so can you please try it?
> >>>
> >>> Patch applied, but the problem remains.
> >>>
> >>> CPU is i7-2820QM and dmesg for the working sleep+wake case:
> >>> https://paste.centos.org/view/ea5b913d
> >>>
> >>> In the failed wake case, I note the following: the fade-in/out sleep
> >>> indicator light on the laptop is pulsing, suggests it did actually
> >>> enter sleep OK. When waking by spacebar press, this sleep indicator
> >>> light stops pulsing, the backlight does not come on, the laptop does
> >>> not respond to either ssh or ping. Following  a power reset and
> >>> reboot, the journal's last line is
> >>>
> >>> [   61.678347] fmac.local kernel: PM: suspend entry (deep)
> >>>
> >>> Let me know if I should resume bisect.
> >>
> >> Please first try to revert commit
> >>
> >> 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> >> objects for ASL create_field() operator")
> >
> > Still fails. Bisect says
> >
> > $ git bisect good
> > b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
> > commit b41e98524e424d104aa7851d54fd65820759875a
> > Author: Jens Axboe <axboe@kernel.dk>
> > Date:   Mon Feb 17 09:52:41 2020 -0700
> >
> >     io_uring: add per-task callback handler
>
> Yeah, it's definitely not that...
>
> > I'm not that great at git bisect so I'm not sure how to narrow it
> > down; offhand that doesn't seem a likely culprit.
>
> How reliable is the test you use to deem a given commit good or
> bad? It sucks in terms of time, but it may be useful to re-run
> the bisection and ensure that you don't ever have false positives.

100%. This laptop never fails to wake from S3. Dozens of sleep/wake
cycles on 5.6, 5.5, going way back. It's 100% fail on all 5.7 rc's.





--
Chris Murphy

Re: 5.7 sleep/wake regression

[Jens Axboe]

On 5/14/20 10:02 AM, Chris Murphy wrote:
> On Wed, May 13, 2020 at 8:09 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 5/13/20 12:11 AM, Chris Murphy wrote:
>>> On Tue, May 12, 2020 at 6:57 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>>>
>>>> On Monday, May 11, 2020 7:37:04 PM CEST Chris Murphy wrote:
>>>>> On Mon, May 11, 2020 at 5:15 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>>>>>
>>>>>> On Mon, May 11, 2020 at 6:22 AM Chris Murphy <chris@colorremedies.com> wrote:
>>>>>>>
>>>>>>> Got an older Macbook Pro that does suspend to RAM and wake OK with
>>>>>>> 5.6, but starting with git 47acac8cae28, it will not wake up. Instead
>>>>>>> it has a black screen, gets hot, fans go to high, and it turns into a
>>>>>>> hair dryer. So it's a regression.
>>>>>>
>>>>>> There is a known issue addressed by this patch:
>>>>>>
>>>>>> https://patchwork.kernel.org/patch/11538065/
>>>>>>
>>>>>> so can you please try it?
>>>>>
>>>>> Patch applied, but the problem remains.
>>>>>
>>>>> CPU is i7-2820QM and dmesg for the working sleep+wake case:
>>>>> https://paste.centos.org/view/ea5b913d
>>>>>
>>>>> In the failed wake case, I note the following: the fade-in/out sleep
>>>>> indicator light on the laptop is pulsing, suggests it did actually
>>>>> enter sleep OK. When waking by spacebar press, this sleep indicator
>>>>> light stops pulsing, the backlight does not come on, the laptop does
>>>>> not respond to either ssh or ping. Following  a power reset and
>>>>> reboot, the journal's last line is
>>>>>
>>>>> [   61.678347] fmac.local kernel: PM: suspend entry (deep)
>>>>>
>>>>> Let me know if I should resume bisect.
>>>>
>>>> Please first try to revert commit
>>>>
>>>> 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
>>>> objects for ASL create_field() operator")
>>>
>>> Still fails. Bisect says
>>>
>>> $ git bisect good
>>> b41e98524e424d104aa7851d54fd65820759875a is the first bad commit
>>> commit b41e98524e424d104aa7851d54fd65820759875a
>>> Author: Jens Axboe <axboe@kernel.dk>
>>> Date:   Mon Feb 17 09:52:41 2020 -0700
>>>
>>>     io_uring: add per-task callback handler
>>
>> Yeah, it's definitely not that...
>>
>>> I'm not that great at git bisect so I'm not sure how to narrow it
>>> down; offhand that doesn't seem a likely culprit.
>>
>> How reliable is the test you use to deem a given commit good or
>> bad? It sucks in terms of time, but it may be useful to re-run
>> the bisection and ensure that you don't ever have false positives.
> 
> 100%. This laptop never fails to wake from S3. Dozens of sleep/wake
> cycles on 5.6, 5.5, going way back. It's 100% fail on all 5.7 rc's.

Reason I ask is unless you're active using io_uring, then there's way
that the io_uring commit is implicated in this particular issue.  And
that would lead me to believe that perhaps there's some false positives
here, where you sometimes resume fine with the broken commit there. This
would skew your bisection results, and ultimately result in a bogus
result.

Hence my suggestion would be to redo the bisection, and perhaps do more
suspend+wake cycles on each commit to be sure that you're definitely
going to flag the offending commit every time.

-- 
Jens Axboe