From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Ivan Vecera <ivecera@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: bridge: fix typo in vlan_filtering dependency test
Date: Mon, 29 Nov 2021 12:01:20 +0200 [thread overview]
Message-ID: <41088611-712e-3f31-cf44-de50359ceccc@nvidia.com> (raw)
In-Reply-To: <20211129095850.2018071-1-ivecera@redhat.com>
On 29/11/2021 11:58, Ivan Vecera wrote:
> Prior patch:
> ]# TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh
> TEST: Vlan multicast snooping enable [ OK ]
> Device "bridge" does not exist.
> TEST: Disable multicast vlan snooping when vlan filtering is disabled [FAIL]
> Vlan filtering is disabled but multicast vlan snooping is still enabled
>
> After patch:
> # TESTS=vlmc_filtering_test ./bridge_vlan_mcast.sh
> TEST: Vlan multicast snooping enable [ OK ]
> TEST: Disable multicast vlan snooping when vlan filtering is disabled [ OK ]
>
> Fixes: f5a9dd58f48b7c ("selftests: net: bridge: add test for vlan_filtering dependency")
> Cc: Nikolay Aleksandrov <nikolay@nvidia.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> index 5224a5a8595b32..8748d1b1d95b71 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_vlan_mcast.sh
> @@ -527,7 +527,7 @@ vlmc_filtering_test()
> {
> RET=0
> ip link set dev br0 type bridge vlan_filtering 0
> - ip -j -d link show dev bridge | \
> + ip -j -d link show dev br0 | \
> jq -e "select(.[0].linkinfo.info_data.mcast_vlan_snooping == 1)" &>/dev/null
> check_fail $? "Vlan filtering is disabled but multicast vlan snooping is still enabled"
> log_test "Disable multicast vlan snooping when vlan filtering is disabled"
>
Good catch, thanks! I've also prepared a few fixes and improvements for the tests,
I'll send them out this week. :)
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
next prev parent reply other threads:[~2021-11-29 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 9:58 [PATCH net-next] selftests: net: bridge: fix typo in vlan_filtering dependency test Ivan Vecera
2021-11-29 10:01 ` Nikolay Aleksandrov [this message]
2021-11-29 13:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41088611-712e-3f31-cf44-de50359ceccc@nvidia.com \
--to=nikolay@nvidia.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.