All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezra Buehler <ezra@easyb.ch>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] arm: mvebu: armada-370-xp.dtsi: add u-boot,dm-pre-reloc to spi0
Date: Sat, 9 May 2020 10:10:37 +0200	[thread overview]
Message-ID: <41088DD6-9363-48BE-B162-0D823C4FE257@easyb.ch> (raw)
In-Reply-To: <5b84fa45-c2f6-ff32-35f9-fb874e96f5b6@denx.de>

Hi Stefan,

On 5 May 2020, at 10:58, Stefan Roese <sr@denx.de> wrote:
> 
> Hi Ezra,
> 
> On 05.05.20 09:10, Ezra Buehler wrote:
>> On 5 May 2020, at 08:45, Stefan Roese <sr@denx.de> wrote:
>>> U-Boot specific DT properties, like "u-boot,dm-pre-reloc" should be
>>> added in U-Boot specific DT dtsi files
>> OK, that makes sense. However, in your commit 1718a9f3b7 (arm: mvebu:
>> armada-370-xp.dtsi: Add "u-boot, dm-pre-reloc" to "internal-regs") you
>> wrote:
>>   I'm not adding this property in an *u-boot.dtsi file, since there is
>>   none matching the generic rules for all files including this dtsi
>>   file. So to not miss any of the boards using this dtsi file, I'm
>>   adding it to this file directly, which makes the Linux merge a less
>>   easy unforunately.
>> So, do you want me to try this now?
> 
> Hmmm, I can't remember the exact details. Thanks for the reference.
> But perhaps there is a matching *-u-boot.dtsi rule / pattern that can
> be used to include such a newly introduced file. I would very much
> welcome it, when you would investigate here.
> 
> Thanks,
> Stefan

From looking at other *.dtsi files I understand one would have to
include the armada-370-xp-u-boot.dtsi in armada-370-xp.dtsi in order to
move the U-Boot-specific properties out. I guess one should then do this
for other boards too. I am not sure if I am confortable with touching
all these boards. Maybe one should do this the next time when syncing
the DTS files with Linux.

If it is OK for you, for this patch, I would simply introduce a
armada-xp-synology-ds414-u-boot.dtsi as Chris suggested.

Cheers,
Ezra.

  reply	other threads:[~2020-05-09  8:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 20:00 [PATCH 1/2] arm: mvebu: armada-370-xp.dtsi: add u-boot, dm-pre-reloc to spi0 Ezra Buehler
2020-05-04  8:04 ` [PATCH 1/2] arm: mvebu: armada-370-xp.dtsi: add u-boot,dm-pre-reloc " Chris Packham
2020-05-04 18:12   ` Ezra Buehler
2020-05-05  6:45     ` Stefan Roese
2020-05-05  7:10       ` Ezra Buehler
2020-05-05  8:58         ` Stefan Roese
2020-05-09  8:10           ` Ezra Buehler [this message]
2020-05-09 11:52             ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41088DD6-9363-48BE-B162-0D823C4FE257@easyb.ch \
    --to=ezra@easyb.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.