From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD14FC4332F for ; Tue, 8 Nov 2022 18:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbiKHSuL (ORCPT ); Tue, 8 Nov 2022 13:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbiKHStx (ORCPT ); Tue, 8 Nov 2022 13:49:53 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D512F627E1 for ; Tue, 8 Nov 2022 10:49:10 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id a13so23957296edj.0 for ; Tue, 08 Nov 2022 10:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=iFEI+OVj3meMKerE8m3XRj1WIR+3TY6afj77dwFQNKU=; b=zQNl4VxL6/HH42SQyC7RyGNCefk+IDdeZXh7OGPP3F7RD1rvw+/PIElhr53HAr6aYT HnDjRNSoe2b7aLI3Gfc5sp6PnIoQk9afxZBlaXYOGEpBBv1qaGGyWo/V1NnRkFPlILen SGIQVa4F0dwpf2ARHzGvsE26abq9gm0BU9eissEjf0Hjst4zGINgZjcvo4Wggp0s2o2E nZTKOpQcGUHEbsht43TxlgP7PyADnNBf+v28nf/RVrTvmnXgqsWS5V2JYn9Hk8kpofCJ yBDH/0QJkK4c4ASlZSgKWXD9TVt6pY3qdJPhpmjALcKZoX/YwVW2vI8hapbIoN+b73yj B9cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iFEI+OVj3meMKerE8m3XRj1WIR+3TY6afj77dwFQNKU=; b=VvQOcaEGlpGcpiFi3RH5rk154HzHtxCjWjxpiyxOB/j/medthZ62nyQpjs5Vk5LlcU Z0oRKHLQTuaZMtgEwewgJSyu/r41l6xVHrSbmveDGIOxRk9hMPBhcQHpuTKaFV2YfdZl lwYbirgVJqhGv7fl1PBW+fiOSFZMi5ILWU5NJOV72wCxuj8EqMM4BTxt+K4PmE31vNf2 cyJw9pqhH+qSmpgQlWNShkexVVpwwW2h57zWgoiBRXxQyc5dC0LSuPrf0vag3cYKuSvJ fSYWQ9D07d3hp2uHpUW92vM9PR2FbH9udKfSmOK39PRhLL6Lxzgl4NflV2RYt6hsiPk3 fsWw== X-Gm-Message-State: ACrzQf1ww+N6Fqz1u3jOZVUgTdOLV1yN1hZCWj0/yyfPpBRjmUIqlfKX IaoUB97R1qZCf6AzpRg5zyVgiNdORArcmwdH X-Google-Smtp-Source: AMsMyM7DLtgr+46W3y81zE9KYE2rJh3K9Swfz6w7mHqc/kxaNTcNqq9Ah0sjkBOh7YlgfOAjnwcjJA== X-Received: by 2002:aa7:d8c4:0:b0:461:8d31:41fc with SMTP id k4-20020aa7d8c4000000b004618d3141fcmr57059380eds.202.1667933349379; Tue, 08 Nov 2022 10:49:09 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id a1-20020a05640213c100b004614c591366sm5828499edx.48.2022.11.08.10.49.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 10:49:08 -0800 (PST) Message-ID: <41242ffc-fd61-ded1-0647-bba1efb60a1e@linaro.org> Date: Tue, 8 Nov 2022 19:49:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/3] ARM: dts: qcom-msm8960: use define for interrupt constants To: Krzysztof Kozlowski , Bjorn Andersson , Andy Gross , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221108184529.26857-1-krzysztof.kozlowski@linaro.org> <20221108184529.26857-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221108184529.26857-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 08/11/2022 19:45, Krzysztof Kozlowski wrote: > Replace GIC_PPI, GIC_SPI and interrupt type numbers with appropriate > defines. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm/boot/dts/qcom-msm8960-cdp.dts | 2 +- > arch/arm/boot/dts/qcom-msm8960.dtsi | 22 ++++++++++++---------- > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts > index cb0f612e6c90..3a484ac53917 100644 > --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts > +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts > @@ -42,7 +42,7 @@ ethernet@0 { > compatible = "micrel,ks8851"; > reg = <0>; > interrupt-parent = <&msmgpio>; > - interrupts = <90 8>; > + interrupts = <90 IRQ_TYPE_LEVEL_LOW>; > spi-max-frequency = <5400000>; > vdd-supply = <&ext_l2>; > vdd-io-supply = <&pm8921_lvs6>; > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index 30abf53b062d..2f32e734f18d 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -17,7 +17,7 @@ / { > cpus { > #address-cells = <1>; > #size-cells = <0>; > - interrupts = <1 14 0x304>; > + interrupts = ; > > cpu@0 { > compatible = "qcom,krait"; > @@ -52,7 +52,7 @@ memory { > > cpu-pmu { > compatible = "qcom,krait-pmu"; > - interrupts = <1 10 0x304>; > + interrupts = ; > qcom,no-pc-write; > }; > > @@ -105,9 +105,9 @@ intc: interrupt-controller@2000000 { > timer@200a000 { > compatible = "qcom,kpss-timer", > "qcom,kpss-wdt-msm8960", "qcom,msm-timer"; > - interrupts = <1 1 0x301>, > - <1 2 0x301>, > - <1 3 0x301>; > + interrupts = , > + , > + ; > reg = <0x0200a000 0x100>; > clock-frequency = <27000000>, > <32768>; > @@ -119,7 +119,7 @@ msmgpio: pinctrl@800000 { > gpio-controller; > gpio-ranges = <&msmgpio 0 0 152>; > #gpio-cells = <2>; > - interrupts = <0 16 0x4>; > + interrupts = ; > interrupt-controller; > #interrupt-cells = <2>; > reg = <0x800000 0x4000>; > @@ -255,7 +255,7 @@ ssbi@500000 { > pmicintc: pmic { > compatible = "qcom,pm8921"; > interrupt-parent = <&msmgpio>; > - interrupts = <104 8>; > + interrupts = <104 IRQ_TYPE_LEVEL_LOW>; > #interrupt-cells = <2>; > interrupt-controller; > #address-cells = <1>; > @@ -265,7 +265,8 @@ pwrkey@1c { > compatible = "qcom,pm8921-pwrkey"; > reg = <0x1c>; > interrupt-parent = <&pmicintc>; > - interrupts = <50 1>, <51 1>; > + interrupts = <50 IRQ_TYPE_EDGE_RISING>, > + <51 IRQ_TYPE_EDGE_RISING>; > debounce = <15625>; > pull-up; > }; > @@ -274,7 +275,8 @@ keypad@148 { > compatible = "qcom,pm8921-keypad"; > reg = <0x148>; > interrupt-parent = <&pmicintc>; > - interrupts = <74 1>, <75 1>; > + interrupts = <74 IRQ_TYPE_EDGE_RISING>, > + <75 IRQ_TYPE_EDGE_RISING>; > debounce = <15>; > scan-delay = <32>; > row-hold = <91500>; > @@ -283,7 +285,7 @@ keypad@148 { > rtc@11d { > compatible = "qcom,pm8921-rtc"; > interrupt-parent = <&pmicintc>; > - interrupts = <39 1>; > + interrupts = <39 IRQ_TYPE_EDGE_RISING>; > reg = <0x11d>; > allow-set-time; > };