From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753707AbbKLPPL (ORCPT ); Thu, 12 Nov 2015 10:15:11 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:62995 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbKLPPJ (ORCPT ); Thu, 12 Nov 2015 10:15:09 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Steven Rostedt , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/rt: hide push_irq_work_func declaration Date: Thu, 12 Nov 2015 16:14:06 +0100 Message-ID: <4129441.9nXLnMzV6v@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151112094739.0168e191@gandalf.local.home> References: <3810009.VdDTV0h1Qp@wuerfel> <20151112094739.0168e191@gandalf.local.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:y0OYOgSLzo36gA5SgDsKr0h+T8pni3Be1nikh+x8KVVWeo4CreU DdHMUiO1Fv9g8HW93YYII6A3TlIty3SiPMcOBp+I8jAQYqhUTLoC/8tm0LkGdaa8z0z4oix uYT4RlUp1Cv0hmlMp6AmUf7gCA2UaEP7hACq6XcXeLsizXgmOuJ85/nhwN3Ocn81nMz5SaA 9AVpc5b0JZThh9N2o9xKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/orGe7K0LMA=:xrm+Z5R3iSoT78NbppoVmS Y8Uz7IrwzbAsm2TGWyE6kBZLt4/oSoBhxnAHkKFoQKNrFcr9FZWwIcMfEhjz2h+tz+5jifkR9 QOpvtuBXsFQeJDo3Ax1itQsqYw0HYMtN4g0LyXi2HGP6UUVMVLvzOdQyP+iSljt/kJdmFHiiG 73cn4/qmU628az8afSHT0dKTYvnMekX9ZXsrx4zYSsvdmsgaR6PNTMM0kGsT0KJ9XH7RXpLM3 qIx0DxNCNI2lk+oOL5qaryWtooLR10Ehcip1zaqeM4dGuDLjCFtF4gGCz5jXwxZrHLnAmXN9O +TPm8GLKFKMymNHytnnzsXhwU9fThderLyJovTQUJZd8Y4VoIEwmvRGQVAE93IgvgWCaLLUUy 4TsDW0dzkceF8CbkSGTln5dYAaaQw5GEzb9YEV+GWxe0trAgmbvijRc/ceRYLIL/llFtIsZqa lPDwZ4v2xIDm59gVCCy0Alvh3glO2D+6pYUqRZsNsQXNvKwDSEQ++mLiowidk3qphatw2hmCE Ig/gAyYk5SA8wdJvqGtrLRF0+dNWhPzZE/kc2VwWDhQwdlzPInN1A42/b2zaddClLiFW9/nfq vZTaS4jrqzDbGpxOXKJVFzJyy5XsvvmZp+ULiLM07WET010hQSnr9bNT8GX/1ceTEb7E9VZBM 8qe35NGJn+MpZUEE/1EKHlSoDF4O96rd3Z5pu0ZgkaM7pteZnpZifGYpHOoFseNHulrxiPevp Zcq5Qwz4SPgdVcal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 November 2015 09:47:39 Steven Rostedt wrote: > > -#ifdef CONFIG_SMP > > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > > Why IS_ENABLED() and not defined()? > > #if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > > I thought IS_ENABLED() is used for C code, like: > > if (IS_ENABLED(CONFIG_SMP)) { > [...] > } "#if IS_ENABLED(CONFIG_foo)" has another property, which is to evaluate to true when Kconfig has set the symbol to "=m". Obviously that cannot happen for CONFIG_SMP, but some maintainers prefer using IS_ENABLED() consistently for all config symbols. I don't care much either way, and it's easily changed if we still want the patch and you prefer a plain #if defined(). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 12 Nov 2015 16:14:06 +0100 Subject: [PATCH] sched/rt: hide push_irq_work_func declaration In-Reply-To: <20151112094739.0168e191@gandalf.local.home> References: <3810009.VdDTV0h1Qp@wuerfel> <20151112094739.0168e191@gandalf.local.home> Message-ID: <4129441.9nXLnMzV6v@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 12 November 2015 09:47:39 Steven Rostedt wrote: > > -#ifdef CONFIG_SMP > > +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > > Why IS_ENABLED() and not defined()? > > #if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) > > I thought IS_ENABLED() is used for C code, like: > > if (IS_ENABLED(CONFIG_SMP)) { > [...] > } "#if IS_ENABLED(CONFIG_foo)" has another property, which is to evaluate to true when Kconfig has set the symbol to "=m". Obviously that cannot happen for CONFIG_SMP, but some maintainers prefer using IS_ENABLED() consistently for all config symbols. I don't care much either way, and it's easily changed if we still want the patch and you prefer a plain #if defined(). Arnd