From: David Howells <email@example.com> To: "Darrick J. Wong" <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH 4/9] generic/317, afs: Allow for a filesystem not to honour the local uid/gid Date: Tue, 25 May 2021 17:41:17 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20210525161730.GE202095@locust> Darrick J. Wong <email@example.com> wrote: > > +_require_use_local_uidgid() > > I find "local uid" to be misleading here -- I read it as "requires > system to use local user/group ids", as opposed to getting user and > group data from an external service like NIS/YP/AD. > > What you're really testing for is that new files inherit the fs[ug]id of > the process. How about we make that explicit in the name: > > _require_inherit_process_fsuid() > _require_inherit_process_fsgid() > > ? Um. I'm not sure "inherit" is the right verb here. Or "require" for that matter. Would it make more sense to state it differently? Maybe say what is being checked: _test_expects_inode_to_get_fsuid _test_expects_inode_to_get_fsgid or maybe: _expects_filesystem_to_set_owner_from_fsuid though that could also be: _require_filesystem_to_set_owner_from_fsuid David
next prev parent reply other threads:[~2021-05-25 16:41 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-25 13:33 [PATCH 0/9] Add support for using xfstests to test AFS David Howells 2021-05-25 13:33 ` [PATCH 1/9] Add AFS support David Howells 2021-05-25 13:34 ` [PATCH 2/9] generic/294, afs: Allow for mknod subtest failing if mknod not supported David Howells 2021-05-25 16:09 ` Darrick J. Wong 2021-05-25 16:19 ` David Howells 2021-05-25 16:26 ` Darrick J. Wong 2021-05-30 12:49 ` Eryu Guan 2021-06-01 14:31 ` David Howells 2021-06-06 11:58 ` Eryu Guan 2021-05-25 13:34 ` [PATCH 3/9] generic/314, afs: Allow for a filesystem that doesn't honour SGID inheritance David Howells 2021-05-25 16:10 ` Darrick J. Wong 2021-05-25 13:34 ` [PATCH 4/9] generic/317, afs: Allow for a filesystem not to honour the local uid/gid David Howells 2021-05-25 16:17 ` Darrick J. Wong 2021-05-25 16:41 ` David Howells [this message] 2021-05-25 13:34 ` [PATCH 5/9] generic/123, generic/128, afs: Allow for an fs that does its own perm management David Howells 2021-05-25 16:19 ` Darrick J. Wong 2021-05-25 16:44 ` David Howells 2021-05-25 16:51 ` Darrick J. Wong 2021-05-25 13:34 ` [PATCH 6/9] Add the ability to require O_TMPFILE to be supported for a test David Howells 2021-05-25 16:19 ` Darrick J. Wong 2021-05-30 12:54 ` Eryu Guan 2021-05-25 13:34 ` [PATCH 7/9] afs: Indicate the minimum DIO alignment is 1 David Howells 2021-05-25 13:34 ` [PATCH 8/9] generic/465: Fix handling of DIO alignment < sizeof(long) David Howells 2021-05-25 16:25 ` Darrick J. Wong 2021-05-25 16:46 ` David Howells 2021-05-25 13:34 ` [PATCH 9/9] Fix other posix_memalign() alignment issues David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 4/9] generic/317, afs: Allow for a filesystem not to honour the local uid/gid' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.