From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbeDQOaA (ORCPT ); Tue, 17 Apr 2018 10:30:00 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40642 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752634AbeDQO3v (ORCPT ); Tue, 17 Apr 2018 10:29:51 -0400 Subject: Re: [PATCH v4 02/15] KVM: s390: reset crypto attributes for all vcpus To: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1523827345-11600-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523827345-11600-3-git-send-email-akrowiak@linux.vnet.ibm.com> From: Halil Pasic Date: Tue, 17 Apr 2018 16:29:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1523827345-11600-3-git-send-email-akrowiak@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18041714-0008-0000-0000-000004EC4FF5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041714-0009-0000-0000-00001E8054AF Message-Id: <41496d07-54b3-5cc6-8803-a935f6d821ee@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-17_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2018 11:22 PM, Tony Krowiak wrote: > Introduces a new function to reset the crypto attributes for all > vcpus whether they are running or not. Each vcpu in KVM will > be removed from SIE prior to resetting the crypto attributes in its > SIE state description. After all vcpus have had their crypto attributes > reset the vcpus will be restored to SIE. > > This function will be used in a later patch to set the ECA.28 > bit in the SIE state description to enable interpretive execution of > AP instructions. It will also be incorporated into the > kvm_s390_vm_set_crypto(kvm) function to fix an issue whereby the crypto > key wrapping attributes could potentially get out of synch for running > vcpus. > Wasn't this 'issue' reported by me by any chance? I agree with Connnie, we don't need the forward reference to ECA.28. Regards, Halil > Signed-off-by: Tony Krowiak