From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbdLHTAt (ORCPT ); Fri, 8 Dec 2017 14:00:49 -0500 Received: from mout.web.de ([212.227.15.14]:56747 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbdLHTAp (ORCPT ); Fri, 8 Dec 2017 14:00:45 -0500 To: linux-serial@vger.kernel.org, Alexander Shiyan , Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] serial: max310x: Delete an error message for a failed memory allocation in max310x_probe() Message-ID: <4153838e-4796-537c-7b7f-98404d4f3481@users.sourceforge.net> Date: Fri, 8 Dec 2017 20:00:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gijYA5RCeUbjQfT88S46syDwVL3XNcgUlfiRoVHx9iDO8y1bjsQ o/wfDevD3MDqecY3yz3rqhqLyL/gsLyvEvcLBTQX0AAnVF4UUryKXORmCJp9Fro1PC4O30x BmjfEfz1CkPOPjMXJSVbHzl2m530J2DyeCY7hPJHGEfAkUgx0BgyMLufBEmSUyewAaAoL5f VvVyd+k0iLCMQS5f57L5Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:DDfZDbh92u0=:qt6a+SmDqOOsjUQzZAEf1h 8IkisG6aMR1XSxyNcS/jsiAfLbVdpM9FYEfcJITL3s665IOCEwLcpOeNCEr6uRFxEqhNZsIUL dC6uvLEPyFo9L5YmHz4k8SGMPgW4x9Dpi4ub98cELmhYsKedbSqxIhmjAKNWznsWWWUXu5Fl7 hjtKVRH4qFf6Ro1F3rRtpvY7zje5BWXU+VOiDuB5ktx4rw7CrOaUaNKlMRFRiQNjPFjY3kmpE lhyobQUS3Iei03OcFNecZKd2sgY11wxj6zvNArYxguEUKnvxvajDbNNxgxGzhlJBjMRRbsXzP WIDI5IFQ51wO+MOziZLtPNK3RJCDzw8Ha2ghW9S9qr2VJzK3Expqr1/g90wePbDxEnA+cy/aJ cCWOui9cA8WsmfStWF6hW06+46Q5G8C2+yEziNbZ0PDaM3sTrzfR8ieAW5Pvfxp9a8OBjjyij UdS7HETOaKiGsXC/PJnR4reh772/MonCh8CFAF4gTdC3oDeVGYxC/nPS0SNZzKAbKlZV3nIQx l+RnQsguAi8L1I8p2pkUyNYO1YAqGSlhMw2EFQeTXoDzt7+g88o/iAefR9yTdt/Nmb1HAvQEY YDqM6rXnxO3SS9rglT2YZP2XjXb53KRYy/CRLW1p3XJIJgPterkWRdkAofQGrqJV4+WJQV38Y RqRso27+N6+AxSbF6Pq+A86Q93MYwWd95phRrQ6lFyRWY602mR4tsnaJGMTFab372L2D3Blj/ eHw8IdgOsn8f/k64Ivq8AxS8Nnp8c70jcUlR4U16BTFto4Q+f7vy4lqMQJLstb6iGWcHqhiTz SHt60sgUAKM4oqMur3HAfiVobM2AkNQXvs5o2tdGAPJ28nB3cI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 19:53:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/max310x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index ecb6513a6505..2aad36f402fd 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1102,10 +1102,8 @@ static int max310x_probe(struct device *dev, struct max310x_devtype *devtype, /* Alloc port structure */ s = devm_kzalloc(dev, sizeof(*s) + sizeof(struct max310x_one) * devtype->nr, GFP_KERNEL); - if (!s) { - dev_err(dev, "Error allocating port structure\n"); + if (!s) return -ENOMEM; - } clk_osc = devm_clk_get(dev, "osc"); clk_xtal = devm_clk_get(dev, "xtal"); -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 08 Dec 2017 19:00:34 +0000 Subject: [PATCH] serial: max310x: Delete an error message for a failed memory allocation in max310x_probe() Message-Id: <4153838e-4796-537c-7b7f-98404d4f3481@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-serial@vger.kernel.org, Alexander Shiyan , Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 19:53:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/max310x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index ecb6513a6505..2aad36f402fd 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c @@ -1102,10 +1102,8 @@ static int max310x_probe(struct device *dev, struct max310x_devtype *devtype, /* Alloc port structure */ s = devm_kzalloc(dev, sizeof(*s) + sizeof(struct max310x_one) * devtype->nr, GFP_KERNEL); - if (!s) { - dev_err(dev, "Error allocating port structure\n"); + if (!s) return -ENOMEM; - } clk_osc = devm_clk_get(dev, "osc"); clk_xtal = devm_clk_get(dev, "xtal"); -- 2.15.1