From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Li.Xiubo@freescale.com" Subject: Re: [PATCH 01/15] ASoC: fsl-ssi: Use regmap Date: Wed, 5 Mar 2014 07:04:25 +0000 Message-ID: <41557d94bd77446bbaa9b7a2c26e5016@BY2PR03MB505.namprd03.prod.outlook.com> References: <1393430538-32333-1-git-send-email-mpa@pengutronix.de> <1393430538-32333-2-git-send-email-mpa@pengutronix.de> <6dc5873dcdf54e13aecbf7c6be03f8bf@BY2PR03MB505.namprd03.prod.outlook.com> <20140305062114.GT13126@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0143.outbound.protection.outlook.com [207.46.163.143]) by alsa0.perex.cz (Postfix) with ESMTP id 66D9C264FDF for ; Wed, 5 Mar 2014 08:04:32 +0100 (CET) In-Reply-To: <20140305062114.GT13126@sirena.org.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "Fabio.Estevam@freescale.com" , "alsa-devel@alsa-project.org" , Timur Tabi , "kernel@pengutronix.de" , "guangyu.chen@freescale.com" , Markus Pargmann , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org > Subject: Re: [PATCH 01/15] ASoC: fsl-ssi: Use regmap > > On Thu, Feb 27, 2014 at 02:08:45AM +0000, Li.Xiubo@freescale.com wrote: > > > > +static const struct regmap_config fsl_ssi_regconfig = { > > > + .max_register = CCSR_SSI_SACCDIS, > > > + .reg_bits = 32, > > > + .val_bits = 32, > > > + .reg_stride = 4, > > > +#ifdef PPC > > > + .val_format_endian = REGMAP_ENDIAN_BIG, > > > +#endif > > > Is this really needed for your PPC platforms? > > > If so, I think this should depend on one specified platform, which > > the CPU is in LE mode while the SSI is in BE mode... > > Since the entire series depends on this patch due to the fact that it > makes changes throughout the driver we need this resolving to make any > progress here. Perhaps it makes sense to restructure the series so that > this is at the end rather than start of the series? Yes, that's better, maybe this one need further discussing. Thanks, -- Best Regards, Xiubo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li.Xiubo@freescale.com (Li.Xiubo at freescale.com) Date: Wed, 5 Mar 2014 07:04:25 +0000 Subject: [PATCH 01/15] ASoC: fsl-ssi: Use regmap In-Reply-To: <20140305062114.GT13126@sirena.org.uk> References: <1393430538-32333-1-git-send-email-mpa@pengutronix.de> <1393430538-32333-2-git-send-email-mpa@pengutronix.de> <6dc5873dcdf54e13aecbf7c6be03f8bf@BY2PR03MB505.namprd03.prod.outlook.com> <20140305062114.GT13126@sirena.org.uk> Message-ID: <41557d94bd77446bbaa9b7a2c26e5016@BY2PR03MB505.namprd03.prod.outlook.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Subject: Re: [PATCH 01/15] ASoC: fsl-ssi: Use regmap > > On Thu, Feb 27, 2014 at 02:08:45AM +0000, Li.Xiubo at freescale.com wrote: > > > > +static const struct regmap_config fsl_ssi_regconfig = { > > > + .max_register = CCSR_SSI_SACCDIS, > > > + .reg_bits = 32, > > > + .val_bits = 32, > > > + .reg_stride = 4, > > > +#ifdef PPC > > > + .val_format_endian = REGMAP_ENDIAN_BIG, > > > +#endif > > > Is this really needed for your PPC platforms? > > > If so, I think this should depend on one specified platform, which > > the CPU is in LE mode while the SSI is in BE mode... > > Since the entire series depends on this patch due to the fact that it > makes changes throughout the driver we need this resolving to make any > progress here. Perhaps it makes sense to restructure the series so that > this is at the end rather than start of the series? Yes, that's better, maybe this one need further discussing. Thanks, -- Best Regards, Xiubo