All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Loffgren <daniel@loffgren.org>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h
Date: Mon, 25 Sep 2017 21:22:08 -0700	[thread overview]
Message-ID: <415B68ED-AFB4-4673-8B66-90F74C4B64E1@loffgren.org> (raw)
In-Reply-To: <759768e1-9acb-c14b-7136-743cba166ef0@redhat.com>


> On Sep 25, 2017, at 9:10 AM, Eric Blake <eblake@redhat.com> wrote:
> 
> On 09/24/2017 08:02 PM, Daniel Loffgren wrote:
>> 
>> Signed-off-by: Daniel Loffgren <daniel@loffgren.org <mailto:daniel@loffgren.org>>
>> ---
>> include/exec/user/thunk.h | 1 +
>> 1 file changed, 1 insertion(+)
> 
> meta-comment: your patch is titled 2/2, but was sent as its own
> top-level thread (it is missing In-Reply-To: and References: headers).
> When sending 2 patches as a series, it is important to include a 0/2
> cover letter, and to properly thread things so that both 1/2 and 2/2 are
> in-reply-to the 0/2 cover letter.  'git send-email' is probably the
> easiest way to get this to work.  More patch submission hints at:
> 
> https://wiki.qemu.org/Contribute/SubmitAPatch <https://wiki.qemu.org/Contribute/SubmitAPatch>

Oops, sorry about that! I used 'git format-patch' to get this email from a set of two commits, and sent each as-is. This commit can totally stand alone.

>> 
>> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
>> index f19ef4b230..12b5449d8c 100644
>> --- a/include/exec/user/thunk.h
>> +++ b/include/exec/user/thunk.h
>> @@ -19,6 +19,7 @@
>> #ifndef THUNK_H
>> #define THUNK_H
>> 
>> +#include "abitypes.h"
>> #include "cpu.h"
>> 
>> /* types enums definitions */
>> 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org <http://qemu.org/> | libvirt.org <http://libvirt.org/>

  reply	other threads:[~2017-09-26  4:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25  1:02 [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h Daniel Loffgren
2017-09-25 16:10 ` Eric Blake
2017-09-26  4:22   ` Daniel Loffgren [this message]
2017-09-25 16:37 ` Thomas Huth
2017-09-26  4:22   ` Daniel Loffgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=415B68ED-AFB4-4673-8B66-90F74C4B64E1@loffgren.org \
    --to=daniel@loffgren.org \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.