From: Oleksii <oleksii.kurochko@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH v3 3/3] xen/riscv: initialize .bss section
Date: Fri, 03 Mar 2023 12:42:06 +0200 [thread overview]
Message-ID: <415ea0b45a1d6539935ef77181d08aa22e00f7e5.camel@gmail.com> (raw)
In-Reply-To: <009206ce-1750-95f2-7f6f-34c71f0b79ec@citrix.com>
On Fri, 2023-03-03 at 10:33 +0000, Andrew Cooper wrote:
> On 03/03/2023 10:24 am, Oleksii Kurochko wrote:
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> > diff --git a/xen/arch/riscv/riscv64/head.S
> > b/xen/arch/riscv/riscv64/head.S
> > index adf5d6c74a..8887f0cbd4 100644
> > --- a/xen/arch/riscv/riscv64/head.S
> > +++ b/xen/arch/riscv/riscv64/head.S
> > @@ -18,6 +19,14 @@ ENTRY(start)
> > li t0, SSTATUS_FS
> > csrc CSR_SSTATUS, t0
> >
> > + /* Clear the BSS */
> > + la t3, __bss_start
> > + la t4, __bss_end
> > +.L_clear_bss:
> > + REG_S zero, (t3)
> > + add t3, t3, __SIZEOF_POINTER__
> > + bltu t3, t4, .L_clear_bss
>
> Using t3/t4 is fine, but it would also have been fine to use t0/t1.
Yeah, I understand that. It was easier to rename and not confuse
something.
Could you please rename them during commit?
Have I to send new patch version?
~ Oleksii
next prev parent reply other threads:[~2023-03-03 10:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 10:24 [PATCH v3 0/3] Do basic initialization things Oleksii Kurochko
2023-03-03 10:24 ` [PATCH v3 1/3] xen/riscv: disable fpu Oleksii Kurochko
2023-03-03 10:25 ` Andrew Cooper
2023-03-09 10:39 ` Bobby Eshleman
2023-03-09 10:42 ` Bobby Eshleman
2023-03-03 10:24 ` [PATCH v3 2/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader Oleksii Kurochko
2023-03-03 10:27 ` Andrew Cooper
2023-03-03 10:39 ` Oleksii
2023-03-09 10:44 ` Bobby Eshleman
2023-03-03 10:24 ` [PATCH v3 3/3] xen/riscv: initialize .bss section Oleksii Kurochko
2023-03-03 10:33 ` Andrew Cooper
2023-03-03 10:42 ` Oleksii [this message]
2023-03-03 10:53 ` Andrew Cooper
2023-03-03 11:06 ` Oleksii
2023-03-09 10:48 ` Bobby Eshleman
2023-03-05 7:06 ` [PATCH v3 0/3] Do basic initialization things Bobby Eshleman
2023-03-16 0:37 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415ea0b45a1d6539935ef77181d08aa22e00f7e5.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.