From: Hannes Reinecke <hare@suse.de>
To: Martin Wilck <mwilck@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart van Assche <bvanassche@acm.org>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH 52/52] scsi: Drop the now obsolete driver_byte definitions
Date: Tue, 19 Nov 2019 10:31:21 +0100 [thread overview]
Message-ID: <4164a4a2-d206-b4de-367b-6c94f0bbbf99@suse.de> (raw)
In-Reply-To: <4b19bf3fdb242f166b203c456243553c09a22c92.camel@suse.de>
On 11/19/19 10:02 AM, Martin Wilck wrote:
> On Mon, 2019-11-04 at 10:01 +0100, Hannes Reinecke wrote:
>> The driver_byte field in the result is now unused, so we can drop
>> the definitions.
>>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>> Documentation/scsi/scsi_mid_low_api.txt | 3 +--
>> block/bsg-lib.c | 2 +-
>> block/bsg.c | 2 +-
>> block/scsi_ioctl.c | 2 +-
>> drivers/scsi/constants.c | 14 --------------
>> drivers/scsi/scsi_logging.c | 10 ++--------
>> drivers/scsi/sd.c | 9 ++++-----
>> drivers/scsi/sd_zbc.c | 4 ++--
>> drivers/scsi/sg.c | 5 ++---
>> drivers/scsi/sr.c | 2 +-
>> drivers/scsi/sr_ioctl.c | 2 +-
>> drivers/scsi/st.c | 4 ++--
>> include/scsi/scsi.h | 3 ---
>> include/scsi/scsi_cmnd.h | 4 ----
>> include/trace/events/scsi.h | 7 +------
>> 15 files changed, 19 insertions(+), 54 deletions(-)
>>
>
> While I generally like this change, the driver byte is part of the
> sg_io user space API, and used in sg3_utils and multipath-tools (in
> particular, DRIVER_SENSE), and likely in other user space tools as
> well. Can we simply ditch it without adding some compatibility code to
> sg and bsg?
>
Why, but I did...
sg and bsg should report to userland exactly the same values as before;
or at least that was the plan.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
next prev parent reply other threads:[~2019-11-19 9:31 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 9:00 [PATCHv3 00/52] Revamp SCSI result values Hannes Reinecke
2019-11-04 9:01 ` [PATCH 01/52] aic7xxx,aic79xxx: remove driver-defined SAM status definitions Hannes Reinecke
2019-11-04 9:01 ` [PATCH 02/52] bfa: drop driver-defined SCSI status codes Hannes Reinecke
2019-11-04 9:01 ` [PATCH 03/52] wd33c93: use SCSI status Hannes Reinecke
2019-11-04 9:01 ` [PATCH 04/52] acornscsi: use standard defines Hannes Reinecke
2019-11-04 9:01 ` [PATCH 05/52] libata-scsi: use standard SAM status codes Hannes Reinecke
2019-11-04 17:36 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 06/52] ib_srp: " Hannes Reinecke
2019-11-04 17:36 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 07/52] 3w-xxxx: " Hannes Reinecke
2019-11-04 17:37 ` Bart Van Assche
2019-11-05 2:06 ` adam radford
2019-11-04 9:01 ` [PATCH 08/52] arcmsr: " Hannes Reinecke
2019-11-04 17:37 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 09/52] dc395x: " Hannes Reinecke
2019-11-04 17:38 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 10/52] megaraid: " Hannes Reinecke
2019-11-04 17:39 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 11/52] megaraid_mboxi: " Hannes Reinecke
2019-11-04 17:39 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 12/52] gdth: " Hannes Reinecke
2019-11-04 17:40 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 13/52] dpt_i2o: " Hannes Reinecke
2019-11-04 17:40 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 14/52] nsp_cs: " Hannes Reinecke
2019-11-04 17:42 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 15/52] nsp32: fixup status handling Hannes Reinecke
2019-11-04 9:01 ` [PATCH 16/52] dc395: drop private SAM status code definitions Hannes Reinecke
2019-11-04 17:42 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 17/52] qla4xxx: use standard SAM status definitions Hannes Reinecke
2019-11-04 17:43 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 18/52] scsi: change status_byte() to return the standard SCSI status Hannes Reinecke
2019-11-04 17:45 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 19/52] target_core: Fixup target_complete_cmd() usage Hannes Reinecke
2019-11-04 9:01 ` [PATCH 20/52] sg: use SAM status definitions and avoid using masked_status Hannes Reinecke
2019-11-05 6:03 ` Douglas Gilbert
2019-11-04 9:01 ` [PATCH 21/52] initio: use standard SAM status definitions Hannes Reinecke
2019-11-04 17:46 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 22/52] scsi: Kill obsolete linux-specific status codes Hannes Reinecke
2019-11-04 17:46 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 23/52] scsi: introduce set_status_byte() Hannes Reinecke
2019-11-04 9:01 ` [PATCH 24/52] advansys: kill driver_defined status byte accessors Hannes Reinecke
2019-11-04 9:01 ` [PATCH 25/52] scsi: introduce scsi_build_sense() Hannes Reinecke
2019-11-04 17:47 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 26/52] libata-scsi: use scsi_build_sense() Hannes Reinecke
2019-11-04 9:01 ` [PATCH 27/52] zfcp: " Hannes Reinecke
2019-11-04 17:49 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 28/52] 3w-xxxx: " Hannes Reinecke
2019-11-04 17:49 ` Bart Van Assche
2019-11-05 2:13 ` adam radford
2019-11-04 9:01 ` [PATCH 29/52] libiscsi: " Hannes Reinecke
2019-11-04 17:49 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 30/52] lpfc: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 31/52] mpt3sas: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 32/52] mvumi: " Hannes Reinecke
2019-11-04 17:50 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 33/52] myrb: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 34/52] myrs: " Hannes Reinecke
2019-11-04 17:50 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 35/52] ps3rom: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 36/52] qla2xxx: " Hannes Reinecke
2019-11-04 17:51 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 37/52] scsi_debug: " Hannes Reinecke
2019-11-05 6:03 ` Douglas Gilbert
2019-11-04 9:01 ` [PATCH 38/52] smartpqi: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 39/52] stex: " Hannes Reinecke
2019-11-04 17:52 ` Bart Van Assche
2019-11-04 9:01 ` [PATCH 40/52] scsi: Kill DRIVER_SENSE Hannes Reinecke
2019-11-19 8:32 ` Martin Wilck
2019-11-04 9:01 ` [PATCH 41/52] scsi: Kill DRIVER_HARD Hannes Reinecke
2019-11-04 9:01 ` [PATCH 42/52] scsi_error: use DID_TIME_OUT instead of DRIVER_TIMEOUT Hannes Reinecke
2019-11-04 9:01 ` [PATCH 43/52] scsi: Kill DRIVER_TIMEOUT Hannes Reinecke
2019-11-04 9:01 ` [PATCH 44/52] scsi: do not use DRIVER_INVALID Hannes Reinecke
2019-11-04 9:01 ` [PATCH 45/52] st: return error code in st_scsi_execute() Hannes Reinecke
2019-11-04 9:01 ` [PATCH 46/52] scsi_ioctl: return error code when blk_rq_map_kern() fails Hannes Reinecke
2019-11-04 9:01 ` [PATCH 47/52] scsi_dh_alua: do not interpret DRIVER_ERROR Hannes Reinecke
2019-11-04 9:01 ` [PATCH 48/52] 3w-9xxx: Kill unreachable code in twa_interrupt() Hannes Reinecke
2019-11-05 2:04 ` adam radford
2019-11-04 9:01 ` [PATCH 49/52] xen-scsiback: stop using DRIVER_ERROR Hannes Reinecke
2019-11-04 9:01 ` [PATCH 50/52] scsi: " Hannes Reinecke
2019-11-04 9:01 ` [PATCH 51/52] scsi: Kill DRIVER_MEDIA, DRIVER_SOFT, and DRIVER_BUSY Hannes Reinecke
2019-11-04 9:01 ` [PATCH 52/52] scsi: Drop the now obsolete driver_byte definitions Hannes Reinecke
2019-11-19 9:02 ` Martin Wilck
2019-11-19 9:31 ` Hannes Reinecke [this message]
2019-11-19 11:03 ` Martin Wilck
2019-11-19 11:56 ` Hannes Reinecke
2019-11-15 7:42 ` [PATCHv3 00/52] Revamp SCSI result values Hannes Reinecke
2019-11-19 3:35 ` Martin K. Petersen
2019-11-19 7:10 ` Hannes Reinecke
2019-11-20 3:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4164a4a2-d206-b4de-367b-6c94f0bbbf99@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.