From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267375AbUJGPGQ (ORCPT ); Thu, 7 Oct 2004 11:06:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266896AbUJGPGO (ORCPT ); Thu, 7 Oct 2004 11:06:14 -0400 Received: from omx1-ext.sgi.com ([192.48.179.11]:38357 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S267386AbUJGPER (ORCPT ); Thu, 7 Oct 2004 11:04:17 -0400 Message-ID: <41655A91.1010307@sgi.com> Date: Thu, 07 Oct 2004 10:02:41 -0500 From: Patrick Gefre User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jesse Barnes CC: Grant Grundler , Colin Ngam , "Luck, Tony" , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization References: <20041006195424.GF25773@cup.hp.com> <41645150.6020608@sgi.com> <200410061344.38265.jbarnes@engr.sgi.com> In-Reply-To: <200410061344.38265.jbarnes@engr.sgi.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jesse Barnes wrote: > On Wednesday, October 6, 2004 1:10 pm, Patrick Gefre wrote: > >>I don't plan on respinning the large patches (unless of course they get out >>of date). It would be great to get the kill, add and qla patch in so we can >>move forward and address some these other smaller issues - rather than >>holding up the larger mods for them. > > > I agree, but could you please just 'vi' the 002-add-files patch and remove > these? > > drivers/char/mmtimer.c | 1 > drivers/char/snsc.c | 25 > drivers/ide/pci/sgiioc4.c | 23 > drivers/serial/sn_console.c | 214 > > They should each be separate cleanup patches. What I've done in the past is > make copies (in this case 5) of the big patch. Then I edit all of them to > include only the hunks I want there. Hopefully that'll minimize the pain of > respinning the big patch (i.e. no respin). Also, Tony doesn't want to deal > with the above files, patches for them should be sent to Andrew as separate > mails with lkml in the cc list. > These are not cleanup. The mmtimer code and sn_console include a file that doesn't exist anymore in the directory included - it's moved to somewhere else in the 002 patch. snsc.c, sgiioc4.c have changes for things that won't exist after this patch is applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Gefre Date: Thu, 07 Oct 2004 15:02:41 +0000 Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization Message-Id: <41655A91.1010307@sgi.com> List-Id: References: <20041006195424.GF25773@cup.hp.com> <41645150.6020608@sgi.com> <200410061344.38265.jbarnes@engr.sgi.com> In-Reply-To: <200410061344.38265.jbarnes@engr.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jesse Barnes Cc: Grant Grundler , Colin Ngam , "Luck, Tony" , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Jesse Barnes wrote: > On Wednesday, October 6, 2004 1:10 pm, Patrick Gefre wrote: > >>I don't plan on respinning the large patches (unless of course they get out >>of date). It would be great to get the kill, add and qla patch in so we can >>move forward and address some these other smaller issues - rather than >>holding up the larger mods for them. > > > I agree, but could you please just 'vi' the 002-add-files patch and remove > these? > > drivers/char/mmtimer.c | 1 > drivers/char/snsc.c | 25 > drivers/ide/pci/sgiioc4.c | 23 > drivers/serial/sn_console.c | 214 > > They should each be separate cleanup patches. What I've done in the past is > make copies (in this case 5) of the big patch. Then I edit all of them to > include only the hunks I want there. Hopefully that'll minimize the pain of > respinning the big patch (i.e. no respin). Also, Tony doesn't want to deal > with the above files, patches for them should be sent to Andrew as separate > mails with lkml in the cc list. > These are not cleanup. The mmtimer code and sn_console include a file that doesn't exist anymore in the directory included - it's moved to somewhere else in the 002 patch. snsc.c, sgiioc4.c have changes for things that won't exist after this patch is applied.