From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxGdh-0006Qt-GK for qemu-devel@nongnu.org; Thu, 20 Oct 2016 12:56:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxGdc-0006W8-Lz for qemu-devel@nongnu.org; Thu, 20 Oct 2016 12:56:21 -0400 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:36045) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bxGdc-0006Vb-D6 for qemu-devel@nongnu.org; Thu, 20 Oct 2016 12:56:16 -0400 Received: by mail-lf0-x229.google.com with SMTP id b75so91172988lfg.3 for ; Thu, 20 Oct 2016 09:56:16 -0700 (PDT) Sender: Paolo Bonzini References: <20161018140141.GF12728@redhat.com> <87wph4g44n.fsf@dusky.pond.sub.org> <20161019081210.GA2035@work-vm> <20161019084235.GE11194@redhat.com> <87twc8d60e.fsf@dusky.pond.sub.org> <20161019100552.GD2035@work-vm> <20161019101616.GL11194@redhat.com> <87a8e0bkl6.fsf@dusky.pond.sub.org> <20161019122158.GS11194@redhat.com> <20161019180616.GF2035@work-vm> <20161020083730.GC12145@redhat.com> From: Paolo Bonzini Message-ID: <417509f7-1640-39ca-cf95-06494a0b8ce5@redhat.com> Date: Thu, 20 Oct 2016 18:56:11 +0200 MIME-Version: 1.0 In-Reply-To: <20161020083730.GC12145@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] chardev's and fd's in monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , "Dr. David Alan Gilbert" Cc: Markus Armbruster , qemu-devel@nongnu.org On 20/10/2016 10:37, Daniel P. Berrange wrote: > You have a problem of context - if you have multiple monitors, how do > you know which to send the error back to if you're not in the event > loop thread, and thus cur_mon is NULL. With Marc-Andre's series which > allows proper async command processing it gets even harder, because > there's potentially many outstanding commands associated with a monitor > and you need to decide which the error should be given to. Why should it even consult the current monitor? Shouldn't errors go to all HMP monitors when QEMU falls back to error_report? Paolo