From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B54C432BE for ; Thu, 19 Aug 2021 11:21:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A046C60720 for ; Thu, 19 Aug 2021 11:21:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A046C60720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9BF2382F34; Thu, 19 Aug 2021 13:20:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="LXsawFP+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2AC288312C; Thu, 19 Aug 2021 13:20:09 +0200 (CEST) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA6E782DDB for ; Thu, 19 Aug 2021 13:20:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=monstr@monstr.eu Received: by mail-wm1-x329.google.com with SMTP id c129-20020a1c35870000b02902e6b6135279so3850794wma.0 for ; Thu, 19 Aug 2021 04:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x7tsr6pszz3q3qo+OunFG3jaL3QZArfP5+n29JAMS7I=; b=LXsawFP+8/gsyI08LGbuq8dgTeA4wqmFrTwoAcD75yR83EeBy6dsJDYtxB6HGFrEm/ P2IuN+hFP6F8BKQNg8fxloW3uWuQa/6PVOACtKu/YDZW27Gk/3qtleI0tMe91ZcUZHuD 7kTd0OPPeStw1LNuRFQCfza09EDT4JjShn2gWYOgzaD40sCUmhUxgndpd5fbFcGp8QxS 9zWlp6Lu4/vGvQHtX9B2Zt3cqZxV4tEiVOeWkSq9hIwXdUxhxhnYQ5/dSNrMXi+4trEO +94nYXOjucWfbD+9KHzQ7tvSh6ttJImusLMMbfBrn0Z+5S4XAhiS5+PRmHz5qr3V8gw9 Utkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=x7tsr6pszz3q3qo+OunFG3jaL3QZArfP5+n29JAMS7I=; b=fSQ1IO6qOUssHcc0GVqqOqRPN4CJbo9H7hhgOjUrAuw7sXXtLn+n7MJFTjSY7NZiWd 6pLwfaMI+Nbk7o+oPkKiSyk+pqPZeHEZpKCv1yk4WRXQVZ7EyJf2PDjiaA+ohiIZdefP p8YEtYUJNn+kEKfSxMDLrpc71m/N67telLIJPlyu47I1kqr9893KBQ1Xz3iYJ8ZifMCr dMtFmFs/N0n4Yrt360orjPaGCi4kxOg4cGo0Rlv7FXtrhA2wTiHJDe89zJxNsYbFu9dz W+oZK2PJaIeO80QLP0vEpdecenAEWfVUZzM/9mJ2DEJMUN3gg8Cc8LjpNHtzFj3MHW56 viMw== X-Gm-Message-State: AOAM530QZc7ngTORW7wO+9f0s9SYewVTdDvw07cWMK4IJKLCyjrDqbLK vYrqBkUl4JG+3+ycVtpfUu1HaVdgJCvMs4M3 X-Google-Smtp-Source: ABdhPJyy4rREC+UCOHV0obrv1Op6+kvX61P2Rbp8/VfkLFuLSi9ObyftPjxQuG6JbE0W1TgAcpYo/A== X-Received: by 2002:a7b:cd82:: with SMTP id y2mr13572546wmj.4.1629372000289; Thu, 19 Aug 2021 04:20:00 -0700 (PDT) Received: from localhost ([2a02:768:2307:40d6:f666:9af6:3fed:e53b]) by smtp.gmail.com with ESMTPSA id e11sm2640894wrm.80.2021.08.19.04.19.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Aug 2021 04:19:59 -0700 (PDT) From: Michal Simek To: u-boot@lists.denx.de, git@xilinx.com Cc: Ashok Reddy Soma , Michal Simek , T Karthik Reddy Subject: [PATCH 04/10] xilinx: common: Free allocated structure Date: Thu, 19 Aug 2021 13:19:43 +0200 Message-Id: <41750e4a064884f8573accf368222671b1ae1311.1629371983.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean There is no need to keep fru_content around. Free this space. Signed-off-by: Michal Simek --- board/xilinx/common/board.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 44c8aa5eefbb..2aecb14d8e27 100644 --- a/board/xilinx/common/board.c +++ b/board/xilinx/common/board.c @@ -185,8 +185,7 @@ static int xilinx_read_eeprom_fru(struct udevice *dev, char *name, eeprom_size); if (ret) { debug("%s: I2C EEPROM read failed\n", __func__); - free(fru_content); - return ret; + goto end; } printf("Xilinx I2C FRU format at %s:\n", name); @@ -194,12 +193,13 @@ static int xilinx_read_eeprom_fru(struct udevice *dev, char *name, ret = fru_display(0); if (ret) { printf("FRU format decoding failed.\n"); - return ret; + goto end; } if (desc->header == EEPROM_HEADER_MAGIC) { debug("Information already filled\n"); - return -EINVAL; + ret = -EINVAL; + goto end; } /* It is clear that FRU was captured and structures were filled */ @@ -217,7 +217,9 @@ static int xilinx_read_eeprom_fru(struct udevice *dev, char *name, sizeof(desc->serial)); desc->header = EEPROM_HEADER_MAGIC; - return 0; +end: + free(fru_content); + return ret; } static bool xilinx_detect_fru(u8 *buffer) -- 2.32.0